Skip to content

N
nx-libs
Commit 50eb5e4a authored by Ulrich Sibiller's avatar Ulrich Sibiller Committed by Ulrich Sibiller
Browse files
Options

sendexev.c: Fix return of unitialized variable

Well, kinda fix. Upstream handles that differently here, we need a thorough check! Add another FIXME comment because of this.
parent 151e0b16
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 3 deletions
nx-X11/programs/Xserver/Xi/sendexev.c
View file @ 50eb5e4a
...@@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client) ...@@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client)
return Success; return Success;
} }
// FIXME: ret is not initialized and should not be returned... /*
the previous code here returned the unitialized variable ret,
so using Success we have defined returncode at least. FIXME:
Upstream works different here, we must check this!
*/
if (stuff->num_events == 0) if (stuff->num_events == 0)
return ret; /* return ret; */
return Success;
/* The client's event type must be one defined by an extension. */ /* The client's event type must be one defined by an extension. */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment