nxagentReversePointerMap: Don't assume Xevent.xbutton.button is always greater…

nxagentReversePointerMap: Don't assume Xevent.xbutton.button is always greater than zero. We have seen Xevent.xbutton.button being set to AnyButton (equaling 0). Fixes ArcticaProject/nx-libs#92 Fixes X2GoBTS#791

nxagentReversePointerMap: Don't assume Xevent.xbutton.button is always greater…
5e17d05a · Mike Gabriel · 61d0fbea · 5e17d05a · 5e17d05a
Commit 5e17d05a authored Jun 13, 2016 by Mike Gabriel
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

Events.c nx-X11/programs/Xserver/hw/nxagent/Events.c +2 -2

Pointer.c nx-X11/programs/Xserver/hw/nxagent/Pointer.c +1 -1

No files found.
--- a/nx-X11/programs/Xserver/hw/nxagent/Events.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Events.c
@@ -1252,7 +1252,7 @@ FIXME: Don't enqueue the KeyRelease event if the key was
                    X.xbutton.subwindow == None))
        {
          x.u.u.type = ButtonPress;
-          x.u.u.detail = inputInfo.pointer -> button -> map[nxagentReversePointerMap[X.xbutton.button - 1]];
+          x.u.u.detail = inputInfo.pointer -> button -> map[nxagentReversePointerMap[X.xbutton.button]];
          x.u.keyButtonPointer.time = nxagentLastEventTime = GetTimeInMillis();
          if (nxagentOption(Rootless))
@@ -1325,7 +1325,7 @@ FIXME: Don't enqueue the KeyRelease event if the key was
        if (minimize != True)
        {
          x.u.u.type = ButtonRelease;
-          x.u.u.detail = inputInfo.pointer -> button -> map[nxagentReversePointerMap[X.xbutton.button - 1]];
+          x.u.u.detail = inputInfo.pointer -> button -> map[nxagentReversePointerMap[X.xbutton.button]];
          x.u.keyButtonPointer.time = nxagentLastEventTime = GetTimeInMillis();
          if (nxagentOption(Rootless))

--- a/nx-X11/programs/Xserver/hw/nxagent/Pointer.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Pointer.c
@@ -186,6 +186,6 @@ void nxagentInitPointerMap(void)
  for (i = 1; i <= numButtons; i++)
  {
-    nxagentReversePointerMap[pointerMap[i - 1] - 1] = i;
+    nxagentReversePointerMap[pointerMap[i - 1]] = i;
  }
 }