Unverified Commit 61b8d44f authored by Mike Gabriel's avatar Mike Gabriel

Merge branch 'uli42-pr/fix_compile_warnings' into 3.6.x

parents da01dc8d 50eb5e4a
...@@ -42,7 +42,7 @@ char **XGetFontPath( ...@@ -42,7 +42,7 @@ char **XGetFontPath(
int count = 0; int count = 0;
register unsigned i; register unsigned i;
register int length; register int length;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq (GetFontPath, req); GetEmptyReq (GetFontPath, req);
......
...@@ -36,7 +36,7 @@ XGetInputFocus( ...@@ -36,7 +36,7 @@ XGetInputFocus(
int *revert_to) int *revert_to)
{ {
xGetInputFocusReply rep; xGetInputFocusReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GetInputFocus, req); GetEmptyReq(GetInputFocus, req);
(void) _XReply (dpy, (xReply *)&rep, 0, xTrue); (void) _XReply (dpy, (xReply *)&rep, 0, xTrue);
......
...@@ -35,7 +35,7 @@ XGetKeyboardControl ( ...@@ -35,7 +35,7 @@ XGetKeyboardControl (
register XKeyboardState *state) register XKeyboardState *state)
{ {
xGetKeyboardControlReply rep; xGetKeyboardControlReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq (GetKeyboardControl, req); GetEmptyReq (GetKeyboardControl, req);
(void) _XReply (dpy, (xReply *) &rep, (void) _XReply (dpy, (xReply *) &rep,
......
...@@ -38,7 +38,7 @@ XGetPointerControl( ...@@ -38,7 +38,7 @@ XGetPointerControl(
int *threshold) int *threshold)
{ {
xGetPointerControlReply rep; xGetPointerControlReply rep;
xReq *req; _X_UNUSED xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GetPointerControl, req); GetEmptyReq(GetPointerControl, req);
(void) _XReply (dpy, (xReply *)&rep, 0, xTrue); (void) _XReply (dpy, (xReply *)&rep, 0, xTrue);
......
...@@ -45,7 +45,7 @@ int XGetPointerMapping ( ...@@ -45,7 +45,7 @@ int XGetPointerMapping (
unsigned char mapping[256]; /* known fixed size */ unsigned char mapping[256]; /* known fixed size */
unsigned long nbytes, remainder = 0; unsigned long nbytes, remainder = 0;
xGetPointerMappingReply rep; xGetPointerMappingReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GetPointerMapping, req); GetEmptyReq(GetPointerMapping, req);
......
...@@ -40,7 +40,7 @@ XGetScreenSaver( ...@@ -40,7 +40,7 @@ XGetScreenSaver(
{ {
xGetScreenSaverReply rep; xGetScreenSaverReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GetScreenSaver, req); GetEmptyReq(GetScreenSaver, req);
......
...@@ -32,7 +32,7 @@ in this Software without prior written authorization from The Open Group. ...@@ -32,7 +32,7 @@ in this Software without prior written authorization from The Open Group.
int int
XGrabServer (register Display *dpy) XGrabServer (register Display *dpy)
{ {
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GrabServer, req); GetEmptyReq(GrabServer, req);
UnlockDisplay(dpy); UnlockDisplay(dpy);
......
...@@ -147,8 +147,8 @@ EXTRA_LIBRARIES = /**/ ...@@ -147,8 +147,8 @@ EXTRA_LIBRARIES = /**/
POLL_DEFINES = -DUSE_POLL POLL_DEFINES = -DUSE_POLL
#endif #endif
CONN_DEFINES = $(CONNECTION_FLAGS) CONN_DEFINES = $(CONNECTION_FLAGS)
XTRANS_X_DEFINES = $(XTRANS_FAILDEFINES) XTRANS_X_DEFINES = -DX11_t -DTRANS_CLIENT $(XTRANS_FAILDEFINES)
XTRANS_XIM_DEFINES = $(XTRANS_FAILDEFINES) XTRANS_XIM_DEFINES = -DXIM_t -DTRANS_CLIENT $(XTRANS_FAILDEFINES)
#if HasBSD44Sockets #if HasBSD44Sockets
SOCK_DEFINES = -DBSD44SOCKETS SOCK_DEFINES = -DBSD44SOCKETS
#endif #endif
......
...@@ -795,9 +795,6 @@ LINEAR_RGB_InitSCCData( ...@@ -795,9 +795,6 @@ LINEAR_RGB_InitSCCData(
return(XcmsSuccess); return(XcmsSuccess);
FreeBlueTblElements:
Xfree(pScreenData->pBlueTbl->pBase);
FreeBlueTbl: FreeBlueTbl:
Xfree(pScreenData->pBlueTbl); Xfree(pScreenData->pBlueTbl);
......
...@@ -77,7 +77,7 @@ XHostAddress *XListHosts ( ...@@ -77,7 +77,7 @@ XHostAddress *XListHosts (
xListHostsReply reply; xListHostsReply reply;
unsigned char *buf, *bp; unsigned char *buf, *bp;
register unsigned i; register unsigned i;
register xListHostsReq *req; _X_UNUSED register xListHostsReq *req;
XServerInterpretedAddress *sip; XServerInterpretedAddress *sip;
*nhosts = 0; *nhosts = 0;
......
...@@ -41,7 +41,7 @@ char **XListExtensions( ...@@ -41,7 +41,7 @@ char **XListExtensions(
int count = 0; int count = 0;
register unsigned i; register unsigned i;
register int length; register int length;
register xReq *req; _X_UNUSED register xReq *req;
unsigned long rlen = 0; unsigned long rlen = 0;
LockDisplay(dpy); LockDisplay(dpy);
......
...@@ -292,7 +292,7 @@ int XAddPixel( ...@@ -292,7 +292,7 @@ int XAddPixel(
int int
XNoOp (register Display *dpy) XNoOp (register Display *dpy)
{ {
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(NoOperation, req); GetEmptyReq(NoOperation, req);
......
...@@ -34,7 +34,7 @@ XModifierKeymap * ...@@ -34,7 +34,7 @@ XModifierKeymap *
XGetModifierMapping(register Display *dpy) XGetModifierMapping(register Display *dpy)
{ {
xGetModifierMappingReply rep; xGetModifierMappingReply rep;
register xReq *req; _X_UNUSED register xReq *req;
unsigned long nbytes; unsigned long nbytes;
XModifierKeymap *res; XModifierKeymap *res;
...@@ -84,7 +84,7 @@ XSetModifierMapping( ...@@ -84,7 +84,7 @@ XSetModifierMapping(
req->length += mapSize >> 2; req->length += mapSize >> 2;
req->numKeyPerModifier = modifier_map->max_keypermod; req->numKeyPerModifier = modifier_map->max_keypermod;
Data(dpy, modifier_map->modifiermap, mapSize); Data(dpy, (const char *)modifier_map->modifiermap, mapSize);
(void) _XReply(dpy, (xReply *) & rep, (void) _XReply(dpy, (xReply *) & rep,
(SIZEOF(xSetModifierMappingReply) - SIZEOF(xReply)) >> 2, xTrue); (SIZEOF(xSetModifierMappingReply) - SIZEOF(xReply)) >> 2, xTrue);
......
...@@ -41,7 +41,7 @@ int XEventsQueued ( ...@@ -41,7 +41,7 @@ int XEventsQueued (
{ {
int ret_val; int ret_val;
#if defined(NX_TRANS_SOCKET) && defined(NX_TRANS_TEST) #if defined(NX_TRANS_SOCKET) && defined(NX_TRANS_TEST)
fprintf(stderr, "\nXEventsQueued: Called with a display at [%p].\n", dpy); fprintf(stderr, "\nXEventsQueued: Called with a display at [%p].\n", (void *)dpy);
#endif #endif
LockDisplay(dpy); LockDisplay(dpy);
...@@ -50,7 +50,7 @@ int XEventsQueued ( ...@@ -50,7 +50,7 @@ int XEventsQueued (
else else
ret_val = _XEventsQueued (dpy, mode); ret_val = _XEventsQueued (dpy, mode);
#if defined(NX_TRANS_SOCKET) && defined(NX_TRANS_TEST) #if defined(NX_TRANS_SOCKET) && defined(NX_TRANS_TEST)
fprintf(stderr, "\nXEventsQueued: Going to unlock the display at [%p].\n", dpy); fprintf(stderr, "\nXEventsQueued: Going to unlock the display at [%p].\n", (void *)dpy);
#endif #endif
UnlockDisplay(dpy); UnlockDisplay(dpy);
return ret_val; return ret_val;
......
...@@ -39,7 +39,7 @@ XQueryKeymap( ...@@ -39,7 +39,7 @@ XQueryKeymap(
char keys[32]) char keys[32])
{ {
xQueryKeymapReply rep; xQueryKeymapReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(QueryKeymap, req); GetEmptyReq(QueryKeymap, req);
......
...@@ -105,7 +105,7 @@ Status XReconfigureWMWindow ( ...@@ -105,7 +105,7 @@ Status XReconfigureWMWindow (
*/ */
{ {
xGetInputFocusReply rep; xGetInputFocusReply rep;
register xReq *req; _X_UNUSED register xReq *req;
GetEmptyReq(GetInputFocus, req); GetEmptyReq(GetInputFocus, req);
(void) _XReply (dpy, (xReply *)&rep, 0, xTrue); (void) _XReply (dpy, (xReply *)&rep, 0, xTrue);
......
...@@ -37,7 +37,7 @@ XSync ( ...@@ -37,7 +37,7 @@ XSync (
Bool discard) Bool discard)
{ {
xGetInputFocusReply rep; xGetInputFocusReply rep;
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(GetInputFocus, req); GetEmptyReq(GetInputFocus, req);
......
...@@ -33,7 +33,7 @@ int ...@@ -33,7 +33,7 @@ int
XUngrabServer ( XUngrabServer (
register Display *dpy) register Display *dpy)
{ {
register xReq *req; _X_UNUSED register xReq *req;
LockDisplay(dpy); LockDisplay(dpy);
GetEmptyReq(UngrabServer, req); GetEmptyReq(UngrabServer, req);
......
...@@ -36,7 +36,7 @@ THE USE OR PERFORMANCE OF THIS SOFTWARE. ...@@ -36,7 +36,7 @@ THE USE OR PERFORMANCE OF THIS SOFTWARE.
/***====================================================================***/ /***====================================================================***/
extern void void
XkbNoteDeviceChanges(XkbDeviceChangesPtr old, XkbNoteDeviceChanges(XkbDeviceChangesPtr old,
XkbExtensionDeviceNotifyEvent *new, XkbExtensionDeviceNotifyEvent *new,
unsigned int wanted) unsigned int wanted)
......
...@@ -874,7 +874,7 @@ void _XSeqSyncFunction( ...@@ -874,7 +874,7 @@ void _XSeqSyncFunction(
register Display *dpy) register Display *dpy)
{ {
xGetInputFocusReply rep; xGetInputFocusReply rep;
register xReq *req; _X_UNUSED register xReq *req;
#ifdef NX_TRANS_SOCKET #ifdef NX_TRANS_SOCKET
#ifdef NX_TRANS_DEBUG #ifdef NX_TRANS_DEBUG
...@@ -3743,6 +3743,8 @@ _XIOError ( ...@@ -3743,6 +3743,8 @@ _XIOError (
dpy->flags &= ~XlibDisplayReadEvents; dpy->flags &= ~XlibDisplayReadEvents;
dpy->flags &= ~XlibDisplayWriting; dpy->flags &= ~XlibDisplayWriting;
dpy->flags &= ~XlibDisplayReply; dpy->flags &= ~XlibDisplayReply;
/* shut up the compiler by returning something */
return 0;
#else #else
exit (1); exit (1);
#endif #endif
......
...@@ -856,7 +856,12 @@ extern int _XError( ...@@ -856,7 +856,12 @@ extern int _XError(
); );
extern int _XIOError( extern int _XIOError(
Display* /* dpy */ Display* /* dpy */
#ifdef NX_TRANS_SOCKET
);
#else
) _X_NORETURN; ) _X_NORETURN;
#endif /* NX_TRANS_SOCKET */
extern int (*_XIOErrorFunction)( extern int (*_XIOErrorFunction)(
Display* /* dpy */ Display* /* dpy */
); );
......
...@@ -181,7 +181,7 @@ CmapRecForColormap( ...@@ -181,7 +181,7 @@ CmapRecForColormap(
} }
{ {
xGetInputFocusReply rep; xGetInputFocusReply rep;
register xReq *req; _X_UNUSED register xReq *req;
GetEmptyReq(GetInputFocus, req); GetEmptyReq(GetInputFocus, req);
(void) _XReply (dpy, (xReply *)&rep, 0, xTrue); (void) _XReply (dpy, (xReply *)&rep, 0, xTrue);
......
...@@ -510,14 +510,15 @@ _XimCreateDefaultTree( ...@@ -510,14 +510,15 @@ _XimCreateDefaultTree(
Xim im) Xim im)
{ {
FILE *fp = NULL; FILE *fp = NULL;
char *name, *tmpname = NULL, *intname; char *name, *tmpname = NULL;
char *cachename = NULL; char *cachename = NULL;
/* Should use getpwent() instead of $HOME (cross-platform?) */ /* Should use getpwent() instead of $HOME (cross-platform?) */
char *home = getenv("HOME"); char *home = getenv("HOME");
char *cachedir = NULL;
char *tmpcachedir = NULL; char *tmpcachedir = NULL;
int hl = home ? strlen (home) : 0; int hl = home ? strlen (home) : 0;
#ifdef COMPOSECACHE #ifdef COMPOSECACHE
char *intname;
char *cachedir = NULL;
const char *encoding = nl_langinfo (CODESET); const char *encoding = nl_langinfo (CODESET);
uid_t euid = geteuid (); uid_t euid = geteuid ();
gid_t egid = getegid (); gid_t egid = getegid ();
...@@ -545,9 +546,9 @@ _XimCreateDefaultTree( ...@@ -545,9 +546,9 @@ _XimCreateDefaultTree(
if (name == (char *) NULL) { if (name == (char *) NULL) {
tmpname = name = _XlcFileName(im->core.lcd, COMPOSE_FILE); tmpname = name = _XlcFileName(im->core.lcd, COMPOSE_FILE);
} }
#ifdef COMPOSECACHE
intname = name; intname = name;
#ifdef COMPOSECACHE
if (getuid () == euid && getgid () == egid && euid != 0) { if (getuid () == euid && getgid () == egid && euid != 0) {
char *c; char *c;
/* Usage: XCOMPOSECACHE=<cachedir>[=<filename>] /* Usage: XCOMPOSECACHE=<cachedir>[=<filename>]
......
...@@ -1027,10 +1027,8 @@ freeByteM( ...@@ -1027,10 +1027,8 @@ freeByteM(
} }
blst = codeset->byteM; blst = codeset->byteM;
for (i = 0; i < codeset->length; i++) { for (i = 0; i < codeset->length; i++) {
if (blst[i].byteinfo) {
Xfree(blst[i].byteinfo); Xfree(blst[i].byteinfo);
blst[i].byteinfo = NULL; blst[i].byteinfo = NULL;
}
} }
Xfree(codeset->byteM); Xfree(codeset->byteM);
codeset->byteM = NULL; codeset->byteM = NULL;
...@@ -1044,20 +1042,18 @@ freeConversion( ...@@ -1044,20 +1042,18 @@ freeConversion(
if (codeset->mbconv) { if (codeset->mbconv) {
mbconv = codeset->mbconv; mbconv = codeset->mbconv;
/* ... */ /* ... */
if (mbconv->convlist) { Xfree(mbconv->convlist);
Xfree(mbconv->convlist); mbconv->convlist = NULL;
mbconv->convlist = NULL;
}
Xfree(mbconv); Xfree(mbconv);
codeset->mbconv = NULL; codeset->mbconv = NULL;
} }
if (codeset->ctconv) { if (codeset->ctconv) {
ctconv = codeset->ctconv; ctconv = codeset->ctconv;
/* ... */ /* ... */
if (ctconv->convlist) { Xfree(ctconv->convlist);
Xfree(ctconv->convlist); ctconv->convlist = NULL;
ctconv->convlist = NULL;
}
Xfree(ctconv); Xfree(ctconv);
codeset->ctconv = NULL; codeset->ctconv = NULL;
} }
...@@ -1072,14 +1068,12 @@ freeExtdSegment( ...@@ -1072,14 +1068,12 @@ freeExtdSegment(
return; return;
} }
ctextseg = codeset->ctextseg; ctextseg = codeset->ctextseg;
if (ctextseg->name) { Xfree(ctextseg->name);
Xfree(ctextseg->name); ctextseg->name = NULL;
ctextseg->name = NULL;
} Xfree(ctextseg->area);
if (ctextseg->area) { ctextseg->area = NULL;
Xfree(ctextseg->area);
ctextseg->area = NULL;
}
Xfree(codeset->ctextseg); Xfree(codeset->ctextseg);
codeset->ctextseg = NULL; codeset->ctextseg = NULL;
} }
...@@ -1093,10 +1087,10 @@ freeParseInfo( ...@@ -1093,10 +1087,10 @@ freeParseInfo(
return; return;
} }
parse_info = codeset->parse_info; parse_info = codeset->parse_info;
if (parse_info->encoding) {
Xfree(parse_info->encoding); Xfree(parse_info->encoding);
parse_info->encoding = NULL; parse_info->encoding = NULL;
}
Xfree(codeset->parse_info); Xfree(codeset->parse_info);
codeset->parse_info = NULL; codeset->parse_info = NULL;
} }
...@@ -1115,10 +1109,10 @@ destroy_CodeSetList( ...@@ -1115,10 +1109,10 @@ destroy_CodeSetList(
freeConversion(codeset[i]); freeConversion(codeset[i]);
freeExtdSegment(codeset[i]); freeExtdSegment(codeset[i]);
freeParseInfo(codeset[i]); freeParseInfo(codeset[i]);
if (codeset[i]->charset_list) {
Xfree(codeset[i]->charset_list); Xfree(codeset[i]->charset_list);
codeset[i]->charset_list = NULL; codeset[i]->charset_list = NULL;
}
Xfree(codeset[i]); codeset[i]=NULL; Xfree(codeset[i]); codeset[i]=NULL;
} }
Xfree(codeset); gen->codeset_list = NULL; Xfree(codeset); gen->codeset_list = NULL;
...@@ -1130,21 +1124,20 @@ destroy_SegConv( ...@@ -1130,21 +1124,20 @@ destroy_SegConv(
{ {
SegConv seg = gen->segment_conv; SegConv seg = gen->segment_conv;
int i; int i;
if (gen->segment_conv_num == 0) { if (gen->segment_conv_num == 0) {
return; return;
} }
for (i=0;i<gen->segment_conv_num;i++) { for (i=0;i<gen->segment_conv_num;i++) {
if (seg[i].source_encoding) {
Xfree(seg[i].source_encoding); Xfree(seg[i].source_encoding);
seg[i].source_encoding = NULL; seg[i].source_encoding = NULL;
}
if (seg[i].destination_encoding) {
Xfree(seg[i].destination_encoding); Xfree(seg[i].destination_encoding);
seg[i].destination_encoding = NULL; seg[i].destination_encoding = NULL;
}
if (seg[i].conv) { Xfree(seg[i].conv);
Xfree(seg[i].conv); seg[i].conv = NULL; seg[i].conv = NULL;
}
} }
Xfree(seg); gen->segment_conv = NULL; Xfree(seg); gen->segment_conv = NULL;
} }
...@@ -1156,14 +1149,13 @@ destroy_gen( ...@@ -1156,14 +1149,13 @@ destroy_gen(
XLCdGenericPart *gen = XLC_GENERIC_PART(lcd); XLCdGenericPart *gen = XLC_GENERIC_PART(lcd);
destroy_SegConv(gen); destroy_SegConv(gen);
destroy_CodeSetList(gen); destroy_CodeSetList(gen);
if (gen->mb_parse_table) {
Xfree(gen->mb_parse_table); Xfree(gen->mb_parse_table);
gen->mb_parse_table = NULL; gen->mb_parse_table = NULL;
}
if (gen->mb_parse_list) { Xfree(gen->mb_parse_list);
Xfree(gen->mb_parse_list); gen->mb_parse_list = NULL;
gen->mb_parse_list = NULL;
}
} }
/* VW/UDC end 95.01.08 */ /* VW/UDC end 95.01.08 */
......
...@@ -148,7 +148,7 @@ int (*SwappedUntrustedProcVector[256])( ...@@ -148,7 +148,7 @@ int (*SwappedUntrustedProcVector[256])(
* try a set of well known paths. * try a set of well known paths.
*/ */
const char *_NXGetPolicyFilePath(const char *path) char *_NXGetPolicyFilePath(const char *path)
{ {
struct stat SecurityPolicyStat; struct stat SecurityPolicyStat;
...@@ -1345,7 +1345,6 @@ SecurityCensorImage(client, pVisibleRegion, widthBytesLine, pDraw, x, y, w, h, ...@@ -1345,7 +1345,6 @@ SecurityCensorImage(client, pVisibleRegion, widthBytesLine, pDraw, x, y, w, h,
unsigned int format; unsigned int format;
char * pBuf; char * pBuf;
{ {
ScreenPtr pScreen = pDraw->pScreen;
RegionRec imageRegion; /* region representing x,y,w,h */ RegionRec imageRegion; /* region representing x,y,w,h */
RegionRec censorRegion; /* region to obliterate */ RegionRec censorRegion; /* region to obliterate */
BoxRec imageBox; BoxRec imageBox;
......
...@@ -40,11 +40,7 @@ from The Open Group. ...@@ -40,11 +40,7 @@ from The Open Group.
#include <nx-X11/extensions/xcmiscstr.h> #include <nx-X11/extensions/xcmiscstr.h>
#include "modinit.h" #include "modinit.h"
#if HAVE_STDINT_H
#include <stdint.h> #include <stdint.h>
#elif !defined(UINT32_MAX)
#define UINT32_MAX 0xffffffffU
#endif
#if 0 #if 0
static unsigned char XCMiscCode; static unsigned char XCMiscCode;
......
...@@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client) ...@@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client)
return Success; return Success;
} }
// FIXME: ret is not initialized and should not be returned... /*
the previous code here returned the unitialized variable ret,
so using Success we have defined returncode at least. FIXME:
Upstream works different here, we must check this!
*/
if (stuff->num_events == 0) if (stuff->num_events == 0)
return ret; /* return ret; */
return Success;
/* The client's event type must be one defined by an extension. */ /* The client's event type must be one defined by an extension. */
......
...@@ -721,7 +721,7 @@ ProcDbeSwapBuffers(client) ...@@ -721,7 +721,7 @@ ProcDbeSwapBuffers(client)
int error; int error;
unsigned int i, j; unsigned int i, j;
unsigned int nStuff; unsigned int nStuff;
int nStuff_i; /* DDX API requires int for nStuff */
REQUEST_AT_LEAST_SIZE(xDbeSwapBuffersReq); REQUEST_AT_LEAST_SIZE(xDbeSwapBuffersReq);
nStuff = stuff->n; /* use local variable for performance. */ nStuff = stuff->n; /* use local variable for performance. */
...@@ -806,10 +806,11 @@ ProcDbeSwapBuffers(client) ...@@ -806,10 +806,11 @@ ProcDbeSwapBuffers(client)
* could deal with cross-screen synchronization. * could deal with cross-screen synchronization.
*/ */
while (nStuff > 0) nStuff_i = nStuff;
while (nStuff_i > 0)
{ {
pDbeScreenPriv = DBE_SCREEN_PRIV_FROM_WINDOW(swapInfo[0].pWindow); pDbeScreenPriv = DBE_SCREEN_PRIV_FROM_WINDOW(swapInfo[0].pWindow);
error = (*pDbeScreenPriv->SwapBuffers)(client, &nStuff, swapInfo); error = (*pDbeScreenPriv->SwapBuffers)(client, &nStuff_i, swapInfo);
if (error != Success) if (error != Success)
{ {
free(swapInfo); free(swapInfo);
......
...@@ -725,7 +725,7 @@ InitStringFeedbackClassDeviceStruct ( ...@@ -725,7 +725,7 @@ InitStringFeedbackClassDeviceStruct (
for (i=0; i<num_symbols_supported; i++) for (i=0; i<num_symbols_supported; i++)
*(feedc->ctrl.symbols_supported+i) = *symbols++; *(feedc->ctrl.symbols_supported+i) = *symbols++;
for (i=0; i<max_symbols; i++) for (i=0; i<max_symbols; i++)
*(feedc->ctrl.symbols_displayed+i) = (KeySym) NULL; *(feedc->ctrl.symbols_displayed+i) = (KeySym) 0;
feedc->ctrl.id = 0; feedc->ctrl.id = 0;
if ( (feedc->next = dev->stringfeed) ) if ( (feedc->next = dev->stringfeed) )
feedc->ctrl.id = dev->stringfeed->ctrl.id + 1; feedc->ctrl.id = dev->stringfeed->ctrl.id + 1;
......
...@@ -829,8 +829,6 @@ POLYSEGMENT (DrawablePtr pDrawable, ...@@ -829,8 +829,6 @@ POLYSEGMENT (DrawablePtr pDrawable,
ul = coordToInt(pBox->x1 - xoff, pBox->y1 - yoff); ul = coordToInt(pBox->x1 - xoff, pBox->y1 - yoff);
lr = coordToInt(pBox->x2 - xoff - 1, pBox->y2 - yoff - 1); lr = coordToInt(pBox->x2 - xoff - 1, pBox->y2 - yoff - 1);
bits += bitsStride * yoff + xoff * MUL;
capNotLast = pGC->capStyle == CapNotLast; capNotLast = pGC->capStyle == CapNotLast;
while (nseg--) while (nseg--)
......
...@@ -1447,7 +1447,7 @@ static void nxagentParseOptions(char *name, char *value) ...@@ -1447,7 +1447,7 @@ static void nxagentParseOptions(char *name, char *value)
tolerance_parse = UINT_MAX; tolerance_parse = UINT_MAX;
fprintf(stderr, "nxagentParseOptions: Warning: value [%s] of option [%s] " fprintf(stderr, "nxagentParseOptions: Warning: value [%s] of option [%s] "
"out of range, clamped to [%u].\n", "out of range, clamped to [%lu].\n",
validateString(value), validateString(name), tolerance_parse); validateString(value), validateString(name), tolerance_parse);
} }
...@@ -1456,7 +1456,7 @@ static void nxagentParseOptions(char *name, char *value) ...@@ -1456,7 +1456,7 @@ static void nxagentParseOptions(char *name, char *value)
tolerance_parse = 0; tolerance_parse = 0;
fprintf(stderr, "nxagentParseOptions: Warning: value [%s] of option [%s] " fprintf(stderr, "nxagentParseOptions: Warning: value [%s] of option [%s] "
"out of range, clamped to [%u].\n", "out of range, clamped to [%lu].\n",
validateString(value), validateString(name), tolerance_parse); validateString(value), validateString(name), tolerance_parse);
} }
......
...@@ -311,7 +311,7 @@ void nxagentSetInstalledColormapWindows(ScreenPtr pScreen) ...@@ -311,7 +311,7 @@ void nxagentSetInstalledColormapWindows(ScreenPtr pScreen)
{ {
fprintf(stderr, "nxagentSetInstalledColormapWindows: WARNING! " fprintf(stderr, "nxagentSetInstalledColormapWindows: WARNING! "
"Window at [%p] has no colormap with class [%d].\n", "Window at [%p] has no colormap with class [%d].\n",
pWin, pWin -> drawable.class); (void *)pWin, pWin -> drawable.class);
} }
#endif #endif
} }
......
...@@ -2468,7 +2468,6 @@ static int nxagentCheckForPixmapFormatsCompatibility() ...@@ -2468,7 +2468,6 @@ static int nxagentCheckForPixmapFormatsCompatibility()
*/ */
bool compatible = true; bool compatible = true;
bool one_match = false;
bool matched = false; bool matched = false;
int total_matches = 0; int total_matches = 0;
...@@ -2483,7 +2482,6 @@ static int nxagentCheckForPixmapFormatsCompatibility() ...@@ -2483,7 +2482,6 @@ static int nxagentCheckForPixmapFormatsCompatibility()
nxagentPixmapFormats[i].scanline_pad == nxagentRemotePixmapFormats[j].scanline_pad) nxagentPixmapFormats[i].scanline_pad == nxagentRemotePixmapFormats[j].scanline_pad)
{ {
matched = true; matched = true;
one_match = true;
++total_matches; ++total_matches;
break; break;
......
...@@ -1953,7 +1953,7 @@ Bool nxagentUnrealizeWindow(pWin) ...@@ -1953,7 +1953,7 @@ Bool nxagentUnrealizeWindow(pWin)
void nxagentFrameBufferPaintWindow(WindowPtr pWin, RegionPtr pRegion, int what) void nxagentFrameBufferPaintWindow(WindowPtr pWin, RegionPtr pRegion, int what)
{ {
void *PaintWindowBackgroundBackup; void (*PaintWindowBackgroundBackup)(WindowPtr, RegionPtr, int);
if (pWin->backgroundState == BackgroundPixmap) if (pWin->backgroundState == BackgroundPixmap)
{ {
......
...@@ -753,13 +753,11 @@ ProcXFixesSetPictureClipRegion (ClientPtr client) ...@@ -753,13 +753,11 @@ ProcXFixesSetPictureClipRegion (ClientPtr client)
#ifdef RENDER #ifdef RENDER
PicturePtr pPicture; PicturePtr pPicture;
RegionPtr pRegion; RegionPtr pRegion;
ScreenPtr pScreen;
REQUEST(xXFixesSetPictureClipRegionReq); REQUEST(xXFixesSetPictureClipRegionReq);
REQUEST_SIZE_MATCH (xXFixesSetPictureClipRegionReq); REQUEST_SIZE_MATCH (xXFixesSetPictureClipRegionReq);
VERIFY_PICTURE(pPicture, stuff->picture, client, SecurityWriteAccess, VERIFY_PICTURE(pPicture, stuff->picture, client, SecurityWriteAccess,
RenderErrBase + BadPicture); RenderErrBase + BadPicture);
pScreen = pPicture->pDrawable->pScreen;
VERIFY_REGION_OR_NONE(pRegion, stuff->region, client, SecurityReadAccess); VERIFY_REGION_OR_NONE(pRegion, stuff->region, client, SecurityReadAccess);
return SetPictureClipRegion (pPicture, stuff->xOrigin, stuff->yOrigin, return SetPictureClipRegion (pPicture, stuff->xOrigin, stuff->yOrigin,
......
...@@ -4402,7 +4402,7 @@ char * wire, *next; ...@@ -4402,7 +4402,7 @@ char * wire, *next;
CARD16 len; CARD16 len;
wire= *wire_inout; wire= *wire_inout;
len= (CARD16 *)wire; len = *(CARD16 *) wire;
if (client->swapped) { if (client->swapped) {
swaps(&len); swaps(&len);
} }
......
...@@ -1085,7 +1085,8 @@ unsigned i,size_toc; ...@@ -1085,7 +1085,8 @@ unsigned i,size_toc;
} }
return 0; return 0;
} }
fread(file_info,SIZEOF(xkmFileInfo),1,file); _X_UNUSED int ignored_result;
ignored_result = fread(file_info,SIZEOF(xkmFileInfo),1,file);
size_toc= file_info->num_toc; size_toc= file_info->num_toc;
if (size_toc>max_toc) { if (size_toc>max_toc) {
#ifdef DEBUG #ifdef DEBUG
...@@ -1095,7 +1096,7 @@ unsigned i,size_toc; ...@@ -1095,7 +1096,7 @@ unsigned i,size_toc;
size_toc= max_toc; size_toc= max_toc;
} }
for (i=0;i<size_toc;i++) { for (i=0;i<size_toc;i++) {
fread(&toc[i],SIZEOF(xkmSectionInfo),1,file); ignored_result = fread(&toc[i],SIZEOF(xkmSectionInfo),1,file);
} }
return 1; return 1;
} }
...@@ -1126,7 +1127,8 @@ int nRead; ...@@ -1126,7 +1127,8 @@ int nRead;
return 0; return 0;
} }
fseek(file,toc->offset,SEEK_SET); fseek(file,toc->offset,SEEK_SET);
fread(&tmpTOC,SIZEOF(xkmSectionInfo),1,file); _X_UNUSED int ignored_result;
ignored_result = fread(&tmpTOC,SIZEOF(xkmSectionInfo),1,file);
nRead= SIZEOF(xkmSectionInfo); nRead= SIZEOF(xkmSectionInfo);
if ((tmpTOC.type!=toc->type)||(tmpTOC.format!=toc->format)|| if ((tmpTOC.type!=toc->type)||(tmpTOC.format!=toc->format)||
(tmpTOC.size!=toc->size)||(tmpTOC.offset!=toc->offset)) { (tmpTOC.size!=toc->size)||(tmpTOC.offset!=toc->offset)) {
...@@ -1201,7 +1203,8 @@ char name[100]; ...@@ -1201,7 +1203,8 @@ char name[100];
case XkmSymbolsIndex: case XkmSymbolsIndex:
case XkmGeometryIndex: case XkmGeometryIndex:
fseek(file,toc->offset,SEEK_SET); fseek(file,toc->offset,SEEK_SET);
fread(&tmpTOC,SIZEOF(xkmSectionInfo),1,file); _X_UNUSED int ignored_result;
ignored_result = fread(&tmpTOC,SIZEOF(xkmSectionInfo),1,file);
if ((tmpTOC.type!=toc->type)||(tmpTOC.format!=toc->format)|| if ((tmpTOC.type!=toc->type)||(tmpTOC.format!=toc->format)||
(tmpTOC.size!=toc->size)||(tmpTOC.offset!=toc->offset)) { (tmpTOC.size!=toc->size)||(tmpTOC.offset!=toc->offset)) {
_XkbLibError(_XkbErrIllegalContents,"XkmReadFileSectionName",0); _XkbLibError(_XkbErrIllegalContents,"XkmReadFileSectionName",0);
......
...@@ -10201,7 +10201,7 @@ int SetCore() ...@@ -10201,7 +10201,7 @@ int SetCore()
if (getrlimit(RLIMIT_CORE, &rlim)) if (getrlimit(RLIMIT_CORE, &rlim))
{ {
#ifdef TEST #ifdef TEST
*logofs << "Cannot read RLIMIT_CORE. Error is '" *logofs << "Loop: Cannot read RLIMIT_CORE. Error is '"
<< ESTR() << "'.\n" << logofs_flush; << ESTR() << "'.\n" << logofs_flush;
#endif #endif
...@@ -10215,7 +10215,7 @@ int SetCore() ...@@ -10215,7 +10215,7 @@ int SetCore()
if (setrlimit(RLIMIT_CORE, &rlim)) if (setrlimit(RLIMIT_CORE, &rlim))
{ {
#ifdef TEST #ifdef TEST
*logofs << "Loop: Cannot read RLIMIT_CORE. Error is '" *logofs << "Loop: Cannot set RLIMIT_CORE. Error is '"
<< ESTR() << "'.\n" << logofs_flush; << ESTR() << "'.\n" << logofs_flush;
#endif #endif
...@@ -10224,7 +10224,7 @@ int SetCore() ...@@ -10224,7 +10224,7 @@ int SetCore()
} }
#ifdef TEST #ifdef TEST
*logofs << "Loop: Set RLIMIT_CORE to "<< rlim.rlim_max *logofs << "Loop: RLIMIT_CORE is "<< rlim.rlim_max
<< ".\n" << logofs_flush; << ".\n" << logofs_flush;
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment