Skip to content

N
nx-libs
Commit 73a2898a authored by Jeremy Huddleston's avatar Jeremy Huddleston Committed by Ulrich Sibiller
Browse files
Options

Fix potential uninitialized variable access in _XimMakeICAttrIDList

Found by clang static analysis Signed-off-by: 's avatarJeremy Huddleston <jeremyhu@apple.com> Backported-to-NX-by: 's avatarUlrich Sibiller <uli42@gmx.de>
parent bec22fe9
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 2 deletions
nx-X11/lib/X11/imRmAttr.c
View file @ 73a2898a
......@@ -177,6 +177,8 @@ _XimMakeICAttrIDList(
else *len += new_len;
return name;
}
*len += new_len;
buf = (CARD16 *)((char *)buf + new_len);
} else if (res->xrm_name == sts_quark) {
if ((name = _XimMakeICAttrIDList(ic, res_list, res_num,
(XIMArg *)p->value, buf, &new_len,
......@@ -185,9 +187,10 @@ _XimMakeICAttrIDList(
else *len += new_len;
return name;
}
*len += new_len;
buf = (CARD16 *)((char *)buf + new_len);
}
*len += new_len;
buf = (CARD16 *)((char *)buf + new_len);
if (!(res = _XimGetNestedListSeparator(res_list, res_num))) {
p++;
if (p) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment