XKB: XkbComputeSectionBounds: Check correct bounds in default switch-case

XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a null pointer (loaded from variable 'rbounds') _XkbCheckBounds(bounds,rbounds->x1,rbounds->y1); ^~~~~~~ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

XKB: XkbComputeSectionBounds: Check correct bounds in default switch-case
7efa7da5 · Jeremy Huddleston · Ulrich Sibiller · 1d806a55 · 7efa7da5
Commit 7efa7da5 authored May 04, 2011 by Jeremy Huddleston Committed by Ulrich Sibiller Oct 19, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

XKBGeom.c nx-X11/lib/X11/XKBGeom.c +2 -1

No files found.
--- a/nx-X11/lib/X11/XKBGeom.c
+++ b/nx-X11/lib/X11/XKBGeom.c
@@ -146,7 +146,7 @@ register int	i;
 XkbShapePtr	shape;
 XkbRowPtr	row;
 XkbDoodadPtr	doodad;
-XkbBoundsPtr	bounds,rbounds=NULL;
+XkbBoundsPtr	bounds,rbounds;

    if ((!geom)||(!section))
 	return False;
@@ -185,6 +185,7 @@ XkbBoundsPtr	bounds,rbounds=NULL;
 	    default:
 		tbounds.x1= tbounds.x2= doodad->any.left;
 		tbounds.y1= tbounds.y2= doodad->any.top;
+		rbounds= &tbounds;
 		break;
 	}
 	_XkbCheckBounds(bounds,rbounds->x1,rbounds->y1);