misc: fix more regressions and whitespace weirdness introduced in…

misc: fix more regressions and whitespace weirdness introduced in 913fcf1a.
parent 15f69488
...@@ -129,8 +129,10 @@ int main (int argc, char *argv[]) ...@@ -129,8 +129,10 @@ int main (int argc, char *argv[])
strcpy(fname,directory); strcat(fname,filename); strcpy(fname,directory); strcat(fname,filename);
f = fopen(fname,"w"); f = fopen(fname,"w");
if (f == NULL) if (f == NULL)
{
free(fname); free(fname);
exit(1); exit(1);
}
} }
fprintf(f, "\n"); fprintf(f, "\n");
......
...@@ -980,17 +980,17 @@ TRANS(GetMyAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp, ...@@ -980,17 +980,17 @@ TRANS(GetMyAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp,
{ {
prmsg (1,"GetMyAddr: malloc failed\n"); prmsg (1,"GetMyAddr: malloc failed\n");
return -1; return -1;
} else {
memcpy(*addrp, ciptr->addr, ciptr->addrlen);
free(addrp);
} }
memcpy(*addrp, ciptr->addr, ciptr->addrlen);
return 0; return 0;
} }
#endif #endif
int int
TRANS(GetPeerAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp, TRANS(GetPeerAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp,
Xtransaddr **addrp) Xtransaddr **addrp)
{ {
prmsg (2,"GetPeerAddr(%d)\n", ciptr->fd); prmsg (2,"GetPeerAddr(%d)\n", ciptr->fd);
...@@ -1003,7 +1003,9 @@ TRANS(GetPeerAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp, ...@@ -1003,7 +1003,9 @@ TRANS(GetPeerAddr) (XtransConnInfo ciptr, int *familyp, int *addrlenp,
prmsg (1,"GetPeerAddr: malloc failed\n"); prmsg (1,"GetPeerAddr: malloc failed\n");
return -1; return -1;
} }
memcpy(*addrp, ciptr->peeraddr, ciptr->peeraddrlen); memcpy(*addrp, ciptr->peeraddr, ciptr->peeraddrlen);
return 0; return 0;
} }
......
...@@ -2442,7 +2442,7 @@ SocketUNIXConnectPost: ...@@ -2442,7 +2442,7 @@ SocketUNIXConnectPost:
(ciptr->peeraddr = malloc(namelen)) == NULL) (ciptr->peeraddr = malloc(namelen)) == NULL)
{ {
prmsg (1, prmsg (1,
"SocketUNIXCreateListener: Can't allocate space for the addr\n"); "SocketUNIXCreateListener: Can't allocate space for the addr\n");
return TRANS_CONNECT_FAILED; return TRANS_CONNECT_FAILED;
} }
...@@ -2454,6 +2454,7 @@ SocketUNIXConnectPost: ...@@ -2454,6 +2454,7 @@ SocketUNIXConnectPost:
ciptr->peeraddrlen = namelen; ciptr->peeraddrlen = namelen;
memcpy (ciptr->addr, &sockname, ciptr->addrlen); memcpy (ciptr->addr, &sockname, ciptr->addrlen);
memcpy (ciptr->peeraddr, &sockname, ciptr->peeraddrlen); memcpy (ciptr->peeraddr, &sockname, ciptr->peeraddrlen);
return 0; return 0;
} }
......
...@@ -655,9 +655,10 @@ AddExtensionClient(WindowPtr pWin, ClientPtr client, Mask mask, int mskidx) ...@@ -655,9 +655,10 @@ AddExtensionClient(WindowPtr pWin, ClientPtr client, Mask mask, int mskidx)
others = (InputClients *) malloc(sizeof(InputClients)); others = (InputClients *) malloc(sizeof(InputClients));
if (!others) if (!others)
return BadAlloc; return BadAlloc;
if (!pWin->optional->inputMasks && !MakeInputMasks(pWin)) if (!pWin->optional->inputMasks && !MakeInputMasks(pWin)) {
free(others); free(others);
return BadAlloc; return BadAlloc;
}
bzero((char *)&others->mask[0], sizeof(Mask) * EMASKSIZE); bzero((char *)&others->mask[0], sizeof(Mask) * EMASKSIZE);
others->mask[mskidx] = mask; others->mask[mskidx] = mask;
others->resource = FakeClientID(client->index); others->resource = FakeClientID(client->index);
......
...@@ -628,14 +628,17 @@ int what; ...@@ -628,14 +628,17 @@ int what;
return; return;
screenContext[i] = CreateGC((DrawablePtr)pWin, (BITS32) 0, screenContext[i] = CreateGC((DrawablePtr)pWin, (BITS32) 0,
(XID *)NULL, &status); (XID *)NULL, &status);
if (!screenContext[i]) if (!screenContext[i]) {
free(prect); free(prect);
return; return;
}
numGCs++; numGCs++;
if (!AddResource(FakeClientID(0), ResType, if (!AddResource(FakeClientID(0), ResType,
(void *)screenContext[i])) (void *)screenContext[i]))
{
free(prect); free(prect);
return; return;
}
} }
pGC = screenContext[i]; pGC = screenContext[i];
newValues[SUBWINDOW].val = IncludeInferiors; newValues[SUBWINDOW].val = IncludeInferiors;
......
...@@ -995,8 +995,10 @@ ProcRenderCompositeGlyphs (ClientPtr client) ...@@ -995,8 +995,10 @@ ProcRenderCompositeGlyphs (ClientPtr client)
{ {
listsBase = (GlyphListPtr) malloc (nlist * sizeof (GlyphListRec)); listsBase = (GlyphListPtr) malloc (nlist * sizeof (GlyphListRec));
if (!listsBase) if (!listsBase)
{
free(glyphsBase); free(glyphsBase);
return BadAlloc; return BadAlloc;
}
} }
elementsBase = malloc(nlist * sizeof(XGlyphElt8)); elementsBase = malloc(nlist * sizeof(XGlyphElt8));
......
...@@ -330,6 +330,7 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -330,6 +330,7 @@ char *PngCompressData(XImage *image, int *compressed_size)
png_destroy_write_struct(&png_ptr, NULL); png_destroy_write_struct(&png_ptr, NULL);
free(image_index); free(image_index);
return NULL; return NULL;
} }
...@@ -340,8 +341,8 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -340,8 +341,8 @@ char *PngCompressData(XImage *image, int *compressed_size)
#endif #endif
png_destroy_write_struct(&png_ptr, &info_ptr); png_destroy_write_struct(&png_ptr, &info_ptr);
free(image_index); free(image_index);
return NULL; return NULL;
} }
...@@ -364,6 +365,7 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -364,6 +365,7 @@ char *PngCompressData(XImage *image, int *compressed_size)
#endif #endif
free(image_index); free(image_index);
return NULL; return NULL;
} }
...@@ -376,8 +378,8 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -376,8 +378,8 @@ char *PngCompressData(XImage *image, int *compressed_size)
#endif #endif
png_destroy_write_struct(&png_ptr, &info_ptr); png_destroy_write_struct(&png_ptr, &info_ptr);
free(pngCompBuf); free(pngCompBuf);
return NULL; return NULL;
} }
...@@ -474,6 +476,7 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -474,6 +476,7 @@ char *PngCompressData(XImage *image, int *compressed_size)
free(pngCompBuf); free(pngCompBuf);
free(image_index); free(image_index);
return NULL; return NULL;
} }
...@@ -487,7 +490,9 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -487,7 +490,9 @@ char *PngCompressData(XImage *image, int *compressed_size)
fprintf(stderr, "******PngCompressData: PANIC! Cannot allocate [%d] bytes.\n", fprintf(stderr, "******PngCompressData: PANIC! Cannot allocate [%d] bytes.\n",
(int) (w * sizeof(CARD8))); (int) (w * sizeof(CARD8)));
#endif #endif
free(image_index); free(image_index);
return NULL; return NULL;
} }
...@@ -520,6 +525,7 @@ char *PngCompressData(XImage *image, int *compressed_size) ...@@ -520,6 +525,7 @@ char *PngCompressData(XImage *image, int *compressed_size)
free(pngCompBuf); free(pngCompBuf);
free(image_index); free(image_index);
return NULL; return NULL;
} }
......
...@@ -766,13 +766,17 @@ int what; ...@@ -766,13 +766,17 @@ int what;
screenContext[i] = CreateGC((DrawablePtr)pWin, (BITS32) 0, screenContext[i] = CreateGC((DrawablePtr)pWin, (BITS32) 0,
(XID *)NULL, &status); (XID *)NULL, &status);
if (!screenContext[i]) if (!screenContext[i])
{
free(prect); free(prect);
return; return;
}
numGCs++; numGCs++;
if (!AddResource(FakeClientID(0), ResType, if (!AddResource(FakeClientID(0), ResType,
(void *)screenContext[i])) (void *)screenContext[i]))
{
free(prect); free(prect);
return; return;
}
} }
pGC = screenContext[i]; pGC = screenContext[i];
newValues[SUBWINDOW].val = IncludeInferiors; newValues[SUBWINDOW].val = IncludeInferiors;
......
...@@ -158,9 +158,12 @@ miZeroLine(pDraw, pGC, mode, npt, pptInit) ...@@ -158,9 +158,12 @@ miZeroLine(pDraw, pGC, mode, npt, pptInit)
pspanInit = (DDXPointPtr)malloc(list_len * sizeof(DDXPointRec)); pspanInit = (DDXPointPtr)malloc(list_len * sizeof(DDXPointRec));
pwidthInit = (int *)malloc(list_len * sizeof(int)); pwidthInit = (int *)malloc(list_len * sizeof(int));
if (!pspanInit || !pwidthInit) if (!pspanInit || !pwidthInit)
{
free(pspanInit); free(pspanInit);
free(pwidthInit); free(pwidthInit);
return; return;
}
Nspans = 0; Nspans = 0;
new_span = TRUE; new_span = TRUE;
......
...@@ -1346,9 +1346,12 @@ ProcRenderCompositeGlyphs (ClientPtr client) ...@@ -1346,9 +1346,12 @@ ProcRenderCompositeGlyphs (ClientPtr client)
{ {
listsBase = (GlyphListPtr) malloc (nlist * sizeof (GlyphListRec)); listsBase = (GlyphListPtr) malloc (nlist * sizeof (GlyphListRec));
if (!listsBase) if (!listsBase)
{
free(glyphsBase); free(glyphsBase);
free(listsBase); free(listsBase);
return BadAlloc; return BadAlloc;
}
} }
buffer = (CARD8 *) (stuff + 1); buffer = (CARD8 *) (stuff + 1);
glyphs = glyphsBase; glyphs = glyphsBase;
...@@ -2920,6 +2923,8 @@ PanoramiXRenderFillRectangles (ClientPtr client) ...@@ -2920,6 +2923,8 @@ PanoramiXRenderFillRectangles (ClientPtr client)
result = (*PanoramiXSaveRenderVector[X_RenderFillRectangles]) (client); result = (*PanoramiXSaveRenderVector[X_RenderFillRectangles]) (client);
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
return result; return result;
} }
...@@ -2979,9 +2984,10 @@ PanoramiXRenderTrapezoids(ClientPtr client) ...@@ -2979,9 +2984,10 @@ PanoramiXRenderTrapezoids(ClientPtr client)
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
free(extra);
return result; return result;
} }
...@@ -3036,9 +3042,10 @@ PanoramiXRenderTriangles(ClientPtr client) ...@@ -3036,9 +3042,10 @@ PanoramiXRenderTriangles(ClientPtr client)
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
free(extra);
return result; return result;
} }
...@@ -3089,9 +3096,10 @@ PanoramiXRenderTriStrip(ClientPtr client) ...@@ -3089,9 +3096,10 @@ PanoramiXRenderTriStrip(ClientPtr client)
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
free(extra);
return result; return result;
} }
...@@ -3142,9 +3150,10 @@ PanoramiXRenderTriFan(ClientPtr client) ...@@ -3142,9 +3150,10 @@ PanoramiXRenderTriFan(ClientPtr client)
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
free(extra);
return result; return result;
} }
...@@ -3272,8 +3281,10 @@ PanoramiXRenderAddTraps (ClientPtr client) ...@@ -3272,8 +3281,10 @@ PanoramiXRenderAddTraps (ClientPtr client)
result = (*PanoramiXSaveRenderVector[X_RenderAddTraps]) (client); result = (*PanoramiXSaveRenderVector[X_RenderAddTraps]) (client);
if(result != Success) break; if(result != Success) break;
} }
free(extra);
} }
free(extra);
return result; return result;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment