Commit 9c3842a4 authored by Alan Coopersmith's avatar Alan Coopersmith Committed by Mike Gabriel

render: unvalidated lengths in Render extn. swapped procs [CVE-2014-8100 2/2]

v2: backport to nx-libs 3.6.x (Mike DePaulo) Signed-off-by: 's avatarAlan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: 's avatarPeter Hutterer <peter.hutterer@who-t.net> Conflicts: render/render.c
parent 6c820648
...@@ -2014,6 +2014,7 @@ SProcRenderQueryVersion (ClientPtr client) ...@@ -2014,6 +2014,7 @@ SProcRenderQueryVersion (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderQueryVersionReq); REQUEST(xRenderQueryVersionReq);
REQUEST_SIZE_MATCH(xRenderQueryVersionReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->majorVersion, n); swapl(&stuff->majorVersion, n);
...@@ -2026,6 +2027,7 @@ SProcRenderQueryPictFormats (ClientPtr client) ...@@ -2026,6 +2027,7 @@ SProcRenderQueryPictFormats (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderQueryPictFormatsReq); REQUEST(xRenderQueryPictFormatsReq);
REQUEST_SIZE_MATCH(xRenderQueryPictFormatsReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
return (*ProcRenderVector[stuff->renderReqType]) (client); return (*ProcRenderVector[stuff->renderReqType]) (client);
} }
...@@ -2035,6 +2037,7 @@ SProcRenderQueryPictIndexValues (ClientPtr client) ...@@ -2035,6 +2037,7 @@ SProcRenderQueryPictIndexValues (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderQueryPictIndexValuesReq); REQUEST(xRenderQueryPictIndexValuesReq);
REQUEST_AT_LEAST_SIZE(xRenderQueryPictIndexValuesReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->format, n); swapl(&stuff->format, n);
return (*ProcRenderVector[stuff->renderReqType]) (client); return (*ProcRenderVector[stuff->renderReqType]) (client);
...@@ -2051,6 +2054,7 @@ SProcRenderCreatePicture (ClientPtr client) ...@@ -2051,6 +2054,7 @@ SProcRenderCreatePicture (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderCreatePictureReq); REQUEST(xRenderCreatePictureReq);
REQUEST_AT_LEAST_SIZE(xRenderCreatePictureReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->pid, n); swapl(&stuff->pid, n);
swapl(&stuff->drawable, n); swapl(&stuff->drawable, n);
...@@ -2065,6 +2069,7 @@ SProcRenderChangePicture (ClientPtr client) ...@@ -2065,6 +2069,7 @@ SProcRenderChangePicture (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderChangePictureReq); REQUEST(xRenderChangePictureReq);
REQUEST_AT_LEAST_SIZE(xRenderChangePictureReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->picture, n); swapl(&stuff->picture, n);
swapl(&stuff->mask, n); swapl(&stuff->mask, n);
...@@ -2077,6 +2082,7 @@ SProcRenderSetPictureClipRectangles (ClientPtr client) ...@@ -2077,6 +2082,7 @@ SProcRenderSetPictureClipRectangles (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderSetPictureClipRectanglesReq); REQUEST(xRenderSetPictureClipRectanglesReq);
REQUEST_AT_LEAST_SIZE(xRenderSetPictureClipRectanglesReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->picture, n); swapl(&stuff->picture, n);
SwapRestS(stuff); SwapRestS(stuff);
...@@ -2088,6 +2094,7 @@ SProcRenderFreePicture (ClientPtr client) ...@@ -2088,6 +2094,7 @@ SProcRenderFreePicture (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderFreePictureReq); REQUEST(xRenderFreePictureReq);
REQUEST_SIZE_MATCH(xRenderFreePictureReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->picture, n); swapl(&stuff->picture, n);
return (*ProcRenderVector[stuff->renderReqType]) (client); return (*ProcRenderVector[stuff->renderReqType]) (client);
...@@ -2098,6 +2105,7 @@ SProcRenderComposite (ClientPtr client) ...@@ -2098,6 +2105,7 @@ SProcRenderComposite (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderCompositeReq); REQUEST(xRenderCompositeReq);
REQUEST_SIZE_MATCH(xRenderCompositeReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->src, n); swapl(&stuff->src, n);
swapl(&stuff->mask, n); swapl(&stuff->mask, n);
...@@ -2118,6 +2126,7 @@ SProcRenderScale (ClientPtr client) ...@@ -2118,6 +2126,7 @@ SProcRenderScale (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderScaleReq); REQUEST(xRenderScaleReq);
REQUEST_SIZE_MATCH(xRenderScaleReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->src, n); swapl(&stuff->src, n);
swapl(&stuff->dst, n); swapl(&stuff->dst, n);
...@@ -2223,6 +2232,7 @@ SProcRenderCreateGlyphSet (ClientPtr client) ...@@ -2223,6 +2232,7 @@ SProcRenderCreateGlyphSet (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderCreateGlyphSetReq); REQUEST(xRenderCreateGlyphSetReq);
REQUEST_SIZE_MATCH(xRenderCreateGlyphSetReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->gsid, n); swapl(&stuff->gsid, n);
swapl(&stuff->format, n); swapl(&stuff->format, n);
...@@ -2234,6 +2244,7 @@ SProcRenderReferenceGlyphSet (ClientPtr client) ...@@ -2234,6 +2244,7 @@ SProcRenderReferenceGlyphSet (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderReferenceGlyphSetReq); REQUEST(xRenderReferenceGlyphSetReq);
REQUEST_SIZE_MATCH(xRenderReferenceGlyphSetReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->gsid, n); swapl(&stuff->gsid, n);
swapl(&stuff->existing, n); swapl(&stuff->existing, n);
...@@ -2245,6 +2256,7 @@ SProcRenderFreeGlyphSet (ClientPtr client) ...@@ -2245,6 +2256,7 @@ SProcRenderFreeGlyphSet (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderFreeGlyphSetReq); REQUEST(xRenderFreeGlyphSetReq);
REQUEST_SIZE_MATCH(xRenderFreeGlyphSetReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->glyphset, n); swapl(&stuff->glyphset, n);
return (*ProcRenderVector[stuff->renderReqType]) (client); return (*ProcRenderVector[stuff->renderReqType]) (client);
...@@ -2259,6 +2271,7 @@ SProcRenderAddGlyphs (ClientPtr client) ...@@ -2259,6 +2271,7 @@ SProcRenderAddGlyphs (ClientPtr client)
void *end; void *end;
xGlyphInfo *gi; xGlyphInfo *gi;
REQUEST(xRenderAddGlyphsReq); REQUEST(xRenderAddGlyphsReq);
REQUEST_AT_LEAST_SIZE(xRenderAddGlyphsReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->glyphset, n); swapl(&stuff->glyphset, n);
swapl(&stuff->nglyphs, n); swapl(&stuff->nglyphs, n);
...@@ -2295,6 +2308,7 @@ SProcRenderFreeGlyphs (ClientPtr client) ...@@ -2295,6 +2308,7 @@ SProcRenderFreeGlyphs (ClientPtr client)
{ {
register int n; register int n;
REQUEST(xRenderFreeGlyphsReq); REQUEST(xRenderFreeGlyphsReq);
REQUEST_AT_LEAST_SIZE(xRenderFreeGlyphsReq);
swaps(&stuff->length, n); swaps(&stuff->length, n);
swapl(&stuff->glyphset, n); swapl(&stuff->glyphset, n);
SwapRestL(stuff); SwapRestL(stuff);
...@@ -2313,7 +2327,8 @@ SProcRenderCompositeGlyphs (ClientPtr client) ...@@ -2313,7 +2327,8 @@ SProcRenderCompositeGlyphs (ClientPtr client)
int size; int size;
REQUEST(xRenderCompositeGlyphsReq); REQUEST(xRenderCompositeGlyphsReq);
REQUEST_AT_LEAST_SIZE(xRenderCompositeGlyphsReq);
switch (stuff->renderReqType) { switch (stuff->renderReqType) {
default: size = 1; break; default: size = 1; break;
case X_RenderCompositeGlyphs16: size = 2; break; case X_RenderCompositeGlyphs16: size = 2; break;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment