fb: fix memory leak in fbOverlayFinishScreenInit

commit 2aa935bc5cc1e2d5365a97b8c5bb3d33eb5fc758 Author: Tiago Vignatti <tiago.vignatti@nokia.com> Date: Fri Mar 25 22:10:55 2011 +0200 fb: fix memory leak in fbOverlayFinishScreenInit Signed-off-by: Tiago Vignatti <tiago.vignatti@nokia.com> Reviewed-by: Nicolas Peninguy <nico@lostgeeks.org> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

fb: fix memory leak in fbOverlayFinishScreenInit
9f9b790f · Ulrich Sibiller · Mike Gabriel · f5540257 · 9f9b790f
Commit 9f9b790f authored Jun 20, 2019 by Ulrich Sibiller Committed by Mike Gabriel Jun 22, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

fboverlay.c nx-X11/programs/Xserver/fb/fboverlay.c +6 -2

No files found.
--- a/nx-X11/programs/Xserver/fb/fboverlay.c
+++ b/nx-X11/programs/Xserver/fb/fboverlay.c
@@ -410,16 +410,20 @@ fbOverlayFinishScreenInit(ScreenPtr	pScreen,
   
    if (!fbInitVisuals (&visuals, &depths, &nvisuals, &ndepths, &depth1,
 			&defaultVisual, ((unsigned long)1<<(bpp1-1)) |
-			((unsigned long)1<<(bpp2-1)), 8))
+			((unsigned long)1<<(bpp2-1)), 8)) {
+	free(pScrPriv);
 	return FALSE;
+    }
    if (! miScreenInit(pScreen, 0, xsize, ysize, dpix, dpiy, 0,
 			depth1, ndepths, depths,
 			defaultVisual, nvisuals, visuals
 #ifdef FB_OLD_MISCREENINIT
 		       , (miBSFuncPtr) 0
 #endif
-		       ))
+		       )) {
+	free(pScrPriv);
 	return FALSE;
+    }
    /* MI thinks there's no frame buffer */
 #ifdef MITSHM
    ShmRegisterFbFuncs(pScreen);