Commit a765857a authored by Ulrich Sibiller's avatar Ulrich Sibiller

Remove the Must_have_memory hack.

We are not using any alloc function that respects that variable, so lets drop it. Backport of this commit: commit 0ce61e21d6d7dcca0090e319bbcdb678570f2c3f Author: Adam Jackson <ajax@redhat.com> Date: Fri Oct 3 16:05:19 2008 -0400 Remove the Must_have_memory hack. Also remove an astonishing amount of misunderstanding of how casts work.
parent c0754a35
...@@ -153,11 +153,9 @@ ProcXChangeKeyboardDevice(register ClientPtr client) ...@@ -153,11 +153,9 @@ ProcXChangeKeyboardDevice(register ClientPtr client)
df->time = xf->time; df->time = xf->time;
df->traceGood = xf->traceGood; df->traceGood = xf->traceGood;
if (df->traceSize != xf->traceSize) { if (df->traceSize != xf->traceSize) {
Must_have_memory = TRUE; /* XXX */
df->trace = (WindowPtr *) realloc(df->trace, df->trace = (WindowPtr *) realloc(df->trace,
xf->traceSize * xf->traceSize *
sizeof(WindowPtr)); sizeof(WindowPtr));
Must_have_memory = FALSE; /* XXX */
} }
df->traceSize = xf->traceSize; df->traceSize = xf->traceSize;
for (i = 0; i < df->traceSize; i++) for (i = 0; i < df->traceSize; i++)
......
...@@ -1938,10 +1938,8 @@ XYToWindow(int x, int y) ...@@ -1938,10 +1938,8 @@ XYToWindow(int x, int y)
if (spriteTraceGood >= spriteTraceSize) if (spriteTraceGood >= spriteTraceSize)
{ {
spriteTraceSize += 10; spriteTraceSize += 10;
Must_have_memory = TRUE; /* XXX */ spriteTrace = realloc(
spriteTrace = (WindowPtr *)realloc(
spriteTrace, spriteTraceSize*sizeof(WindowPtr)); spriteTrace, spriteTraceSize*sizeof(WindowPtr));
Must_have_memory = FALSE; /* XXX */
} }
spriteTrace[spriteTraceGood++] = pWin; spriteTrace[spriteTraceGood++] = pWin;
pWin = pWin->firstChild; pWin = pWin->firstChild;
...@@ -2455,11 +2453,9 @@ CheckPassiveGrabsOnWindow( ...@@ -2455,11 +2453,9 @@ CheckPassiveGrabsOnWindow(
{ {
if (device->sync.evcount < count) if (device->sync.evcount < count)
{ {
Must_have_memory = TRUE; /* XXX */ device->sync.event = realloc(device->sync.event,
device->sync.event = (xEvent *)realloc(device->sync.event, count*
count* sizeof(xEvent));
sizeof(xEvent));
Must_have_memory = FALSE; /* XXX */
} }
device->sync.evcount = count; device->sync.evcount = count;
for (dxE = device->sync.event; --count >= 0; dxE++, xE++) for (dxE = device->sync.event; --count >= 0; dxE++, xE++)
...@@ -2627,10 +2623,8 @@ DeliverGrabbedEvent(register xEvent *xE, register DeviceIntPtr thisDev, ...@@ -2627,10 +2623,8 @@ DeliverGrabbedEvent(register xEvent *xE, register DeviceIntPtr thisDev,
FreezeThaw(thisDev, TRUE); FreezeThaw(thisDev, TRUE);
if (thisDev->sync.evcount < count) if (thisDev->sync.evcount < count)
{ {
Must_have_memory = TRUE; /* XXX */ thisDev->sync.event = realloc(thisDev->sync.event,
thisDev->sync.event = (xEvent *)realloc(thisDev->sync.event, count*sizeof(xEvent));
count*sizeof(xEvent));
Must_have_memory = FALSE; /* XXX */
} }
thisDev->sync.evcount = count; thisDev->sync.evcount = count;
for (dxE = thisDev->sync.event; --count >= 0; dxE++, xE++) for (dxE = thisDev->sync.event; --count >= 0; dxE++, xE++)
...@@ -3505,11 +3499,8 @@ SetInputFocus( ...@@ -3505,11 +3499,8 @@ SetInputFocus(
if (depth > focus->traceSize) if (depth > focus->traceSize)
{ {
focus->traceSize = depth+1; focus->traceSize = depth+1;
Must_have_memory = TRUE; /* XXX */ focus->trace = realloc(focus->trace,
focus->trace = (WindowPtr *)realloc(focus->trace, focus->traceSize * sizeof(WindowPtr));
focus->traceSize *
sizeof(WindowPtr));
Must_have_memory = FALSE; /* XXX */
} }
focus->traceGood = depth; focus->traceGood = depth;
for (pWin = focusWin, depth--; pWin; pWin = pWin->parent, depth--) for (pWin = focusWin, depth--; pWin; pWin = pWin->parent, depth--)
......
...@@ -367,10 +367,8 @@ XYToWindow(int x, int y) ...@@ -367,10 +367,8 @@ XYToWindow(int x, int y)
if (spriteTraceGood >= spriteTraceSize) if (spriteTraceGood >= spriteTraceSize)
{ {
spriteTraceSize += 10; spriteTraceSize += 10;
Must_have_memory = TRUE; /* XXX */ spriteTrace = realloc(
spriteTrace = (WindowPtr *)realloc(
spriteTrace, spriteTraceSize*sizeof(WindowPtr)); spriteTrace, spriteTraceSize*sizeof(WindowPtr));
Must_have_memory = FALSE; /* XXX */
} }
spriteTrace[spriteTraceGood++] = pWin; spriteTrace[spriteTraceGood++] = pWin;
pWin = pWin->firstChild; pWin = pWin->firstChild;
......
...@@ -20,7 +20,6 @@ extern int monitorResolution; ...@@ -20,7 +20,6 @@ extern int monitorResolution;
extern Bool loadableFonts; extern Bool loadableFonts;
extern int defaultColorVisualClass; extern int defaultColorVisualClass;
extern Bool Must_have_memory;
extern int GrabInProgress; extern int GrabInProgress;
extern char *ConnectionInfo; extern char *ConnectionInfo;
extern Bool noTestExtensions; extern Bool noTestExtensions;
......
...@@ -53,8 +53,6 @@ SOFTWARE. ...@@ -53,8 +53,6 @@ SOFTWARE.
#include "misc.h" #include "misc.h"
#include "mi.h" #include "mi.h"
extern Bool Must_have_memory;
void void
miRecolorCursor( pScr, pCurs, displayed) miRecolorCursor( pScr, pCurs, displayed)
ScreenPtr pScr; ScreenPtr pScr;
...@@ -65,11 +63,9 @@ miRecolorCursor( pScr, pCurs, displayed) ...@@ -65,11 +63,9 @@ miRecolorCursor( pScr, pCurs, displayed)
* This is guaranteed to correct any color-dependent state which may have * This is guaranteed to correct any color-dependent state which may have
* been bound up in private state created by RealizeCursor * been bound up in private state created by RealizeCursor
*/ */
(* pScr->UnrealizeCursor)( pScr, pCurs); pScr->UnrealizeCursor(pScr, pCurs);
Must_have_memory = TRUE; /* XXX */ pScr->RealizeCursor(pScr, pCurs);
(* pScr->RealizeCursor)( pScr, pCurs); if (displayed)
Must_have_memory = FALSE; /* XXX */ pScr->DisplayCursor(pScr, pCurs);
if ( displayed)
(* pScr->DisplayCursor)( pScr, pCurs);
} }
...@@ -68,11 +68,9 @@ miCreateGCOps(prototype) ...@@ -68,11 +68,9 @@ miCreateGCOps(prototype)
{ {
GCOpsPtr ret; GCOpsPtr ret;
/* XXX */ Must_have_memory = TRUE; ret = malloc(sizeof(GCOps));
ret = (GCOpsPtr) malloc(sizeof(GCOps));
/* XXX */ Must_have_memory = FALSE;
if (!ret) if (!ret)
return 0; return NULL;
*ret = *prototype; *ret = *prototype;
ret->devPrivate.val = 1; ret->devPrivate.val = 1;
return ret; return ret;
......
...@@ -257,8 +257,6 @@ Bool PanoramiXExtensionDisabledHack = FALSE; ...@@ -257,8 +257,6 @@ Bool PanoramiXExtensionDisabledHack = FALSE;
int auditTrailLevel = 1; int auditTrailLevel = 1;
Bool Must_have_memory = FALSE;
#if defined(SVR4) || defined(__linux__) || defined(CSRG_BASED) #if defined(SVR4) || defined(__linux__) || defined(CSRG_BASED)
#define HAS_SAVED_IDS_AND_SETEUID #define HAS_SAVED_IDS_AND_SETEUID
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment