lc/def/lcDefConv: Use Xcalloc to avoid use of uninitialized memory

Fixed by zero'ing conv on allocation with Xcalloc. Then close_converter works properly. Using uninitialized value "conv->state" in call to function "close_converter" Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

lc/def/lcDefConv: Use Xcalloc to avoid use of uninitialized memory
a8598e06 · Ander Conselvan de Oliveira · Ulrich Sibiller · 93a4f5c4 · a8598e06 · a8598e06
Commit a8598e06 authored Jan 31, 2011 by Ander Conselvan de Oliveira Committed by Ulrich Sibiller Oct 19, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

lcDefConv.c nx-X11/lib/X11/lcDefConv.c +1 -1

lcGenConv.c nx-X11/lib/X11/lcGenConv.c +1 -1

No files found.
--- a/nx-X11/lib/X11/lcDefConv.c
+++ b/nx-X11/lib/X11/lcDefConv.c
@@ -577,7 +577,7 @@ create_conv(
    XlcConv conv;
    State state;
-    conv = (XlcConv) Xmalloc(sizeof(XlcConvRec));
+    conv = (XlcConv) Xcalloc(1, sizeof(XlcConvRec));
    if (conv == NULL)
 	return (XlcConv) NULL;

--- a/nx-X11/lib/X11/lcGenConv.c
+++ b/nx-X11/lib/X11/lcGenConv.c
@@ -2647,7 +2647,7 @@ create_conv(
    XlcConv conv;
    State state;
-    conv = (XlcConv) Xmalloc(sizeof(XlcConvRec));
+    conv = (XlcConv) Xcalloc(1, sizeof(XlcConvRec));
    if (conv == NULL)
 	return (XlcConv) NULL;