Suppress false positives in static analysis

there's more work to do... The whole nx-X11/extras dir is no longer checked since we only have Mesa there and we do not want to check that mess... All the exceptions in static-analysis-suppressions have been manually checked.

Suppress false positives in static analysis
c8a5e33f · Ulrich Sibiller · Mike Gabriel · b91b3d80 · c8a5e33f · c8a5e33f
Commit c8a5e33f authored Jun 20, 2019 by Ulrich Sibiller Committed by Mike Gabriel Jun 22, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 28 additions and 2 deletions

run-static-analysis.sh run-static-analysis.sh +2 -2

static-analysis-suppressions static-analysis-suppressions +26 -0

No files found.
--- a/run-static-analysis.sh
+++ b/run-static-analysis.sh
@@ -6,9 +6,9 @@ if [[ "${STATIC_ANALYSIS}" == "yes" ]]; then
        echo 'Error: cppcheck is not installed.' >&2
        exit 1
    fi
-    CPPCHECK_OPTS='--error-exitcode=0 --force --quiet'
+    CPPCHECK_OPTS='--error-exitcode=0 --force --quiet --suppressions-list=./static-analysis-suppressions'
    # we exclude some external projects
-    CPPCHECK_EXCLUDES='-i ./nx-X11/extras/Mesa* -i ./nx-X11/extras/Mesa_* -i nx-X11/programs/Xserver/GL/mesa*'
+    CPPCHECK_EXCLUDES='-i ./nx-X11/extras/ -i nx-X11/programs/Xserver/GL/mesa* -i ./.pc -i ./nx-X11/.build-exports -i ./nx-X11/exports -i ./doc'
    echo "$(cppcheck --version):";
    cppcheck $CPPCHECK_OPTS $CPPCHECK_EXCLUDES .;
 fi
--- a/static-analysis-suppressions
+++ b/static-analysis-suppressions
+memleak:nx-X11/programs/Xserver/dix/gc.c
+memleak:nx-X11/lib/include/xtrans/Xtrans.c:982
+memleak:nx-X11/lib/include/xtrans/Xtrans.c:987
+memleak:nx-X11/lib/include/xtrans/Xtrans.c:1004
+memleak:nx-X11/lib/include/xtrans/Xtrans.c:1009
+uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1107
+uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1109
+uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1146
+uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1148
+memleak:nx-X11/lib/include/xtrans/Xtranssock.c:2446
+memleak:nx-X11/lib/include/xtrans/Xtranssock.c:2458
+nullPointer:nx-X11/programs/Xserver/Xext/security.c
+nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrcrtc.c
+nullPointerArithmetic:nx-X11/programs/Xserver/randr/rroutput.c
+nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrprovider.c
+nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrscreen.c
+memleak:nx-X11/programs/Xserver/render/render.c:2929
+memleak:nx-X11/programs/Xserver/render/render.c:2991
+memleak:nx-X11/programs/Xserver/render/render.c:3049
+memleak:nx-X11/programs/Xserver/render/render.c:3103
+memleak:nx-X11/programs/Xserver/render/render.c:3157
+memleak:nx-X11/programs/Xserver/render/render.c:3288
+doubleFree:nx-X11/programs/Xserver/hw/nxagent/Keyboard.c:1699
+uninitStructMember:nx-X11/programs/Xserver/mi/miwideline.c:190
+invalidFree:nxcomp/src/EncodeBuffer.cpp:84
+invalidFree:nxcomp/src/EncodeBuffer.cpp:106