Commit da9a1bc0 authored by Mike Gabriel's avatar Mike Gabriel

debian/patches: Add 2004_enforce-lpthread.patch. On Debian, enforce -lpthread…

debian/patches: Add 2004_enforce-lpthread.patch. On Debian, enforce -lpthread when building nxcomp. This is a nasty work around for a missing symbols issue that needs to get addressed otherwise in later release.
parent 400b627e
Description: Enforce -lpthread when linking nxcomp.
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Abstract:
This is a workaround for a nasty libtool bug!!!
.
We actually compile libXcomp with pthread support, but libtool uses g++
... -nostdlib ... -pthread on Linux. -nostdlib causes -pthread to be
ignored.
.
According to GCC upstream, this is not a bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25460
.
GCC upstream insists that libtool needs to handle -pthread in a special
way when using -nostdlib.
.
A patch has been submitted to the libtool project:
http://lists.gnu.org/archive/html/libtool-patches/2013-11/msg00015.html
but never applied to the code base. Boo.
.
We will work around this bug by hard-coding the linking with pthread
support in libXcomp for now.
--- a/nxcomp/src/Makefile.am
+++ b/nxcomp/src/Makefile.am
@@ -139,7 +139,7 @@
libXcomp_la_LDFLAGS = \
-version-number @LT_COMP_VERSION@ \
-no-undefined \
- $(PTHREAD_LDFLAGS) \
+ $(PTHREAD_LDFLAGS) -lpthread \
$(NULL)
libXcompincludedir = $(includedir)/nx
2001_nx-X11_install-location.debian.patch
2002_xserver-xext_set-securitypolicy-path.debian.patch
2003_nxdialog-use-python3.patch
2004_enforce-lpthread.patch
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment