_XkbReadGetMapReply: reject maxKeyCodes smaller than the minKeyCode

Various other bounds checks in the code assume this is true, so enforce it when we first get the data from the X server. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Julien Cristau <jcristau@debian.org> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

_XkbReadGetMapReply: reject maxKeyCodes smaller than the minKeyCode
dc749a45 · Alan Coopersmith · Ulrich Sibiller · 37f8d3eb · dc749a45
Commit dc749a45 authored Mar 31, 2013 by Alan Coopersmith Committed by Ulrich Sibiller Oct 12, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

XKBGetMap.c nx-X11/lib/X11/XKBGetMap.c +2 -0

No files found.
--- a/nx-X11/lib/X11/XKBGetMap.c
+++ b/nx-X11/lib/X11/XKBGetMap.c
@@ -485,6 +485,8 @@ unsigned	mask;

    if ( xkb->device_spec == XkbUseCoreKbd )
 	xkb->device_spec= rep->deviceID;
+    if ( rep->maxKeyCode < rep->minKeyCode )
+	return BadImplementation;
    xkb->min_key_code = rep->minKeyCode;
    xkb->max_key_code = rep->maxKeyCode;