Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nx-libs
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dimbor
nx-libs
Commits
dd0d49c4
Commit
dd0d49c4
authored
Apr 04, 2019
by
Mihai Moldovan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
debian/patches/{,series}: remove 2004_enforce-lpthread.patch.
This workaround/hack should not be needed any longer.
parent
d1fe6a60
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
34 deletions
+0
-34
2004_enforce-lpthread.patch
debian/patches/2004_enforce-lpthread.patch
+0
-33
series
debian/patches/series
+0
-1
No files found.
debian/patches/2004_enforce-lpthread.patch
deleted
100644 → 0
View file @
d1fe6a60
Description: Enforce -lpthread when linking nxcomp.
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Abstract:
This is a workaround for a nasty libtool bug!!!
.
We actually compile libXcomp with pthread support, but libtool uses g++
... -nostdlib ... -pthread on Linux. -nostdlib causes -pthread to be
ignored.
.
According to GCC upstream, this is not a bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25460
.
GCC upstream insists that libtool needs to handle -pthread in a special
way when using -nostdlib.
.
A patch has been submitted to the libtool project:
http://lists.gnu.org/archive/html/libtool-patches/2013-11/msg00015.html
but never applied to the code base. Boo.
.
We will work around this bug by hard-coding the linking with pthread
support in libXcomp for now.
--- a/nxcomp/src/Makefile.am
+++ b/nxcomp/src/Makefile.am
@@ -139,7 +139,7 @@
libXcomp_la_LDFLAGS = \
-version-number @LT_COMP_VERSION@ \
-no-undefined \
- $(PTHREAD_LDFLAGS) \
+ $(PTHREAD_LDFLAGS) -lpthread \
$(NULL)
libXcompincludedir = $(includedir)/nx
debian/patches/series
View file @
dd0d49c4
2001_nx-X11_install-location.debian.patch
2001_nx-X11_install-location.debian.patch
2002_xserver-xext_set-securitypolicy-path.debian.patch
2002_xserver-xext_set-securitypolicy-path.debian.patch
2003_nxdialog-use-python3.patch
2003_nxdialog-use-python3.patch
2004_enforce-lpthread.patch
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment