Fix potential memory leak

If we hit the depth limit, filename leaks. Move the depth check up before we allocate filename. Introduced in 226622349a4b1e16064649d4444a34fb4be4f464. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Fix potential memory leak
e1448998 · Peter Hutterer · Ulrich Sibiller · 8e3e7bb7 · e1448998
Commit e1448998 authored May 18, 2015 by Peter Hutterer Committed by Ulrich Sibiller Oct 19, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

imLcPrs.c nx-X11/lib/X11/imLcPrs.c +2 -2

No files found.
--- a/nx-X11/lib/X11/imLcPrs.c
+++ b/nx-X11/lib/X11/imLcPrs.c
@@ -496,10 +496,10 @@ parseline(
            token = nexttoken(fp, tokenbuf, &lastch);
            if (token != KEY && token != STRING)
                goto error;
-            if ((filename = TransFileName(im, tokenbuf)) == NULL)
-                goto error;
            if (++depth > 100)
                goto error;
+            if ((filename = TransFileName(im, tokenbuf)) == NULL)
+                goto error;
            infp = _XFopenFile(filename, "r");
                Xfree(filename);
            if (infp == NULL)