- 29 Dec, 2017 18 commits
-
-
Ulrich Sibiller authored
Fixes ArcticaProject/nx-libs#572
-
Ulrich Sibiller authored
with very few exceptions which require careful thinking ;-)
-
Ulrich Sibiller authored
==28424== 6 bytes in 1 blocks are definitely lost in loss record 1 of 7 ==28424== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28424== by 0x541D4D9: strndup (strndup.c:43) ==28424== by 0x4E8AD4B: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:311) ==28424== by 0x4EBE9CC: ConnectToRemote(ChannelEndPoint&) (Loop.cpp:6656) ==28424== by 0x4EB0A4C: SetupProxyConnection() (Loop.cpp:3205) ==28424== by 0x4EDC81A: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) (Loop.cpp:14308) ==28424== by 0x4EAE40F: NXTransPrepare (Loop.cpp:2576) ==28424== by 0x4EAA801: NXTransContinue (Loop.cpp:1610) ==28424== by 0x4EB50C9: WaitCleanup() (Loop.cpp:4436) ==28424== by 0x4EA9507: NXTransProxy (Loop.cpp:1235) ==28424== by 0x400B2A: main (Main.c:111)
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
SAFE_FREE has set defaultUnixPath_ to NULL already
-
Ulrich Sibiller authored
==7689== 50 bytes in 5 blocks are definitely lost in loss record 1 of 2 ==7689== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7689== by 0x54074D9: strndup (strndup.c:43) ==7689== by 0x4E7D803: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:309) ==7689== by 0x4EC9D93: ConnectToRemote(ChannelEndPoint&) [clone .constprop.144] (Loop.cpp:6660) ==7689== by 0x4ECB94E: SetupProxyConnection() (Loop.cpp:3204) ==7689== by 0x4ECE824: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) [clone .isra.129] (Loop.cpp:14312) ==7689== by 0x4ED0F8A: NXTransPrepare (Loop.cpp:2575) ==7689== by 0x4ED1C35: NXTransContinue (Loop.cpp:1609) ==7689== by 0x4ED1D7B: WaitCleanup() (Loop.cpp:4440) ==7689== by 0x4ED2343: NXTransProxy (Loop.cpp:1234) ==7689== by 0x400B2A: main (Main.c:111)
-
Ulrich Sibiller authored
Same as in WriteBuffer.cpp Valgrind will complain about uninitialized data, but we are only writing to the memory here.
-
Ulrich Sibiller authored
(partially) fixes ArcticaProject/nx-libs#612
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
(partially) fixes ArcticaProject/nx-libs#612
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
Fix another memleak (partially) fixes ArcticaProject/nx-libs#612
-
Ulrich Sibiller authored
was missing in the non-abstract code path (partially) fixes ArcticaProject/nx-libs#612
-
Ulrich Sibiller authored
fixes a memory leak
-
Ulrich Sibiller authored
(partially) fixes ArcticaProject/nx-libs#612
-
- 27 Dec, 2017 3 commits
-
-
Mihai Moldovan authored
Should avoid copy-constructing objects again.
-
Mihai Moldovan authored
nxcomp/src/Log.cpp: don't confuse users with useless warning messages in case that a log line append operation was requested, but the message level has lower precedence than the current log filter.
-
Mihai Moldovan authored
-
- 25 Dec, 2017 6 commits
-
-
Mihai Moldovan authored
-
Mihai Moldovan authored
Especially don't flush data out mid-append. Doing so will lead to the next append operation failing. Should fix messages queuing up indefinitely (until they are discarded at program termination, at least) and missing messages in general. Fixes: ArcticaProject/nx-libs#577 Fixes: ArcticaProject/nx-libs#611
-
Mihai Moldovan authored
-
Mihai Moldovan authored
Also handle errors due to missing buffers gracefully. This error is surprisingly easy to trigger, so we should make sure that the program does not crash.
-
Mihai Moldovan authored
-
Mihai Moldovan authored
-
- 24 Dec, 2017 2 commits
-
-
Mihai Moldovan authored
-
Mihai Moldovan authored
-
- 18 Dec, 2017 1 commit
-
-
Mihai Moldovan authored
-
- 11 Dec, 2017 2 commits
-
-
Mihai Moldovan authored
Fixes: ArcticaProject/nx-libs#596
-
Ulrich Sibiller authored
Fixes this: CXX Loop.lo Loop.cpp: In function 'void handleCheckResultInLoop(int&, int&, int&, fd_set&, fd_set&, timeval&, timeval&)': Loop.cpp:14080:68: warning: declaration of 'startTs' shadows a global declaration [-Wshadow] struct timeval &startTs) ^ Loop.cpp:1020:13: note: shadowed declaration is here T_timestamp startTs; Fixes ArcticaProject/nx-libs#545
-
- 09 Dec, 2017 6 commits
-
-
Ulrich Sibiller authored
Should be used instead of free() calls and will clear the pointer after calling free(). This can prevent double-free or use-after-free errors.
-
Ulrich Sibiller authored
The thread specific stringstream objects on the stack need to be deleted, not just pop()ed. Fixes ArcticaProject/nx-libs#573 (partially)
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
free() can handle NULL itself
-
Ulrich Sibiller authored
Fixes ArcticaProject/nx-libs#569
-
- 07 Dec, 2017 2 commits
-
-
Ulrich Sibiller authored
-
Ulrich Sibiller authored
-