I didn't mean to drop it in the first place in
07d30835 and
71bda0ed.

Dropping the sed hack was fine -  but we actually have to add these
flags to CDEBUGFLAGS as well.

Drop SHMNAME workaround again, it *is* defined in shmstr.h, which is actually header I was searching for.

nx-X11/programs/Xserver/Xext/shape.c: avoid pulling in Xlib in legacy mode via the _SHAPE_SERVER_ macro.

nx-X11/programs/Xserver/Xext/shape.c: pull in shapestr.h for legacy Xext proto versions, since shape.h would pull in Xlib.

Especially don't add linking flags willy-nilly.

Legacy Xext proto versions are automatically detected by the main
Makefile.

This reverts commit cc47066b.

This package is actually already depended upon.

shmproto.h must be in some other package. Investigating.

Automake older than version 1.11 does not support dist-xz. No workaround
possible via a feature check, as far as I can tell.

Avoids errors like these (and of course also is a good idea in general):
[   36s] make -C nx-X11 BuildIncludes FONT_DEFINES= -DLEGACY_XFONT1
[   36s] make: invalid option -- D
[   36s] make: invalid option -- E
[   36s] make: invalid option -- G
[   36s] make: invalid option -- A
[   36s] Usage: make [options] [target] ...

nx-libs.spec: imake is part of xorg-x11-util-devel on older *SUSE versions and the splitted imake package on later versions.

Partly reverts ec30a857, but in a
forward-compatible manner.

Legacy libXfont1 versions are automatically detected by the main
Makefile.

Failed *SUSE checks.

Just copy-paste the initial definition to avoid recursion.

We have no intention to remove system libraries.

We need -std=c99 to be passed through to the build process.

Attributes GH PR #605: https://github.com/ArcticaProject/nx-libs/pull/605

Reviewed-by: Ulrich Sibiller <uli42@gmx.de> --  Thu, 14 Dec 2017 13:15:12 +0000

 They have been flawed ever since nxagent came up, as they were Xfree
 (non-capital f) always, but should have been XFree (capital F, defined
 in Xlibint.h and part of libNX_X11).
 .
 Probably this all should be free() all over the code (bearing in mind,
 that XFree() returns int, not void. But still...

 Fixes ArcticaProject/nx-libs#553.

At least on platforms that support weak dependencies.