1. 31 May, 2016 5 commits
  2. 13 May, 2016 6 commits
  3. 02 May, 2016 29 commits
    • Mike Gabriel's avatar
    • Mike Gabriel's avatar
      hw/nxagent/Window.c: Initialize tmp_mask and attributes.event_mask with NoEventMask. · 00059798
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Window.c: In function ‘nxagentSetTopLevelEventMask’:
       Window.c:3392:31: warning: ‘attributes.event_mask’ may be used uninitialized in this function [-Wmaybe-uninitialized]
            Mask tmp_mask = attributes.event_mask;
                                      ^
       ```
      00059798
    • Mike Gabriel's avatar
      hw/nxagent/Colormap.c: Don't declare and assign flexibility variable if not used later on. · 7251ef49
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Colormap.c: In function ‘nxagentReconnectAllColormap’:
       Colormap.c:575:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
          int flexibility;
              ^
       ```
      7251ef49
    • Mike Gabriel's avatar
      hw/nxagent/GCOps.c: Don't declare and assign oldDstxyValue if not used later on. · 634484bb
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       GCOps.c: In function ‘nxagentCopyArea’:
       GCOps.c:597:7: warning: variable ‘oldDstxyValue’ set but not used [-Wunused-but-set-variable]
          int oldDstxyValue;
              ^
       ```
      634484bb
    • Mike Gabriel's avatar
      hw/nxagent/GC.c: Don't declare and assign flexibility variable if not used later on. · e8042c9f
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       GC.c: In function ‘nxagentReconnectAllGCs’:
       GC.c:1154:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
          int flexibility;
              ^
       ```
      e8042c9f
    • Mike Gabriel's avatar
      hw/nxagent/Events.c: Only declare and assign message_data and box variables if… · 7876d1f2
      Mike Gabriel authored
      hw/nxagent/Events.c: Only declare and assign message_data and box variables if compiled with -DTEST / -DDEBUG (plus drop commented out code).
      
       Amends the following compiler warnings:
      
       ```
       Events.c: In function ‘nxagentHandleClientMessageEvent’:
       Events.c:2694:13: warning: variable ‘message_data’ set but not used [-Wunused-but-set-variable]
              char *message_data;
                    ^
       Events.c: In function ‘nxagentClipAndSendExpose’:
       Events.c:4313:10: warning: variable ‘box’ set but not used [-Wunused-but-set-variable]
          BoxRec box;
                 ^
       ```
      7876d1f2
    • Mike Gabriel's avatar
      hw/nxagent/Display.c: Don't declare and assign packMethod / packQuality if not used later on. · 30cd3a6c
      Mike Gabriel authored
       Amends the following compiler warnings:
      
       ```
       Display.c: In function ‘nxagentReconnectDisplay’:
       Display.c:2449:19: warning: variable ‘packQuality’ set but not used [-Wunused-but-set-variable]
          int packMethod, packQuality;
                          ^
       Display.c:2449:7: warning: variable ‘packMethod’ set but not used [-Wunused-but-set-variable]
          int packMethod, packQuality;
              ^
       ```
      30cd3a6c
    • Mike Gabriel's avatar
      hw/nxagent/NXrender.c: Don't declare and assign the colors variable, if not used later on. · ab196f3a
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       NXrender.c: In function ‘swapStops’:
       NXrender.c:3036:13: warning: variable ‘colors’ set but not used [-Wunused-but-set-variable]
            CARD16 *colors;
                    ^
       ```
      ab196f3a
    • Mike Gabriel's avatar
      HAVE_STDINT_H: Always include <stdint.h>. · ce8fb1f9
      Mike Gabriel authored
       We don't define HAVE_STDINT_H anywhere and it should be more safe using
       the system's definition of UINT32_MAX.
      ce8fb1f9
    • Mike Gabriel's avatar
    • Mike Gabriel's avatar
      Adapt API for MakeAtom() and CopyISOLatin1Lowered to latest changes in X.org. · fb832b01
      Mike Gabriel authored
       This requires adaptations of arguments' types for the external
       references to MakeAtom() and CopyISOLatin1Lowered().
      
       These adaptations have been required in Xserver/include/dix.h,
       Xserver/include/dixfonts.c Xserver/dix/atom.c, Xserver/dix/dixutils.c,
       Xserver/os/oscolor.c.
      fb832b01
    • Mike Gabriel's avatar
      hw/nxagent/NXdixfonts.c: Don't include <X11/fonts/fontstruct.h>. No symbol… · 5e6b72dc
      Mike Gabriel authored
      hw/nxagent/NXdixfonts.c: Don't include <X11/fonts/fontstruct.h>. No symbol needed from that header file.
      5e6b72dc
    • Mike Gabriel's avatar
      hw/nxagent/NXpicture.c: Don't declare anything in empty function nxagentReconnectPictFormat. · 23d3821f
      Mike Gabriel authored
       Amends the following compiler warnings:
      
       ```
       NXpicture.c: In function ‘nxagentReconnectPictFormat’:
       NXpicture.c:2148:9: warning: variable ‘pBool’ set but not used [-Wunused-but-set-variable]
          Bool *pBool;
               ^
       NXpicture.c:2147:17: warning: variable ‘pFormat’ set but not used [-Wunused-but-set-variable]
          PictFormatPtr pFormat;
                        ^
       ```
      23d3821f
    • Mike Gabriel's avatar
      hw/nxagent/NXglyphcurs.c: Don't declare and set gcval, if not being used later on. · 292d88d0
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       NXglyphcurs.c: In function ‘ServerBitsFromGlyph’:
       NXglyphcurs.c:109:17: warning: variable ‘gcval’ set but not used [-Wunused-but-set-variable]
           ChangeGCVal gcval[3];
                       ^
       ```
      292d88d0
    • Mike Gabriel's avatar
      hw/nxagent/Keyboard.c: The ret variable is only used later on when compiled with -DTEST. · 182569bf
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Keyboard.c: In function ‘nxagentKeyboardProc’:
       Keyboard.c:688:7: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
          int ret;
              ^
       ```
      182569bf
    • Mike Gabriel's avatar
      hw/nxagent/Handlers.c: Don't declare and assign result variable if not used later on. · 66f88954
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Handlers.c: In function ‘nxagentShadowBlockHandler’:
       Handlers.c:732:7: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
          int result;
              ^
       ```
      66f88954
    • Mike Gabriel's avatar
      hw/nxagent/Keyboard.c: Don't declare and set XkbDescPtr xkb if not used later on. · fc393174
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Keyboard.c: In function ‘nxagentNotifyKeyboardChanges’:
       Keyboard.c:1211:16: warning: variable ‘xkb’ set but not used [-Wunused-but-set-variable]
            XkbDescPtr xkb;
                       ^
       ```
      fc393174
    • Mike Gabriel's avatar
      hw/nxagent/*.c: Drop various declarations of unused ScreenPtr pScreen. · eb682184
      Mike Gabriel authored
       These can be dropped after we have turned REGION_* macros into
       static inline function calls in some of the previous commits.
      eb682184
    • Mike Gabriel's avatar
      hw/nxagent/Screen.c: Cast proper types before handing values over to fprintf(). · b5b7a2d2
      Mike Gabriel authored
       Amends the following compiler warnings:
      
       ```
       Screen.c: In function ‘nxagentCreateIconWindow’:
       Screen.c:394:15: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
                      nxagentIconWindow);
                      ^
       Screen.c: In function ‘nxagentSetScreenSaverTime’:
       Screen.c:456:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘CARD32’ [-Wformat=]
                          ScreenSaverTime, ScreenSaverInterval);
                          ^
       Screen.c:456:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ [-Wformat=]
       Screen.c:476:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘CARD32’ [-Wformat=]
                          ScreenSaverTime, ScreenSaverInterval);
                          ^
       Screen.c:476:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ [-Wformat=]
       Screen.c: In function ‘nxagentOpenScreen’:
       Screen.c:1234:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘VisualID’ [-Wformat=]
                          visuals[numVisuals].vid);
                          ^
       Screen.c:1274:23: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘VisualID’ [-Wformat=]
                              depths[depthIndex].depth);
                              ^
       Screen.c:1282:17: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘VisualID’ [-Wformat=]
                        defaultVisualIndex, visuals[defaultVisualIndex].vid);
                        ^
       Screen.c:1319:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
                          rootDepth, defaultVisual);
                          ^
       Screen.c:1336:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
                          rootDepth, defaultVisual);
                          ^
       Screen.c:1348:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
                          rootDepth, defaultVisual);
                          ^
       Screen.c:1357:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
                          rootDepth, defaultVisual);
                          ^
       Screen.c:1723:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
                            nxagentDefaultWindows[pScreen->myNum]);
                            ^
       Screen.c:1763:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
                          nxagentDefaultWindows[pScreen->myNum]);
                          ^
       Screen.c:1775:17: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
                        nxagentDefaultWindows[pScreen->myNum]);
                        ^
       Screen.c:1790:17: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
                        nxagentDefaultWindows[pScreen->myNum]);
                        ^
       Screen.c: In function ‘nxagentShadowAdaptDepth’:
       Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
                     pVisual -> red_mask, pVisual -> green_mask, pVisual -> blue_mask);
                     ^
       Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
       Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
       Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
                      redMask, greenMask, blueMask);
                      ^
       Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
       Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
       ```
      b5b7a2d2
    • Mike Gabriel's avatar
      hw/nxagent/Screen.c: Drop various unused variables. · ab50f84b
      Mike Gabriel authored
       Amends the following compiler warnings:
      
       ```
       Screen.c: In function ‘nxagentReconnectScreen’:
       Screen.c:3547:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
         int flexibility;
             ^
       Screen.c: In function ‘nxagentAdjustRandRXinerama’:
       Screen.c:3746:12: warning: unused variable ‘j’ [-Wunused-variable]
            int i, j;
                   ^
       Screen.c: In function ‘nxagentSaveAreas’:
       Screen.c:4116:15: warning: variable ‘pDrawable’ set but not used [-Wunused-but-set-variable]
          DrawablePtr pDrawable;
                      ^
       Screen.c: In function ‘nxagentRestoreAreas’:
       Screen.c:4236:15: warning: variable ‘pDrawable’ set but not used [-Wunused-but-set-variable]
          DrawablePtr pDrawable;
                      ^
       ```
      ab50f84b
    • Mike Gabriel's avatar
      hw/nxagent/Screen.h: Provide prototype for nxagentAdjustRandRXinerama(). Avoid… · ef287b54
      Mike Gabriel authored
      hw/nxagent/Screen.h: Provide prototype for nxagentAdjustRandRXinerama(). Avoid implicit-declaration compiler warning.
      
       Amends the following compiler warning:
      
       ```
       Screen.c:3716:5: warning: implicit declaration of function ‘nxagentAdjustRandRXinerama’ [-Wimplicit-function-declaration]
            nxagentAdjustRandRXinerama(pScreen);
            ^
       ```
      ef287b54
    • Mike Gabriel's avatar
      hw/nxagent/Screen.c: Correctly use already defined MIN/MAX macros. · 72386e17
      Mike Gabriel authored
       Use MIN(A,B) macro as defined in Utils.h. Add MAX(A,B) macro in Utils.h,
       as well. Don't have another set of MIN/MAX macro definitions in
       Screen.c.
      
       Amends the following compiler warnings:
      
       ```
       Screen.c:3600:0: warning: "MIN" redefined
        #define MIN(a,b) ((a) < (b)) ? (a) : (b);
        ^
       In file included from Screen.c:78:0:
       Utils.h:36:0: note: this is the location of the previous definition
        #define MIN(A, B) ( (A) < (B) ? (A) : (B) )
        ^
       ```
      72386e17
    • Mike Gabriel's avatar
      hw/nxagent/Window.c: Don't declare "XWindowChanges changes;" and later not use it. · 7d3d47f1
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Window.c:2179:24: warning: variable ‘changes’ set but not used [-Wunused-but-set-variable]
               XWindowChanges changes;
                              ^
       ```
      7d3d47f1
    • Mike Gabriel's avatar
      hw/nxagent/Pixmap.c: pBool pointer is only required when compiled in -DTEST mode. · 5ea2457e
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Pixmap.c: In function ‘nxagentDisconnectPixmap’:
       Pixmap.c:755:9: warning: variable ‘pBool’ set but not used [-Wunused-but-set-variable]
          Bool *pBool;
                ^
       ```
      5ea2457e
    • Mike Gabriel's avatar
      hw/nxagent/Extension.c: Don't declare pRandRScrPriv without using it later on. · 08d38484
      Mike Gabriel authored
       Amends the following the compiler warnings:
      
       ```
       Extensions.c: In function ‘nxagentRandRInitSizes’:
       Extensions.c:159:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
          rrScrPrivPtr pRandRScrPriv = rrGetScrPriv(pScreen);
                       ^
       Extensions.c: In function ‘nxagentRandRSetConfig’:
       Extensions.c:263:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
          rrScrPrivPtr pRandRScrPriv;
                       ^
       Extensions.c: In function ‘nxagentRandRScreenSetSize’:
       Extensions.c:322:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
          rrScrPrivPtr pRandRScrPriv;
                       ^
       ```
      08d38484
    • Mike Gabriel's avatar
      hw/nxagent/Rootless.c: Type cast type Atom to type long unsigned int before… · 802f5816
      Mike Gabriel authored
      hw/nxagent/Rootless.c: Type cast type Atom to type long unsigned int before handing it over to %lu in fprintf().
      
       Amends the following compiler warnings:
      
       ```
       Rootless.c: In function ‘nxagentExportProperty’:
       Rootless.c:775:21: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘Atom’ [-Wformat=]
                            "Property [%lu] too long.\n", propertyX);
                            ^
       ```
      802f5816
    • Mike Gabriel's avatar
      hw/nxagent/Splash.c: Drop unused variable declaration "XPoint m[12];". · c206a0c6
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Splash.c: In function ‘nxagentPaintLogo’:
       Splash.c:168:13: warning: unused variable ‘m’ [-Wunused-variable]
          XPoint    m[12];
                    ^
       ```
      c206a0c6
    • Mike Gabriel's avatar
      hw/nxagent/Clipboard.c: The result variable is only needed when combiled with -DDEBUG. · 5bbdbfce
      Mike Gabriel authored
       Amends the following compiler warning:
      
       ```
       Clipboard.c: In function ‘nxagentRequestSelection’:
       Clipboard.c:272:7: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
          int result;
              ^
       ```
      5bbdbfce
    • Mike Gabriel's avatar