The var is not defined anymore and the libXinerama code has been removed
 some time ago.

This commit removes several warnings in nxcomp related to unused but
set variables. It also replaces tempnam function with the more secure
one mkstemp and there has been removed another warning related to
setgid and setuid returning values not being checked.

So these were the compiler warnings in nxcomp that have been fixed:

Loop.cpp: In function ‘int ParseRemoteOptions(char*)’:
Loop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable]
   int hasLimit  = 0;
       ^
Loop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable]
   int hasRender = 0;
       ^
Loop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable]
   int hasTaint  = 0;
       ^
Loop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable]
   int hasStrict = 0;
       ^
Loop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable]
   int hasShseg  = 0;
       ^
ServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’:
ServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable]
     int hit;
         ^
Proxy.o: In function `Proxy::handleSaveAllStores(char const*) const':
Proxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp'

Pipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’:
Pipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
       setgid(getgid());
                       ^
Pipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
       setuid(getuid());
                       ^

There was also a hidden problem in the way Proxy::handleSaveAllStores was
checking for an error in the returning value from the call to the virtual
method handleSaveAllStores of the specific proxy class really being used
(ClientProxy or ServerProxy).

Former code was considering the value 0 as the returning value in case of
an error whereas both subclasses return the value -1 when there is an error
in their handleSaveAllStores method.

This bug has been fixed in this commit taking advantage of the modification
that was already being made to this method in order to replace tempnam
function with the more secure one mkstemp.

Fixes: ArcticaProject/nx-libs#103

It was GPL3 instead of GPL2!

Fixes ArcticaProject/nx-libs#112

This commit removes TextCompressor class references from ClientCache
and ServerCache as it's no longer used after removing old protocol's
compatibility code from nxcomp. It also removes the attribute textCache
from both classes as it's no longer used either.

Finally the header and source files associated with the TextCompressor
class are also deleted and removed from the compilation process.

Refs: ArcticaProject/nx-libs#108

This commit provides documentation about some error tests that have been
run to check how well behaves nxcomp after removing it's compatibility
code with versions prior to 3.5.0 and it has to handle a situation in
in which and older proxy tries to connect with a nxcomp 3.6.x based proxy.

Refs: ArcticaProject/nx-libs#108

This commit removes obsolete compatibility files whose components were
only used to handle compatibility with old protocol versions that are
no longer supported.

Refs: ArcticaProject/nx-libs#108

As a part of nxcomp's clean-up process, compatibility with old protocol
versions has been set now at 3.5.0.

This commit removes compatibility code from nxcomp so the minimum supported
version changes from 1.5.0 (protocol step 6) to 3.5.0 (protocol step 10).

At this moment the removal is not complete and it will be followed by some
other commits, in order to get rid of several components and files that are
no longer used as they were only needed to work with old protocol versions.

Refs: ArcticaProject/nx-libs#108

Fixes ArcticaProject/nx-libs#104

debian/patches/401_nxcomp_bigrequests-and-genericevent-extensions.full+lite.patch: Move into debian/patches-pending-evaluation/.

Attributes GH PR #71: https://github.com/ArcticaProject/nx-libs/pull/71

Add instructions for building using Mock under Fedora/EPEL.

debian/nx-x11proto-xinerama-dev.install.in: Install PANORAMIX extension header files into its own nx-x11proto bin:package. (more Xinerama clean-up, fix FTBFS during dh_install).

Complete changes from commit 0d56c45a in NXpicturestr.h (i.e. add a missing comment).  (Fixes ArcticaProject/nx-libs#38).

commit 0d56c45a was:
nx-X11: handle source pictures (those without a Drawable surface) gracefully.

Attributes GH PR #66: https://github.com/ArcticaProject/nx-libs/pull/66

This fixes the problem Mike Gabriel describes like this:

- Launch a session on a system with a single monitor. Enable Xinerama
  for this session.
- Open a desktop session in that session window (e.g. MATE or XFCE).
- Move the NX/MATE-or-XFCE session window around on that one
  monitor. Bump at the borders, so that the session window moves into
  the invisible parts around your monitor.

What you see is that the MATE-or-XFCE window manager will become
really busy with resizing the windows and panels in the NX session,
because moving the window over the physical borders of the display
will trigger resize events.

This is non-intuitive, I think.

Same with multi-monitors on the outside edges of the physical Xorg
RandR setup.