This has nothing to do with the transport.

We can only free the xkbDevicePrivate because we do not know the
details of any other (possible) extension. So let's limit to that one
private for now and call the new xkbFreePrivates from dix (where such
a function is completely missing).

  commit 758393951233d1b2520cf4cefd33ec4288a3880a
  Author: Dave Airlie <airlied@redhat.com>
  Date:   Wed Sep 12 11:09:40 2018 +1000

    xkb: fix what looks to be a copy-paste error with first vs firstMM

    Pointed out by coverity.
Signed-off-by: Dave Airlie <airlied@redhat.com>

xkmread.c: In function ‘XkmReadFileSectionName’:
xkmread.c:1181:25: warning: ‘tmpTOC.type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     XkbConfigText(tmpTOC.type,XkbMessage),0);

  commit 83913de25d35709b3ab7b0ab124b73924145d2dd
  Author: Adam Jackson <ajax@redhat.com>
  Date:   Thu Apr 5 12:59:11 2018 -0400

    xkb: Silence some compiler warnings

    Of the form:

    ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’:
    ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals destination size [-Wstringop-truncation]
                 strncpy(alias->real, realStr, XkbKeyNameLength);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    This is intentional; the code that reads from these fields never reads
    more than 4 bytes anyway. Rephrase things in terms of memcpy so that's
    clear. Obviously this is awful but in XKB awful is par.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Acked-by: Keith Packard <keithp@keithp.com>

  commit a4a2e814d5d0e6152307a301eda1d6fc1c555aaa
  Author: Alan Coopersmith <alan.coopersmith@oracle.com>
  Date:   Sun Feb 13 21:36:02 2011 -0800

    xkb: Use snprintf to measure string lengths instead of manual strlen math
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>

  commit 2391c409a2840d61fed93832650c0d6c82ebebdf
  Author: Eamon Walsh <ewalsh@tycho.nsa.gov>
  Date:   Fri Jun 13 22:48:17 2008 -0400

    Fix "warning: unused variable `s'".

  commit 534fc5140b039a8c98ab715d0a6740d513b41209
  Author: Daniel Stone <daniel@fooishbar.org>
  Date:   Sun Feb 3 23:30:22 2008 +1100

    XKB: Remove a bunch of mad ifdefs

    We have SEEK_SET and size_t, seriously.  Also use DebugF instead of
    ifdef DEBUG, and ditch a couple of random bits that were never used.

Fixes this cppcheck finding:
[nx-X11/programs/Xserver/xkb/xkbActions.c:1306]: (error) Uninitialized variable: oldState

  commit 35a4b8e7f4526a92d44cb16a783f21030cd1f6df
  Author: Peter Hutterer <peter.hutterer@who-t.net>
  Date:   Tue May 5 16:51:59 2009 +1000

    xkb: remove oldState from XkbHandleActions.

    I really don't know what the purpose of this variable is or was, aside from
    potentially clobbering up our key state since there's a path where it may be
    used uninitialised.

    Also, this means that xkbi->prev_state is now accessible from the DIX with
    meaningful data.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Backport of this commit:

  commit b2167015043a458e9cf93b827b43eb5b7c552ce9
  Author: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
  Date:   Sat Nov 4 23:06:27 2017 +0100

    xkb: initialize tsyms

    This fixes some “Conditional jump depends on uninitialized value(s)”
    errors spotted by valgrind.
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Fixes ArcticaProject/nx-libs#808

Backport of

  commit dc9ce695a69ca0787f58f8d160212a7a41acb703
  Author: Rami Ylimäki <rami.ylimaki@vincit.fi>
  Date:   Wed Mar 9 15:45:40 2011 +0200

    xkb: Initialize pad bytes sent in replies of geometry requests.

    Valgrind complains about uninitialized data being written to clients.
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
Signed-off-by: Rami Ylimäki <rami.ylimaki@vincit.fi>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Backport of

  commit 81b3b0cce088866dc3cda099d7c8d6655849fd43
  Author: Tomas Janousek <tomi@nomi.cz>
  Date:   Wed May 20 15:03:01 2009 +0200

    Bug #6428, #16458, #21464: Fix crash due to uninitialized VModMap fields.

    In ProcXkbGetKbdByName, mrep.firstVModMapKey, .nVModMapKeys and
    .totalVModMapKeys were not initialized, contained random values and caused
    accesses to unallocated and later modified memory, causing
    XkbSizeVirtualModMap and XkbWriteVirtualModMap to see different number of
    nonzero values, resulting in writes past the end of an array in XkbSendMap.

    This patch initializes those values sensibly and reverts commits 5c0a2088 and
    6dd4fc46, which have been plain non-sense.
Signed-off-by: Tomas Janousek <tomi@nomi.cz>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

This commit + some more adaption in ddxLoad.c which where no longer
present when Alan did the patch. However, our code still has them:

  Author: Alan Coopersmith <alan.coopersmith@oracle.com>
  Date:   Sat Nov 27 20:09:04 2010 -0800

    Convert existing Xprintf style calls to asprintf style
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Mikhail Gusarov <dottedmag@dottedmag.net>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Author: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
  Date:   Thu Jul 22 11:34:54 2010 +0300

    xkb: Don't check for NULL before calling free
Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

  Author: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
  Date:   Thu Jul 22 11:33:33 2010 +0300

    xkb: Fix memory leak if opening file fails

    If fopen fails pointer in buf would be overwriten with a new pointer.
Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Backported from Xorg:

  commit f292de2ef13dc994a38029cee9e2642576893332
  Author: Daniel Stone <daniel@fooishbar.org>
  Date:   Wed Mar 21 02:04:12 2007 +0200

    XKB: Fix size_syms calculation bug

    Apparently it needed to be nSyms*15/10, not *12/10; make it match the
        other allocation code.
Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

    commit 7c4c00649cae855e141ec9a3667bfe399e3156d0
    Author: Daniel Stone <daniel@fooishbar.org>
    Date:   Thu Jan 1 05:25:52 2009 +1100

        XKB: Remove unused DDX functions

        They were complete no-ops anyway.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

    commit 6aef4e96affcc26b9415c6bc9c9bebb5af05a1a7
    Author: Daniel Stone <daniel@fooishbar.org>
    Date:   Sat Jan 17 13:42:46 2009 +0200

        XKB: Fix logic error

        Use logical or instead of bitwise or.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

  commit 8311cd5f89ca6781842bb24671b8122cdf8be148
  Author: Jeremy Huddleston <jeremyhu@freedesktop.org>
  Date:   Tue Mar 23 10:37:36 2010 -0700

      XKB: Fix garbage initialization

      XkbEnableDisableControls set extra garbage bits on the xkbControlsNotify
          changedControls mask because it was uninitialized on the stack.

      Found by clang
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

  We have fixed that (independendly) before, but missed one line.
Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

    commit 85f9017393c9bb19553e9afcf554673a44a09993
    Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
    Date:   Tue Feb 8 11:10:10 2011 +0200

      ProcXkbGetXkbByName: fix use of uninitialised bytes valgrind error.

      ==9999== Syscall param writev(vector[...]) points to uninitialised byte(s)
      ==9999==    at 0x4AB5154: writev (writev.c:51)
      ==9999==    by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912)
      ==9999==    by 0x61C8B: FlushClient (io.c:924)
      ==9999==    by 0x62423: WriteToClient (io.c:846)
      ==9999==    by 0xCE39B: XkbSendMap (xkb.c:1408)
      ==9999==    by 0xD247B: ProcXkbGetKbdByName (xkb.c:5814)
      ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
      ==9999==    by 0x205BF: main (main.c:291)
      ==9999==  Address 0x557eb68 is 40 bytes inside a block of size 4,096 alloc'd
      ==9999==    at 0x48334A4: calloc (vg_replace_malloc.c:467)
      ==9999==    by 0x62567: WriteToClient (io.c:1065)
      ==9999==    by 0x452EB: ProcEstablishConnection (dispatch.c:3685)
      ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
      ==9999==    by 0x205BF: main (main.c:291)
      ==9999==  Uninitialised value was created by a stack allocation
      ==9999==    at 0xD1910: ProcXkbGetKbdByName (xkb.c:5559)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Oliver McFadden <oliver.mcfadden@nokia.com>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>

Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>

    commit 8a34d7a8532c7ca013e67307f3baf200167abb92
    Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
    Date:   Tue Feb 8 11:10:11 2011 +0200

      XkbSendNames: fix use of uninitialised bytes valgrind error.

      ==537== Syscall param writev(vector[...]) points to uninitialised byte(s)
      ==537==    at 0x4AB7154: writev (writev.c:51)
      ==537==    by 0x8935B: _XSERVTransWritev (Xtrans.c:912)
      ==537==    by 0x6C55F: FlushClient (io.c:924)
      ==537==    by 0x6CCF3: WriteToClient (io.c:846)
      ==537==    by 0xD51D3: XkbSendNames (xkb.c:3765)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
      ==537==  Address 0x55899f2 is 154 bytes inside a block of size 1,896 alloc'd
      ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
      ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
      ==537==  Uninitialised value was created by a heap allocation
      ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
      ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Oliver McFadden <oliver.mcfadden@nokia.com>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>

Just use the existing xkb code

 commit 1ef60ce8ebb681b3cfb5e515be5c187c0442dcda
 Author: Daniel Stone <daniel@fooishbar.org>
 Date:   Sat Mar 25 22:35:48 2006 +0000

    Really remove all DDX pre-config code.

 commit ec10f70b2114e5369a5b2f34b084dcf55634dcb4
 Author: Daniel Stone <daniel@fooishbar.org>
 Date:   Sat Mar 25 21:52:49 2006 +0000

    Remove XkbCF DDX configuration code.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Spotted in and backported from X.org:

 commit 021fc5cb2cb4a7972b4a6fcb570c1da92787d68d
 Author: Adam Jackson <ajax@benzedrine.nwnk.net>
 Date:   Sun Mar 18 16:31:19 2007 -0400

    Static markup and dead code cull over xkb/.

    The former <X11/extensions/XKBsrv.h> has been pulled into the server now as
    include/xkbsrv.h, and the world updated to look for it in the new place,
    since it made no sense to define server API in an extension header.  Any
    further work along this line will need to do similar things with XKBgeom.h
    and friends.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org:

 commit fd8bde8bb0f9d796b3464973b53285c0a6d22a31
 Author: Daniel Stone <daniel@fooishbar.org>
 Date:   Mon May 29 11:14:03 2006 +0000

    Remove -xkbmap argument.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

and do it identically everywhere. As we are using C99 designated
initializers here we remove the memset and bzero calls that had been
used for this at some locations.

In XORG-7_1 xkbconfig.c had been dropped. We must keep this file
because it is used by hw/nxagent/Keyboard.c to load the xkb
configuration file. Maybe we should move the relevant code to there or
drop xkb configuration file support from nxagent.

as reported by valgrind

Backported from X.Org:

   commit 1cfa9f647e0241f4b9e56556b128d7bfd987eaca
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Tue Feb 28 16:55:26 2006 +0000

   Bug # 5216: Allow options to appear with other components.
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

If no rules file is given, simply re-use the previous one. If no RF is given
the first time this function is called, use the built-in default.
This includes fixing the built-in default to something that actually exists.
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Fixes ArcticaProject/nx-libs#371

This is basically a backport of the following commits + replacing
xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.

   commit 2761c103311a1160bc483fd0367d654733df8598
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:03:26 2007 +0000

       OS: Remove usage of alloca

       Replace with heap allocations.

   commit 5e363500c86042c394595e1a6633581eb8fcd1bb
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:38:28 2007 +0000

       OS: Remove ALLOCATE_LOCAL from os.h

       Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
       remove the include of Xalloca.h as well.

this was missing from the backport of
5623c27700b7b23a8dbbd8c8f45e5d4fa0c667e3 (Constify atom name strings)