Fix these memory leaks:

==30021== 128 bytes in 1 blocks are definitely lost in loss record 230 of 302
==30021==    at 0x483577F: malloc (vg_replace_malloc.c:299)
==30021==    by 0x2EF89C: init_visuals (xf86glx.c:390)
==30021==    by 0x2EF89C: __MESA_initVisuals (xf86glx.c:541)
==30021==    by 0x17C922: GlxInitVisuals (glxext.c:317)
==30021==    by 0x218E73: fbInitVisuals (fbcmap.c:668)
==30021==    by 0x20BEB1: fbFinishScreenInit (fbscreen.c:229)
==30021==    by 0x20C275: fbScreenInit (fbscreen.c:273)
==30021==    by 0x1E0317: nxagentOpenScreen (Screen.c:1357)
==30021==    by 0x16D848: AddScreen (dispatch.c:4171)
==30021==    by 0x1DB7FF: InitOutput (Init.c:396)
==30021==    by 0x14DB12: main (main.c:279)
==30021==
==30021== 3,072 (192 direct, 2,880 indirect) bytes in 1 blocks are definitely lost in loss record 290 of 302
==30021==    at 0x483577F: malloc (vg_replace_malloc.c:299)
==30021==    by 0x2CCCC7: _gl_context_modes_create (glcontextmodes.c:364)
==30021==    by 0x2EF87C: init_visuals (xf86glx.c:381)
==30021==    by 0x2EF87C: __MESA_initVisuals (xf86glx.c:541)
==30021==    by 0x17C922: GlxInitVisuals (glxext.c:317)
==30021==    by 0x218E73: fbInitVisuals (fbcmap.c:668)
==30021==    by 0x20BEB1: fbFinishScreenInit (fbscreen.c:229)
==30021==    by 0x20C275: fbScreenInit (fbscreen.c:273)
==30021==    by 0x1E0317: nxagentOpenScreen (Screen.c:1357)
==30021==    by 0x16D848: AddScreen (dispatch.c:4171)
==30021==    by 0x1DB7FF: InitOutput (Init.c:396)
==30021==    by 0x14DB12: main (main.c:279)

The problem here is that GlxInitVisuals is called twice. First via
fbScreenInit and then again via nxagentInitGlxExtension. We remove the
first one to ensure the code in nxagenOpenScreen works as initially
intended.

There's an xorg upstream patch that does the same
(7d74690536b64f7b8e8036507ab7790807349c50), but it also cleans up
other stuff we do not even have in out source (yet?).

  commit 57e872301f5e836be2efb8f952f9c9711650b447
  Author: Adam Jackson <ajax@redhat.com>
  Date:   Thu Apr 5 13:07:09 2018 -0400

    mi: Hush an almost certainly bogus warning

    In file included from ../mi/miexpose.c:83:
    ../mi/miexpose.c: In function ‘miHandleExposures’:
    ../include/regionstr.h:174:22: warning: ‘expBox.y2’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         (_pReg)->extents = *(_pBox);
         ~~~~~~~~~~~~~~~~~^~~~~~~~~~
    ../mi/miexpose.c:139:12: note: ‘expBox.y2’ was declared here
         BoxRec expBox;
                ^~~~~~

    etc. It's initialized if (extents), and then only read if (extents),
    but gcc doesn't seem to figure that out. Whatever, bzero it to be
    explicit.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Acked-by: Keith Packard <keithp@keithp.com>

We are not using any alloc function that respects that variable, so
lets drop it. Backport of this commit:

  commit 0ce61e21d6d7dcca0090e319bbcdb678570f2c3f
  Author: Adam Jackson <ajax@redhat.com>
  Date:   Fri Oct 3 16:05:19 2008 -0400

    Remove the Must_have_memory hack.

    Also remove an astonishing amount of misunderstanding of how casts work.

The only left function is identical to the one in mi/miexpose.c.

miPaintWindow() was identical to the version in miexpose.c except
for some unitialized variable fixes. As these also should be in
upstream code we add them there (Note: Xorg never fixed this but
totally rewrote the miPaintWindow() later on.)

This allows us to totally drop our special version of miPaintWindow().

It is (functionally) identical to our code, so why have
duplicate code?

  commit a73e0f8cdfec1c9199ffe696146ba7d677c4c10d
  Author: Daniel Stone <daniel@fooishbar.org>
  Date:   Thu Jun 1 18:47:47 2006 +0000

    Die XTESTEXT1, die!

Citing an email from the xorg-modular mailing list:

On Tuesday 21 February 2006 23:04, Enrico Weigelt wrote:
> Hi folks,
>
> I'm wondering what's the difference between XTEST and XTESTEXT1
> (the second one can be configured w/ my current patch ...)
> Are they both the same ( -> XTest extension ) ?
> Can I put both symbols together ?

They're not the same extension.  XTest is the one you want, if you want
either.  The other hasn't been built by default in ages and I should probably
go ahead and nuke it from the tree.

- ajax

misc: fix more regressions and whitespace weirdness introduced in 913fcf1a.

Backported from X.org:

commit 39ce5f1544029412f4060f3e89ce1d87222ef42b
Author: Adam Jackson <ajax@nwnk.net>
Date:   Fri Jan 6 17:05:26 2006 +0000

    Remove unused X11R4 DDX compatibility function miClipNotify.
Backported-to-NX-by: Mihai Moldovan <ionic@ionic.de>

I left out glx changes to miinitext.c for now.

as reported by valgrind

Drop SHMNAME workaround again, it *is* defined in shmstr.h, which is actually header I was searching for.

Legacy Xext proto versions are automatically detected by the main
Makefile.

 - Move FONT_DEFINES and XLIBFONT definition to from Server.tmpl to
   Imake.tmpl.
 - Add FONT_DEFINES to ALLDEFINES.
 - Drop SpecialCObjectRules with FONT_DEFINES from various Imakefiles
   again, FONT_DEFINES is now set "globally".
 - Hand over FONT_DEFINES from main Makefile to nx-X11's make BuildEnv
   to make gccmakedep happy.

 Backported from X.org:

 commit f2e310132fbe1520c1b5f3da4faa2d2d47835e72
 Author: Aaron Plattner <aplattner@nvidia.com>
 Date:   Wed Oct 31 14:15:35 2007 -0700

    Add CreatePixmap allocation hints.

    These hints allow an acceleration architecture to optimize allocation of certain
    types of pixmaps, such as pixmaps that will serve as backing pixmaps for
    redirected windows.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Fixes ArcticaProject/nx-libs#296.

 Inspired by the following X.org commit. Other than X.org, we will continue
 support for building nx-libs against libXfont1 for a while.

 commit 05a793f5b3c40747d5a92a076def7f4fb673c7e7
 Author: Keith Packard <keithp@keithp.com>
 Date:   Tue Sep 1 18:50:55 2015 -0700

    dix: Switch to the libXfont2 API (v2)

    This new libXfont API eliminates exposing internal X server symbols to
    the font library, replacing those with a struct full of the entire API
    needed to use that library.

    v2: Use libXfont2 instead of libXfont_2
Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>

 Extracted from X.org bulk commit:

 commit 1f0e8bd5eb1a5539689cfc4f5a6b86b530907ec5
 Author: Dave Airlie <airlied@redhat.com>
 Date:   Tue Jun 5 13:22:18 2012 +0100

    api: rework the X server driver API to avoid global arrays.

    This is a squash merge containing all the API changes, as
    well as the video ABI bump.

    Its been squashed to make bisection easier.

    Full patch log below:

    [...]

    commit 06729dbbc804a20242e6499f446acb5d94023c3c
    Author: Dave Airlie <airlied@gmail.com>
    Date:   Tue Apr 10 14:04:59 2012 +0100

        xserver: remove index from CloseScreen (API/ABI breakage)

        This drops the index from the CloseScreen callback,
        its always been useless really, since the pScreen contains it.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Acked-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

Move the code for resetting the DPMS mode in response to input events, from WaitForSomething to mieqProcessInputEvents.

 Backported from X.org:

 commit 3b5b7ef5c2ab1d196806f6359e0972fd78d204dd
 Author: Fredrik Höglund <fredrik@kde.org>
 Date:   Wed Jan 3 21:05:35 2007 +0100

    Move the code for resetting the DPMS mode in response to input events,
    from WaitForSomething to mieqProcessInputEvents.

    mieqProcessInputEvents already handles resetting the screen saver.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

This is basically a backport of the following commits + replacing
xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.

   commit 2761c103311a1160bc483fd0367d654733df8598
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:03:26 2007 +0000

       OS: Remove usage of alloca

       Replace with heap allocations.

   commit 5e363500c86042c394595e1a6633581eb8fcd1bb
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:38:28 2007 +0000

       OS: Remove ALLOCATE_LOCAL from os.h

       Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
       remove the include of Xalloca.h as well.

This is basically a backport of the following commits + replacing
xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.

   commit 2761c103311a1160bc483fd0367d654733df8598
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:03:26 2007 +0000

       OS: Remove usage of alloca

       Replace with heap allocations.

   commit 5e363500c86042c394595e1a6633581eb8fcd1bb
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:38:28 2007 +0000

       OS: Remove ALLOCATE_LOCAL from os.h

       Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
       remove the include of Xalloca.h as well.

nx-X11/programs/Xserver/mi/{Imakefile,mibank.{c,h}}: backport ffaae7c0c69a51a53a76146c79f3630ae197a443.

 Down with mibank!

 Fixes ArcticaProject/nx-libs#366.

 Relates to ArcticaProject/nx-libs#275.

 Relates to ArcticaProject/nx-libs#275.

 Relates to ArcticaProject/nx-libs#275.

 Relates to ArcticaProject/nx-libs#275.

 From c3d14036729fd186d4ec7ca1de603e1f2d174e2f Mon Sep 17 00:00:00 2001
 From: Eric Anholt <anholt@freebsd.org>
 Date: Fri, 10 Feb 2006 22:00:30 +0000
 Subject: Remove libcwrapper usage from xorg server modules. The libcwrapper is
   only of (marginal) use in the drivers, and that usage remains.
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Fixes ArcticaProject/nx-libs#246 (together with merge commit
 ecd335fa).

We do not build loadable modules, so we do not need them anywhere.

Also remove the extra files requires for module builds.

 commit 748cfbc820f8cdeb544c54a6db495fecf2e2457b
 Author: Adam Jackson <ajax@aspartame.nwnk.net>
 Date:   Sat Nov 17 21:23:05 2007 -0500

    Disinfect mi/ of mfb.
Backport-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 This has already been started while replacing copyright info in file
 headers and has now been completed with this commit.

Per-file copyright notices: Update copyright information in file headers that NoMachine placed there own copyright statement in.

Remove defines of NEED_EVENTS and NEED_REPLIES because they are never
used anywhere.

Basically these three commits, but as they are newer and to not match
the code structure the patches have not been applied but replaced by
sed + manual intervention:

   From cb95642dc8edebb2935dd471f8b339cb98aa8481 Mon Sep 17 00:00:00 2001
   From: Peter Hutterer <peter.hutterer@redhat.com>
   Date: Fri, 28 Nov 2008 22:28:32 +1000
   Subject: Remove #define NEED_EVENTS and NEED_REPLIES

   A grep on xorg/* revealed there's no consumer of this define.

   Quote Alan Coopersmith:
   "The consumer was in past versions of the headers now located
   in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h,
   all the event definitions were only available if NEED_EVENTS were
   defined, and all the reply definitions required NEED_REPLIES.

   Looks like Xproto.h dropped them by X11R6.3, which didn't have
   the #ifdef's anymore, so these are truly ancient now."
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>

--

   From 6de368c9aa7ccd2fcd62fca5a2b278913db4d03d Mon Sep 17 00:00:00 2001
   From: Fernando Carrijo <fcarrijo@yahoo.com.br>
   Date: Thu, 1 Jul 2010 06:50:47 -0300
   Subject: Purge macros NEED_EVENTS and NEED_REPLIES
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

--

   From 57c03e52e6b4e3ed54df5fdd778865467d08e119 Mon Sep 17 00:00:00 2001
   From: Fernando Carrijo <fcarrijo@yahoo.com.br>
   Date: Thu, 1 Jul 2010 06:59:48 -0300
   Subject: Purge macro NEED_EVENTS
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

 INITARGS was a hardcoded define to void.  Since knowing the function
 signature for your extensions is kinda useful, just replace it with a
 hardcoded void, but leave the define there for API compatibility.
Signed-off-by: Tomas Carnecky <tom@dbservice.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Reviewed-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>