Direct leak of 3 byte(s) in 1 object(s) allocated from:
 #0 0xb79e85d4 in __interceptor_malloc (/lib/i386-linux-gnu/libasan.so.5+0xeb5d4)
 #1 0xb770b635 in copystring /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:96
 #2 0xb770ba56 in _X11TransConnectDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:229
 #3 0xb776b4fd in XOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/OpenDis.c:215
 #4 0x63e2fd in nxagentInternalOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:608
 #5 0x63fa03 in nxagentOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:1140
 #6 0x694b5a in InitOutput /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Init.c:305
 #7 0x5f7b11 in main /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/dix/main.c:278
 #8 0xb6f04b40 in __libc_start_main ../csu/libc-start.c:308

I have not investigated the exact location where an XFree() was missing but added multiple
Xfree() calls whereever appropriate.

Fixes ArcticaProject/nx-libs#951

Fixes ArcticaProject/nx-libs#779

Backport of this commit:

  commit 7ba7085b4f01f3cd72008712a5333ea3f0edfd88
  Author: walter harms <wharms@bfs.de>
  Date:   Sat Oct 28 19:14:22 2017 +0200

    AuRead.c: remove redundant null check on calling free()

    this removes simply unneeded code from XauReadAuth
Signed-off-by: Walter Harms <wharms@bfs.de>
Reviewed-by: Daniel Martin <consume.noise@gmail.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

libXau is integrated into libNX_X11, but the differences to libXau
original code where not explicitly marked. This path adds some ifdefs
and also restores the original code.

Attributes to ArcticaProject/nx-libs#850

We have seen crashes during session shutdown/connection problems
here. These patches should avoid them. There's no proper way to test
them, but they should do no harm..

Fixes ArcticaProject/nx-libs#801
Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695

Fixes ArcticaProject/nx-libs#399

This fixes an assertion being triggered on reconnect:

assertion=assertion@entry=0x7f2f0bba6510 "(dpy->flags & XlibDisplayPrivSync) != 0", file=file@entry=0x7f2f0bba62fc "XlibInt.c", line=line@entry=895,

This commit is the only change between Xorg's libX11 1.6.6 and 1.6.7
that affects our code. So were are effectively now on par with libX11
1.6.7 (commit f3c978476e0be6813268af494efb7ac507451116)

  From: Bhavi Dhingra <b.dhingra@samsung.com>
  Date: Mon, 28 Sep 2015 08:33:40 +0000
  Subject: [PATCH] XcmsLookupColor: fully initialize XColor structs passed to
   _XColor_to_XcmsRGB

  Fixes https://gitlab.freedesktop.org/xorg/lib/libx11/issues/44
  aka https://bugs.freedesktop.org/show_bug.cgi?id=92154Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

We are at X.Org libX11 upstream commit 733f64b

Fixes: ArcticaProject/nx-libs #716, #719 and #720

 Xrm.c: In function 'PutEntry':
 Xrm.c:900:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     !quarks[2] != table->leaf)
               ^~