Reasoning:

(1) The diff between this file and mi/miwindow.c is so minimal, we simply
apply the change to mi/miwindow.c.

(2) In recent X.org, the fixed code has gone, so this patch won't exist
after having rebased nx-libs against X.org.

hw/nxagent/NXdamage.c: Shrink file, drop duplicate code that can identically be found in miext/damage/damage.c.

NXcomposite.h: Move fake header file NXcomposite.h to hw/nxagent/X11/include/ and drop all symbols that are not explicitly used by nxagent.

Xserver/hw/nxagent: Drop NXcompositeext.h, it is a duplicate of nx-X11/include/extensions/composite.h.

hw/nxagent/NXextension.c: Shrink file, drop duplicate code that is indentically found in dix/extension.c.

Attributes GH PR #156: https://github.com/ArcticaProject/nx-libs/pull/156

To allow for suspend/resume NX has changed _XReadEvents() and
_XIOError(). _XIOError() does not simply exit but returns. And
_XReadEvents() returns after _XIOError(). But as the original
_XReadEvents() is supposed to block until at least one event is there
calling functions are not prepared for situations where no event is
available. These calling functions have to check that condition.,

Some of the calling functions already had that check but the
UnlockDisplay() call was missing.

Fixes https://github.com/ArcticaProject/nx-libs/issues/118

Attributes GH PR #154: https://github.com/ArcticaProject/nx-libs/pull/154

arting with '#' will be ignored, and an empty message aborts

To allow for suspend/resume NX has changed _XReadEvents() and
_XIOError(). _XIOError() does not simply exit but returns. And
_XReadEvents() returns after _XIOError(). But as the original
_XReadEvents() is supposed to block until at least one event is there
calling functions are not prepared for situations where no event is
available. These calling functions have to check that condition.,

Some of the calling functions already had that check but the
UnlockDisplay() call was missing.

Fixes https://github.com/ArcticaProject/nx-libs/issues/118

Attributes GH PR #137: https://github.com/ArcticaProject/nx-libs/pull/137
Reviewed by: Ulrich Sibiller <uli42@gmx.de>  -- Mon, 20 Jun 2016 12:40:52 -0700

 Backported to X.org's /xorg/xserver Git hash level:
 a6b6e8ba026acedef6336b17adf06aebddd5f22f.

Move matrix operations from X server to pixman 0.13.2. Required code de-duplication in nxagent. (Will be fixed by ArcticaProject/nx-libs#120 later on).

[render] Split out filter finding from filter setting. Required code de-duplication in nxagent. (Will be fixed by ArcticaProject/nx-libs#120 later on).

Move matrix operations from X server to pixman 0.13.2, handle RandR transform matrices in floating point.

 Backported from X.org, inspired by:

 commit 9ffc6719390df8fdd0a5295a7a7a0eaea792be45
 Author: Keith Packard <keithp@keithp.com>
 Date:   Mon Nov 24 13:08:48 2008 -0800

    Move matrix operations from X server to pixman 0.13.2

    pixman 0.13.2 now holds all of the matrix operations. This leaves
    the protocol conversion routines and some ABI stubs in place
Signed-off-by: Keith Packard <keithp@keithp.com>

 commit c4b9ab6bf56139fdd8c7c584a6f523c6766cddd6
 Author: Keith Packard <keithp@keithp.com>
 Date:   Tue Apr 29 08:29:42 2008 -0700

    Handle transform failure when computing shadow damage area.

    PictureTransformBounds can fail, when this happens, damage the entire screen
    so that the shadow gets repainted correctly.

 commit fa6a1df209bd74da1d545982cca437afc2198cc1
 Author: Keith Packard <keithp@keithp.com>
 Date:   Fri Mar 21 02:35:28 2008 -0700

    Avoid overflow in PictureTransformPoint. Fix PictureTransformIsIdentity.

    PictureTransformPoint computes homogeneous coordinates internally, but fails
    to handle intermediate values larger than 16.16. Use 64 bit intermediate
    values while computing the final result at 16.16 and only complain if that
    result is too large.

    PictureTransformIsIdentity was completely wrong -- it was not checking for
    identity transforms at all.

 commit 49db14e4ac26070ed86088419483888dda18b603
 Author: Keith Packard <keithp@keithp.com>
 Date:   Wed Mar 19 00:46:35 2008 -0700

    Handle RandR transform matrices in floating point.

    RandR matrix computations lose too much precision in fixed point;
    computations using the inverted matrix can be as much as 10 pixels off.
    Convert them to double precision values and pass those around. These API
    changes are fairly heavyweight; the official Render interface remains fixed
    point, so the fixed point matrix comes along for the ride everywhere.

 commit 97ab0c6eff870b52c0383b63a78cec49059b2545
 Author: Keith Packard <keithp@keithp.com>
 Date:   Tue Mar 18 15:15:40 2008 -0700

    When converting from double to fixed, round carefully.

    This reduces the matrix representation error after inverting a
    transformation matrix (although it doesn't eliminate it entirely).

    Perhaps we should extend Render to include 64-bit floating point transforms...

 commit 160252d94f04acc95f0a4e0f884ff565a5aa0744
 Author: Keith Packard <keithp@keithp.com>
 Date:   Mon Mar 17 23:03:56 2008 -0700

    Add matrix inversion function (uses doubles)

    The obvious matrix inversion function, coded using doubles to avoid fiddling
    with fixed point precision adventures.

 commit ff9d1cd843a9b0aba69a3d788b21d5f6af702590
 Author: Keith Packard <keithp@keithp.com>
 Date:   Thu Mar 13 21:30:18 2008 -0700

    Add funcs to convert between protocol and pixman matrices

 commit f547650328287545a7a4d96df8d6a6c606dd95a9
 Author: Keith Packard <keithp@keithp.com>
 Date:   Thu Mar 13 14:50:13 2008 -0700

    Export a bunch of matrix operations from render.

    The render extension uses many matrix operations internally, this change
    exposes those functions to other parts of the server, drivers and
    extensions. The change is motivated by the 'transform' additions to the
    RandR extension but will likely be useful elsewhere.

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org, maybe incomplete, inspired by:

 commit 810fbfa44626bff9f443ab17c0ad27ff7ae121d7
 Author: Adam Jackson <ajax@redhat.com>
 Date:   Wed Feb 9 17:32:16 2011 -0500

    mi: Call pScreen->ConstrainCursorHarder from the position update path

    v2: Cover more paths, spotted by Daniel Stone.
    v3: pass down the mode field for movement mode.
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

dix/randr: add a hooks into screen to (a) replace scanout pixmap and (b) for additional cursor confinement

 Backported from X.org:

 commit c41922940adbc8891575b3321fadf01ff4cb5854
 Author: Dave Airlie <airlied@redhat.com>
 Date:   Tue Jun 26 10:00:21 2012 +0100

    dix/randr: add a hook into screen to replace scanout pixmap

    For DRI2 in some offload cases we need to set a new pixmap on the crtc,
    this hook allows dri2 to call into randr to do the necessary work to set
    a pixmap as the scanout pixmap for the crtc the drawable is currently on.

    This is really only to be used for unredirected full screen apps in composited
    environments.
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

 commit e65c3f8bcc86845f21ac575e2bfb4b21b67d5ebf
 Author: Adam Jackson <ajax@redhat.com>
 Date:   Wed Jan 5 12:04:19 2011 -0500

    dix: Add a Screen method for additional cursor confinement

    This just reserves the slot in the ABI. Confining cursors to CRTCs will
    come soon.

    v2: Just reserve the slot.
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Adam Jackson <ajax@redhat.com>

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org:

 commit 0df871cf34ee5f1a85586206027de9b02fb364ec
 Author: Robert Ancell <robert.ancell@canonical.com>
 Date:   Thu May 22 10:43:52 2014 +1200

    Fix overflow checking extension versions

    The easiest way to check for the version of an extension is to send the maximum
    possible version numbers in the QueryVersion request. The X server overflows on
    these as it assumes you will send a reasonable version number.
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Keith Packard <keithp@keithp.com>

 commit ffd4874798ba54f86acac75779a15b4babeaa5f3
 Author: Peter Hutterer <peter.hutterer@who-t.net>
 Date:   Wed May 11 12:20:50 2011 +1000

    include: add version_compare helper function

    Compare two version numbers in the major.minor form.
    Switch the few users of manual version switching over to the new function.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Jamey Sharp <jamey@minilop.net>

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org:

 commit acda790e430b2a18c7c35379f6e538f3d01ff221
 Author: Keith Packard <keithp@keithp.com>
 Date:   Fri Mar 14 13:46:30 2008 -0700

    [render] Split out filter finding from filter setting.

    To prepare for RandR using filters in transforms, split out
    code paths so that the RandR code can validate the filter name and
    parameters during the transform set operation so that use of the filter
    later will not have unreportable errors.

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

debian/patches-pending-evaluation: Adapt fix-icon-and-clipboard.patch to removal of the WindowTable array.

hw/nxagent/NXresource.c: remove caching of drawables and graphics contexts. The security checks simply bypass the cached values so they are unused. Required code de-duplication in nxagent. (Will be fixed by ArcticaProject/nx-libs#120 later on).

dix: remove caching of drawables and graphics contexts. The security checks simply bypass the cached values so they are unused.

 Backported from X.org:

 commit 9a183d7ba50e31afa133cc03aee7991517a283ea
 Author: Eamon Walsh <ewalsh@tycho.nsa.gov>
 Date:   Tue Aug 14 11:39:26 2007 -0400

    dix: remove caching of drawables and graphics contexts.  The security checks
    simply bypass the cached values so they are unused.

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org:

 commit e7fae9ecc42ab5e73b89117722dbf4117d928f9a
 Author: Jamey Sharp <jamey@minilop.net>
 Date:   Sat May 22 00:26:28 2010 -0700

    Move each screen's root-window pointer into ScreenRec.

    Many references to the WindowTable array already had the corresponding
    screen pointer handy, which meant they usually looked like
    "WindowTable[pScreen->myNum]". Adding a field to ScreenRec instead of
    keeping this information in a parallel array simplifies those
    expressions, and eliminates a MAXSCREENS-sized array.

    Since dix uses this data, a screen private entry isn't appropriate.

    xf86-video-dummy currently uses WindowTable, so it needs to be updated
    to reflect this change.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Tiago Vignatti <tiago.vignatti@nokia.com>
    Tested-by: Tiago Vignatti <tiago.vignatti@nokia.com> (i686 GNU/Linux)

 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Backported from X.org:

 commit 64ef7ed072007b1d0b4de5ff1e5eababa418c794
 Author: Adam Jackson <ajax@redhat.com>
 Date:   Wed Aug 20 13:14:03 2008 -0400

    Centralize declaration of ConnectionInfo.

Author: Adam Jackson <ajax@redhat.com>
Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

nxagent/hw/NXextension.c: Allow CloseDownProc to be NULL. Required code de-duplication in nxagent. (Will be fixed by ArcticaProject/nx-libs#120 later on).

 Backported from X.org:

 commit ae67508392261ae47858692668a0c192ef4a9d7b
 Author: Mathieu Bérard <mathieu.berard@crans.org>
 Date:   Fri Jul 25 10:05:30 2008 -0400

    Fix AddExtension now that CloseDownProc can be NULL.

 commit 6bcde69585fcc8f8dbfe81c115649f19274922fa
 Author: Adam Jackson <ajax@redhat.com>
 Date:   Thu Jul 24 09:13:26 2008 -0400

    Allow extension closedown hook to be null.

Authors: Adam Jackson <ajax@redhat.com>
         Mathieu Bérard <mathieu.berard@crans.org>
Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 The reformatting has been achieved by applying
 x-indent.sh to all .c and .h files in Xserver/randr/.

 sed -i "s/[ ]\+$//g" randr/*.{c,h}

 happy reviewing...
 git diff -w is an empty diff.

 This isn't used anywhere, not least because it's completely
 nonfunctional.
Reviewed-by: Mikhail Gusarov <dottedmag@dottedmag.net>
Signed-off-by: Adam Jackson <ajax@redhat.com>
 Backported-to-NX: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Properly enable/disable Xinerama support in nxagent via cmdline options provider in Xserver/os/utils.c.

  * Xinerama defaults to enabled, using RRXineramaExtension
    (i.e. cmdline option: +rrxinerama).
  * Cmdline option -rrxinerama disables Xinerama support entirely.
  * Cmdline option +xinerama switches from RRXineramaExtension to
    PanoramiXExtension.
  * Cmdline option -xinerama is actually non-functional (i.e. the
    default).
  * If the nx/nx option "xinerama" is handed over to nxagent,
    then Xinerama is only switched on if that given option enables it
    (value: 1) _and_ if either of the Xinerama extensions (PanoramiX
    or RRXinerama) has been initialized (via cmdline options above).

 Fixes ArcticaProject/nx-libs#117.
 Fixes ArcticaProject/nx-libs#134 (makes flawed PR#134 obsolete).