We have defined them, so use them!

for better readability

code cleanup

Attributes GH PR #378: https://github.com/ArcticaProject/nx-libs/pull/378

xf86bigfont.c: In function ‘ProcXF86BigfontQueryFont’:
xf86bigfont.c:724:9: warning: ‘pDesc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (!pDesc) free(pCI);

cursor.c: In function ‘TestForCursorName’:
cursor.c:649:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return (pCursor->name == (Atom) closure);
                              ^
cursor.c: In function ‘ProcXFixesChangeCursorByName’:
cursor.c:665:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  ReplaceCursor (pSource, TestForCursorName, (void *) name);
                                             ^

Backport of

   commit 019ad5acd20e34dc2aa3b89cc426138db5164c48
   Author: Eamon Walsh <ewalsh@tycho.nsa.gov>
   Date:   Tue Feb 5 15:44:41 2008 -0500

       XFixes: squash a pointer/integer size mismatch warning.

cursor.c: In function ‘ProcXFixesGetCursorName’:
cursor.c:399:6: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
  str = NameForAtom (pCursor->name);
      ^
cursor.c: In function ‘ProcXFixesGetCursorImageAndName’:
cursor.c:453:10: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
     name = pCursor->name ? NameForAtom (pCursor->name) : "";
          ^

Fixes

filter.c: In function ‘SetPicturePictFilter’:
filter.c:363:5: warning: ‘return’ with no value, in function returning non-void [enabled by default]
     return ;
     ^

record.c: In function ‘RecordAReply’:
record.c:714:7: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
       pri->replyData, pri->dataLenBytes, /* continuation */ -1);
       ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^
record.c:724:10: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
          pri->replyData, pri->dataLenBytes, pri->bytesRemaining);
          ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^
record.c:746:5: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
     pri->dataLenBytes, pri->bytesRemaining);
     ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^

fbtrap.c: In function ‘fbRasterizeTrapezoid’:
fbtrap.c:113:12: warning: variable ‘x_off_fixed’ set but not used [-Wunused-but-set-variable]
     xFixed x_off_fixed;

devices.c: In function ‘_AddInputDevice’:
devices.c:120:22: warning: assignment from incompatible pointer type [enabled by default]
     dev->devPrivates = dev->unwrapProc = NULL;

Fixes: ArcticaProject/nxlibs#389.

Attributes GH PR #372: https://github.com/ArcticaProject/nx-libs/pull/372

Fixes: ArcticaProject/nx-libs#371.

If no rules file is given, simply re-use the previous one. If no RF is given
the first time this function is called, use the built-in default.
This includes fixing the built-in default to something that actually exists.
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Fixes ArcticaProject/nx-libs#371

Attributes GH PR #380: https://github.com/ArcticaProject/nx-libs/pull/380

Fixes: ArcticaProject/nx-libs#365.

There might be some library linking missing on platforms that deliver
timingsafe_memcmp but I cannot test that here.

Fixes ArcticaProject/nx-libs#365

These two commits:

   commit 5c44169caed811e59a65ba346de1cadb46d266ec
   Author: Adam Jackson <ajax@redhat.com>
   Date:   Thu Mar 2 17:20:30 2017 -0500

       os: Squash missing declaration warning for timingsafe_memcmp

       timingsafe_memcmp.c:21:1: warning: no previous prototype for ‘timingsafe_memcmp’ [-Wmissing-prototypes]
        timingsafe_memcmp(const void *b1, const void *b2, size_t len)
Signed-off-by: Adam Jackson <ajax@redhat.com>

   commit d7ac755f0b618eb1259d93c8a16ec6e39a18627c
   Author: Matthieu Herrb <matthieu@herrb.eu>
   Date:   Tue Feb 28 19:18:25 2017 +0100

       Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

       Provide the function definition for systems that don't have it.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>

Attributes GH PR #359: https://github.com/ArcticaProject/nx-libs/pull/359

This is basically a backport of the following commits + replacing
xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.

   commit 2761c103311a1160bc483fd0367d654733df8598
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:03:26 2007 +0000

       OS: Remove usage of alloca

       Replace with heap allocations.

   commit 5e363500c86042c394595e1a6633581eb8fcd1bb
   Author: Daniel Stone <daniel@fooishbar.org>
   Date:   Mon Nov 5 14:38:28 2007 +0000

       OS: Remove ALLOCATE_LOCAL from os.h

       Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
       remove the include of Xalloca.h as well.

Attribute GH PR #369: https://github.com/ArcticaProject/nx-libs/pull/369

this was missing from the backport of
5623c27700b7b23a8dbbd8c8f45e5d4fa0c667e3 (Constify atom name strings)

XKB really XKBdoes not XKBneed its own XKBdefines for XKBeverything.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Signed-off-by: Keith Packard <keithp@keithp.com>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>