Skip to content

N
nx-libs
Switch branch/tag
  1. 04 Jul, 2016 9 commits
  3. 21 Jun, 2016 1 commit
  5. 17 Jun, 2016 1 commit
  7. 31 May, 2016 2 commits
  9. 27 Apr, 2016 2 commits
    • Salvador Fandino's avatar
      Provide support for channel endpoints being UNIX file sockets in addition to being TCP/IP sockets. · 3713346f
      Salvador Fandino authored
      3713346f
    • Fernando Carvajal's avatar
      Clean up compiler warnings in nxcomp · a436cba0
      Fernando Carvajal authored 
      This commit removes several warnings in nxcomp related to unused but
set variables. It also replaces tempnam function with the more secure
one mkstemp and there has been removed another warning related to
setgid and setuid returning values not being checked.

So these were the compiler warnings in nxcomp that have been fixed:

Loop.cpp: In function ‘int ParseRemoteOptions(char*)’:
Loop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable]
   int hasLimit  = 0;
       ^
Loop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable]
   int hasRender = 0;
       ^
Loop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable]
   int hasTaint  = 0;
       ^
Loop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable]
   int hasStrict = 0;
       ^
Loop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable]
   int hasShseg  = 0;
       ^
ServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’:
ServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable]
     int hit;
         ^
Proxy.o: In function `Proxy::handleSaveAllStores(char const*) const':
Proxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp'

Pipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’:
Pipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
       setgid(getgid());
                       ^
Pipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
       setuid(getuid());
                       ^

There was also a hidden problem in the way Proxy::handleSaveAllStores was
checking for an error in the returning value from the call to the virtual
method handleSaveAllStores of the specific proxy class really being used
(ClientProxy or ServerProxy).

Former code was considering the value 0 as the returning value in case of
an error whereas both subclasses return the value -1 when there is an error
in their handleSaveAllStores method.

This bug has been fixed in this commit taking advantage of the modification
that was already being made to this method in order to replace tempnam
function with the more secure one mkstemp.

Fixes: ArcticaProject/nx-libs#103
      a436cba0
  11. 12 Apr, 2016 1 commit
    • Fernando Carvajal's avatar
      Remove compatibility code for nxcomp before 3.5.0 · a9be6f59
      Fernando Carvajal authored 
      As a part of nxcomp's clean-up process, compatibility with old protocol
versions has been set now at 3.5.0.

This commit removes compatibility code from nxcomp so the minimum supported
version changes from 1.5.0 (protocol step 6) to 3.5.0 (protocol step 10).

At this moment the removal is not complete and it will be followed by some
other commits, in order to get rid of several components and files that are
no longer used as they were only needed to work with old protocol versions.

Refs: ArcticaProject/nx-libs#108
      a9be6f59
  13. 30 Dec, 2015 1 commit
  15. 28 Sep, 2015 2 commits
  17. 16 Jun, 2015 1 commit
  19. 20 May, 2015 1 commit
  21. 15 May, 2015 1 commit
    • Nito Martinez's avatar
      This patch allows to cleanup the nxcomp resources to allow for a second… · 4fefe352
      Nito Martinez authored 
      This patch allows to cleanup the nxcomp resources to allow for a second connection inside the same process, instead of a new process as is the nxproxy case.

This involves creating a new API call

void NXTransCleanupForReconnect(void);

which basically cleans up the global state for the connection but does not exit the process.

Background
==========
This is needed for the IOS platform, where the nxproxy model of forking does not work.
Also NX handles most of the errors with an "exit" call which in IOS cannot be easily handled.
      4fefe352
  23. 13 Feb, 2015 2 commits
  25. 10 Feb, 2015 4 commits
  27. 09 Feb, 2015 3 commits
  29. 28 Mar, 2013 2 commits
  31. 13 Nov, 2011 7 commits