Skip to content

N
nx-libs
Switch branch/tag
  1. 02 Nov, 2019 1 commit
    • Ulrich Sibiller's avatar
      NXglxext.c: use upstream versions of Dispatch functions · f3bddad4
      Ulrich Sibiller authored 
      instead of a full copy. We still have our own function because we
need to handle the nxagentGlxTrap. This trap is now set before the
start of the dispatcher while it has been set only directly before
calling the dispatched function.

Saves ~50 duplicated lines.
      f3bddad4
  3. 18 Jun, 2019 1 commit
    • Ulrich Sibiller's avatar
      glxext.c: fix another memory leak · bffdacc4
      Ulrich Sibiller authored 
      ==10226== 3,337 bytes in 1 blocks are definitely lost in loss record 295 of 307
==10226==    at 0x483577F: malloc (vg_replace_malloc.c:299)
==10226==    by 0x6281DB9: strdup (strdup.c:42)
==10226==    by 0x2ABA9E: __glXClientInfo (glxcmds.c:2170)
==10226==    by 0x17CA3E: __glXDispatch (NXglxext.c:128)
==10226==    by 0x16EE77: Dispatch (NXdispatch.c:476)
==10226==    by 0x14DCE0: main (main.c:353)

There's no point in trying to free cl->* after memset(0).

This one is a bug that is found identically in xorg upstream and has
only been fixed during rework of the whole client resource freeing
stuff. So we fix it in glxext.c.
      bffdacc4
  5. 28 Feb, 2019 1 commit
  7. 27 Dec, 2017 1 commit
  9. 14 Dec, 2017 3 commits
    • Mike Gabriel's avatar
      Xserver/GL/glx/glxcmds.c: Cast small-int values through intptr_t when passed as pointers · 8bb1579f
      Mike Gabriel authored 
       Picked from this X.org commit:

 commit b0dd6be2c8703f7062d45ac9fd646550c7d54e3b
 Author: Jamey Sharp <jamey@minilop.net>
 Date:   Thu Oct 8 13:38:44 2009 +1100

    Cast small-int values through intptr_t when passed as pointers

    On 64-bit systems, int and pointers don't have the same size, so GCC gives
    warnings about casts between int and pointer types. However, in the cases
    covered by this patch, it's always a value that fits in int being stored
    temporarily as a pointer and then converted back later, which is safe.
    Casting through the pointer-sized integer type intptr_t convinces the
    compiler that this is OK.
Signed-off-by: 's avatarJamey Sharp <jamey@minilop.net>
Signed-off-by: 's avatarDaniel Stone <daniel@fooishbar.org>
Backported-to-NX-by: 's avatarMike Gabriel <mike.gabriel@das-netzwerkteam.de>
 (Only appropriate location for backporting: Xserver/GL/glx/glxcmds.c).
      8bb1579f
    • Mike Gabriel's avatar
      glx: warning fixes · a6ffabda
      Mike Gabriel authored 
       commit 63ccaec2c39f4b5742383472c951ee2cd35c9e14
 Author: Adam Jackson <ajax@redhat.com>
 Date:   Tue Oct 19 11:59:23 2010 -0400

    render2.c: In function ‘__glXDisp_Map2d’:
    render2.c:127: warning: ‘u1’ may be used uninitialized in this function
    render2.c: In function ‘__glXDisp_Map1d’:
    render2.c:90: warning: ‘u1’ may be used uninitialized in this function

    Remove unnecessary test, and change memcpy to memmove as all users were
    doing overlapping copies.
Signed-off-by: 's avatarAdam Jackson <ajax@redhat.com>
Reviewed-by: 's avatarDaniel Stone <daniel@fooishbar.org>
Backported-to-NX-by: 's avatarMike Gabriel <mike.gabriel@das-netzwerkteam.de>
      a6ffabda
    • Mike Gabriel's avatar
      Xserver/GL/glx/glxfb.c: Fix compiler warning: pointer-sign. · 16fbdb2a
      Mike Gabriel authored 
       glxfb.c: In function '__glXFBMemSwapBuffers':
 glxfb.c:117:5: warning: pointer targets in passing argument 10 of 'pGC->ops->PutImage' differ in signedness [-Wpointer-sign]
      buf);
      ^~~
 glxfb.c:117:5: note: expected 'char *' but argument is of type 'GLubyte * {aka unsigned char *}'
      16fbdb2a
  11. 17 Nov, 2017 2 commits
  13. 15 Jun, 2017 1 commit
  15. 19 Apr, 2017 2 commits
  17. 03 Mar, 2017 1 commit
  19. 04 Dec, 2016 3 commits
  21. 17 Nov, 2016 1 commit
  23. 02 Nov, 2016 2 commits
  25. 31 Oct, 2016 1 commit
  27. 14 Oct, 2016 1 commit
  29. 05 Jul, 2016 4 commits
  31. 02 Jul, 2016 5 commits
  33. 24 Jun, 2016 2 commits
  35. 02 May, 2016 1 commit
  37. 28 Dec, 2015 2 commits
    • Mike Gabriel's avatar
      Clear header file namespace separation (<X11/...> vs. <nx-X11/...>). · 433d8186
      Mike Gabriel authored 
       In the process of building nxagent against more and more system-wide installed
 X.org libraries, we come to the limit of including structs from this (bundled
 nx-X11) and that (system-wide X.Org) library.

 This commit introduces a clear namespace separation of headers provided by
 nx-X11 and headers provided by X.Org. This approach is only temporary as we
 want to drop all nx-X11 bundled libraries from nx-libs.

 However, for a while we need to make this separation clear and also ship
 some reduced fake X.Org headers that avoid pulling in libX* and libNX_X*
 symbols at the same time.

 This patch has been tested on Debian jessie and unstable and requires no
 overall testing on various distros and distro versions, as we finally will
 drop all libNX_X* libraries and build against X.org's client libs.

 For now, this hack eases our development / cleanup process.
      433d8186
    • Keith Packard's avatar
      Replace 'pointer' type with 'void *' · 68dd0b52
      Keith Packard authored 
       This lets us stop using the 'pointer' typedef in Xdefs.h as 'pointer'
 is used throughout the X server for other things, and having duplicate
 names generates compiler warnings.
Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
Reviewed-by: 's avatarEric Anholt <eric@anholt.net>
 Rebased against NX: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
      68dd0b52
  39. 28 Sep, 2015 4 commits
  41. 21 Jun, 2015 1 commit