Skip to content

N
nx-libs
Switch branch/tag
  1. 31 May, 2015 1 commit
    • Mike DePaulo's avatar
      Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396] from… · c2298e07
      Mike DePaulo authored 
      Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396] from xorg/Xserver http://lists.x.org/archives/xorg-announce/2013-October/002332.html

Save a pointer to the passed in closure structure before copying it
and overwriting the *c pointer to point to our copy instead of the
original.  If we hit an error, once we free(c), reset c to point to
the original structure before jumping to the cleanup code that
references *c.

Since one of the errors being checked for is whether the server was
able to malloc(c->nChars * itemSize), the client can potentially pass
a number of characters chosen to cause the malloc to fail and the
error path to be taken, resulting in the read from freed memory.

Since the memory is accessed almost immediately afterwards, and the
X server is mostly single threaded, the odds of the free memory having
invalid contents are low with most malloc implementations when not using
memory debugging features, but some allocators will definitely overwrite
the memory there, leading to a likely crash.

v2: Apply to NXdixfonts.c rather than dixfonts.c (Mike DePaulo)
      c2298e07
  3. 29 May, 2015 1 commit
  5. 28 May, 2015 1 commit
  7. 26 May, 2015 3 commits
  9. 25 May, 2015 1 commit
  11. 24 May, 2015 2 commits
  13. 21 May, 2015 3 commits
  15. 20 May, 2015 2 commits
  17. 16 May, 2015 3 commits
  19. 15 May, 2015 6 commits
  21. 12 May, 2015 4 commits
  23. 04 May, 2015 3 commits
  25. 01 May, 2015 3 commits
  27. 30 Apr, 2015 4 commits
  29. 29 Apr, 2015 1 commit
  31. 28 Apr, 2015 2 commits
    • Mihai Moldovan's avatar
      libnx-xinerama1: also create libXinerama symlink in postinst (and remove in prerm.) · 83983e94
      Mihai Moldovan authored 
      Due to the nx-x11-common package being a noarch/allarch package,
creating the symlink in nx-libs' Makefile will lead to the symlink
referencing the "default" architecture dpkg uses for building
noarch/allarch packages.

Incidentally, this worked fine for Debian, as amd64 seems to be the
default architecture. On Ubuntu, however, the default architecture up to
Vivid (15.04) was i386. For those builds, the symlink pointed to the 32
bit library of libNX_Xinerama.so.1 -- essentially breaking this feature.

Move the symlink creation to the arch-sensitive libnx-xinerama1 package.
The postinst and prerm scriptlets will work fine, unless someone
installs the i386 package version *after* the amd64 version. Given that
we already create symlinks to libNX_X11 and friends using that method,
no new regression is introduced. Strictly speaking that's a bug, but
we'll hopefully clean that up later...
      83983e94
    • Mihai Moldovan's avatar
      Merge branch 'sunweaver-pr/imake-cleanup-nonpresent-buildlogic' into arctica-3.6.x · 7b7ba944
      Mihai Moldovan authored 
      Attributes GH PR #17: https://github.com/ArcticaProject/nx-libs/pull/17
      7b7ba944