1. 22 Jun, 2019 1 commit
    • Ulrich Sibiller's avatar
      record/set.c: silence cpp finding · b91b3d80
      Ulrich Sibiller authored
      [nx-X11/programs/Xserver/record/set.c:361]: (warning) Possible null pointer dereference: stackIntervals
      
      stackIntervals is only NULL if nIntervals is 0, too. In that case
      memcpy will do nothing and so it is ok to pass NULL as source. But it
      is ugly nevertheless...
      b91b3d80
  2. 28 Feb, 2019 1 commit
  3. 27 Feb, 2018 5 commits
  4. 19 Apr, 2017 1 commit
  5. 06 Apr, 2017 1 commit
    • Erkki Seppälä's avatar
      record: avoid crash when calling RecordFlushReplyBuffer recursively · c8a4e1e7
      Erkki Seppälä authored
      Backported from X.Org:
      
      commit 0801afbd7c2c644c672b37f8463f1a0cbadebd2e
      Author: Erkki Seppälä <erkki.seppala@vincit.fi>
      Date:   Thu Feb 10 15:35:14 2011 +0200
      
          record: avoid crash when calling RecordFlushReplyBuffer recursively
      
          RecordFlushReplyBuffer can call itself recursively through
          WriteClient->CallCallbacks->_CallCallbacks->RecordFlushAllContexts
          when the recording client's buffer cannot be completely emptied in one
          WriteClient. When a such a recursion occurs, it will not be broken out
          of which results in segmentation fault when the stack is exhausted.
      
          This patch adds a counter (a flag, really) that guards against this
          situation, to break out of the recursion.
      
          One alternative to this change would be to change _CallCallbacks to
          check the corresponding counter before the callback loop, but that
          might affect existing behavior, which may be relied upon.
      Reviewed-by: 's avatarRami Ylimäki <rami.ylimaki@vincit.fi>
      Signed-off-by: 's avatarErkki Seppälä <erkki.seppala@vincit.fi>
      Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
      Backported-to-NX-by: 's avatarMihai Moldovan <ionic@ionic.de>
      
      Fixes: ArcticaProject/nx-libs#417.
      c8a4e1e7
  6. 10 Mar, 2017 1 commit
    • Ulrich Sibiller's avatar
      record.c: fix compiler warnings · a9d4a454
      Ulrich Sibiller authored
      record.c: In function ‘RecordAReply’:
      record.c:714:7: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
             pri->replyData, pri->dataLenBytes, /* continuation */ -1);
             ^
      record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
       RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
       ^
      record.c:724:10: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
                pri->replyData, pri->dataLenBytes, pri->bytesRemaining);
                ^
      record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
       RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
       ^
      record.c:746:5: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
           pri->dataLenBytes, pri->bytesRemaining);
           ^
      record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
       RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
       ^
      a9d4a454
  7. 03 Mar, 2017 2 commits
    • Ulrich Sibiller's avatar
      replace (DE)ALLOCATE_LOCAL by malloc/free · 06bb154d
      Ulrich Sibiller authored
      This is basically a backport of the following commits + replacing
      xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.
      
         commit 2761c103311a1160bc483fd0367d654733df8598
         Author: Daniel Stone <daniel@fooishbar.org>
         Date:   Mon Nov 5 14:03:26 2007 +0000
      
             OS: Remove usage of alloca
      
             Replace with heap allocations.
      
         commit 5e363500c86042c394595e1a6633581eb8fcd1bb
         Author: Daniel Stone <daniel@fooishbar.org>
         Date:   Mon Nov 5 14:38:28 2007 +0000
      
             OS: Remove ALLOCATE_LOCAL from os.h
      
             Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
             remove the include of Xalloca.h as well.
      06bb154d
    • Ulrich Sibiller's avatar
      replace (DE)ALLOCATE_LOCAL by malloc/free · 09ef9991
      Ulrich Sibiller authored
      This is basically a backport of the following commits + replacing
      xalloc/xfree by malloc/free. Fixes ArcticaProject/nx-libs#358.
      
         commit 2761c103311a1160bc483fd0367d654733df8598
         Author: Daniel Stone <daniel@fooishbar.org>
         Date:   Mon Nov 5 14:03:26 2007 +0000
      
             OS: Remove usage of alloca
      
             Replace with heap allocations.
      
         commit 5e363500c86042c394595e1a6633581eb8fcd1bb
         Author: Daniel Stone <daniel@fooishbar.org>
         Date:   Mon Nov 5 14:38:28 2007 +0000
      
             OS: Remove ALLOCATE_LOCAL from os.h
      
             Remove ALLOCATE_LOCAL_FALLBACK and DEALLOCATE_LOCAL_FALLBACK from os.h, and
             remove the include of Xalloca.h as well.
      09ef9991
  8. 04 Dec, 2016 1 commit
  9. 02 Nov, 2016 1 commit
  10. 31 Oct, 2016 1 commit
  11. 05 Jul, 2016 4 commits
  12. 04 Jul, 2016 1 commit
    • Mike Gabriel's avatar
      Use internal temp variable for swap macros. Make swaps/swapl type safe… · 286d8326
      Mike Gabriel authored
      Use internal temp variable for swap macros. Make swaps/swapl type safe (introducing wrong_size check at build time).
      
       While working on this changeset, various spots got discovered where
       swapl or swaps was used on a wrong type, where byte swapping calls had
       been forgotten or done on the wrong variable.
      
       This backport at least includes changes from the following X.org
       commits, listed in non-chronological order:
      
       commit 2c7c520cfe0df30f4bc3adba59d9c62582823bf8
       Author: Matt Turner <mattst88@gmail.com>
       Date:   Thu Aug 4 15:35:41 2011 -0400
      
          Use internal temp variable for swap macros
      
          Also, fix whitespace, mainly around
              swaps(&rep.sequenceNumber)
      Reviewed-by: 's avatarPeter Harris <pharris@opentext.com>
      Signed-off-by: 's avatarMatt Turner <mattst88@gmail.com>
      
       commit 9edcae78c46286baff42e74bfe26f6ae4d00fe01
       Author: Matt Turner <mattst88@gmail.com>
       Date:   Wed Sep 21 17:14:16 2011 -0400
      
          Use correct swap{l,s} (or none at all for CARD8)
      
          Swapping the wrong size was never caught because swap{l,s} are macros.
      
          It's clear in the case of Xext/xres.c, that the author believed
          client_major/minor to be CARD16 from looking at the code in the first
          hunk.
      
          v2: dmx.c fixes from Keith.
      Reviewed-by: 's avatarPeter Harris <pharris@opentext.com>
      Signed-off-by: 's avatarMatt Turner <mattst88@gmail.com>
      
       commit dab064fa5e0b1f5c67222562ad5367005832cba1
       Author: Andrea Canciani <ranma42@gmail.com>
       Date:   Tue Nov 2 20:10:32 2010 +0100
      
          render: Fix byteswapping of gradient stops
      
          The function swapStops repeatedly swaps the color components as
          CARD16, but incorrectly steps over them as if they were CARD32.
      
          This causes half of the stops not to be swapped at all and some
          unrelated data be swapped instead.
      Signed-off-by: 's avatarAndrea Canciani <ranma42@gmail.com>
      Reviewed-by: 's avatarSoren Sandmann <sandmann@daimi.au.dk>
      Reviewed-by: 's avatarJulien Cristau <jcristau@debian.org>
      Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
      
       commit 54770c980cd2b91a8377f975a58ed69def5cfa42
       Author: Matt Turner <mattst88@gmail.com>
       Date:   Tue Aug 16 16:59:07 2011 -0400
      
          Cast char* buffers to swap functions
      Reviewed-by: 's avatarPeter Harris <pharris@opentext.com>
      Signed-off-by: 's avatarMatt Turner <mattst88@gmail.com>
      
       commit 6844bd2e63490870bab3c469eec6030354ef2865
       Author: Alan Coopersmith <alan.coopersmith@sun.com>
       Date:   Wed Jan 9 19:52:00 2008 -0800
      
          More Xv extension byte swapping fixes
      
       commit e46f6ddeccd082b2d507a1e8b57ea30e6b0a2c83
       Author: Michel Dänzer <michel@tungstengraphics.com>
       Date:   Wed Jan 16 14:24:22 2008 +0100
      
          Yet another Xv extension byte swapping fix.
      286d8326
  13. 02 Jul, 2016 6 commits
  14. 02 May, 2016 1 commit
  15. 28 Dec, 2015 2 commits
    • Mike Gabriel's avatar
      Clear header file namespace separation (<X11/...> vs. <nx-X11/...>). · 433d8186
      Mike Gabriel authored
       In the process of building nxagent against more and more system-wide installed
       X.org libraries, we come to the limit of including structs from this (bundled
       nx-X11) and that (system-wide X.Org) library.
      
       This commit introduces a clear namespace separation of headers provided by
       nx-X11 and headers provided by X.Org. This approach is only temporary as we
       want to drop all nx-X11 bundled libraries from nx-libs.
      
       However, for a while we need to make this separation clear and also ship
       some reduced fake X.Org headers that avoid pulling in libX* and libNX_X*
       symbols at the same time.
      
       This patch has been tested on Debian jessie and unstable and requires no
       overall testing on various distros and distro versions, as we finally will
       drop all libNX_X* libraries and build against X.org's client libs.
      
       For now, this hack eases our development / cleanup process.
      433d8186
    • Keith Packard's avatar
      Replace 'pointer' type with 'void *' · 68dd0b52
      Keith Packard authored
       This lets us stop using the 'pointer' typedef in Xdefs.h as 'pointer'
       is used throughout the X server for other things, and having duplicate
       names generates compiler warnings.
      Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
      Reviewed-by: 's avatarEric Anholt <eric@anholt.net>
       Rebased against NX: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
      68dd0b52
  16. 10 Oct, 2011 2 commits