NXwindow.c:265:27: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 10 [-Wformat-overflow=]
       sprintf(artsd_port,"%d", nPort);
                           ^~
NXwindow.c:265:26: note: directive argument in the range [-2147476648, 2147483647]
       sprintf(artsd_port,"%d", nPort);
                          ^~~~
NXwindow.c:265:7: note: ‘sprintf’ output between 2 and 12 bytes into a destination of size 10
       sprintf(artsd_port,"%d", nPort);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We are not using any alloc function that respects that variable, so
lets drop it. Backport of this commit:

  commit 0ce61e21d6d7dcca0090e319bbcdb678570f2c3f
  Author: Adam Jackson <ajax@redhat.com>
  Date:   Fri Oct 3 16:05:19 2008 -0400

    Remove the Must_have_memory hack.

    Also remove an astonishing amount of misunderstanding of how casts work.

Attributes GH PR #814: https://github.com/ArcticaProject/nx-libs/pull/814

Attributes GH PR #812: https://github.com/ArcticaProject/nx-libs/pull/812

The only left function is identical to the one in mi/miexpose.c.

We do not even know what theme this is and it is probably not relevant
nowadays.

miPaintWindow() was identical to the version in miexpose.c except
for some unitialized variable fixes. As these also should be in
upstream code we add them there (Note: Xorg never fixed this but
totally rewrote the miPaintWindow() later on.)

This allows us to totally drop our special version of miPaintWindow().

It is (functionally) identical to our code, so why have
duplicate code?

Attributes GH PR #813: https://github.com/ArcticaProject/nx-libs/pull/813

Attributes GH PR #810: https://github.com/ArcticaProject/nx-libs/pull/810

Not sure how it came to this situation, but the following commit is
partly contained in our version of the code. Some lines had not been
removed, tough...

  commit c80c41767eb101e9dbd8393d8cca7764b4e248a4
  Author: Aaron Plattner <aplattner@nvidia.com>
  Date:   Mon Oct 25 22:01:32 2010 -0700

    os: Fix BigReq ignoring when another request is pending

    Commit cf88363db0ebb42df7cc286b85d30d7898aea840 fixed the handling of
    BigReq requests that are way too large and handles the case where the
    read() syscall returns a short read.  However, it neglected to handle
    the case where it returns a long read, which happens when the client
    has another request in the queue after the bogus large one.

    Handle the long read case by subtracting the smaller of 'needed' and
    'gotnow' from oci->ignoreBytes.  If needed < gotnow, simply subtract
    the two, leaving gotnow equal to the number of extra bytes read.
    Since the code immediately following the (oci->ignoreBytes > 0) block
    tries to handle the next request, advance oci->bufptr immediately
    instead of setting oci->lenLastReq and letting the next call to
    ReadRequestFromClient do it.

    Fixes the XTS pChangeKeyboardMapping-3 test.

             CASES TESTS  PASS UNSUP UNTST NOTIU  WARN   FIP  FAIL UNRES  UNIN ABORT
    -Xproto    122   389   367     2    19     0     0     0     1     0     0     0
    +Xproto    122   389   368     2    19     0     0     0     0     0     0     0
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Keith Packard <keithp@keithp.com>

was missing in 8b5bb2cd

CheckMotion() had been commented in
add88193 as it looked identical to the
version from dix/events.c except for some commented code. But this
based (probably) on a thinko - code that had been disabled by NX
became active again this way. Fix this by removing the comments and
by adding #ifdef/else to emphasize the difference.

Attributes GH PR #811: https://github.com/ArcticaProject/nx-libs/pull/811

As done in these commits:

  commit 6583477035234e23ead2fad9db7a07e5862447a4
  Author: Nicolai Hähnle <nhaehnle@gmail.com>
  Date:   Sat May 23 13:35:24 2009 +0200

    Remove reference to non-existing requestLog and requestLogIndex

    These fields were removed in 252ec504817e05b185e4896a2d899e9c00b8aeef.
Signed-off-by: Nicolai Haehnle <nhaehnle@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

  commit 252ec504817e05b185e4896a2d899e9c00b8aeef
  Author: Adam Jackson <ajax@redhat.com>
  Date:   Mon Mar 30 15:18:30 2009 -0400

    Document which bits of ClientRec are currently unused

Attributes GH PR #809: https://github.com/ArcticaProject/nx-libs/pull/809

We have seen crashes during session shutdown/connection problems
here. These patches should avoid them. There's no proper way to test
them, but they should do no harm..

Fixes ArcticaProject/nx-libs#801
Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695

Fixes ArcticaProject/nx-libs#808

Attributes GH PR #806: https://github.com/ArcticaProject/nx-libs/pull/806

Fixes ArcticaProject/nx-libs#807.

This file has been deleted, but references to it in the build remain,
causing `debuild` to fail.

Attributes GH PR #797: https://github.com/ArcticaProject/nx-libs/pull/797

nxagent does not react on that anyway (see xkb/xkbDflts.h)