Skip to content

N
nx-libs
Switch branch/tag
  1. 22 Oct, 2018 1 commit
  3. 25 Aug, 2017 1 commit
  5. 19 Oct, 2016 2 commits
    • Ulrich Sibiller's avatar
      Align files with upstream libX11-1.6.0 · e2e45b2b
      Ulrich Sibiller authored 
      This commit looks a bit crazy at first glance. It (re-)introduces lots
of whitespaces and bad formatting.

Explanation: Backporting upstream changes lead to commits being
applied out of order. This meant a lot of manual intervention which in
turn lead to slight differences between upstream and NX.

With this commit these slight differences are minimized which will be
of great help when adding further upstream patches.
      e2e45b2b
    • Erkki Seppälä's avatar
      cmsProp: don't deal with uninitialized values, fail instead · 07fae919
      Erkki Seppälä authored 
      Properly handle the return value of XGetWindowProperty by considering
if after the loop as well.

Using freed pointer "prop_ret"

There were numerous things wrong in how this function interacted with
XGetWindowProperty.

None of the local variables were initialized and remained that way if
the call to XGetWindowProperty returned 1 (not Succeed). That doesn't
result in after_ret being initialized in which case if it happens to
be 0, the loop was exited. In that case format_ret and nitems_ret were
uninitialized and the function might return with success (but with
uninitialized pointer in prop_ret) or XcmsFailure.

As the buffer enlarging code was called only when XGetWindowProperty
failed (returned not Success), after_ret would not have been
initialized. It would have been initialized only if the
XGetWindowProperty has returned Success earlier, but in that case the
code fragment would not have been reached.

This patch alters the function to return XcmsFailure if the call to
XGetWindowProperty fails.
Reviewed-by: 's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: 's avatarAnder Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
Reviewed-by: 's avatarRami Ylimäki <rami.ylimaki@vincit.fi>
Signed-off-by: 's avatarErkki Seppälä <erkki.seppala@vincit.fi>
Backported-to-NX-by: 's avatarUlrich Sibiller <uli42@gmx.de>
      07fae919
  7. 10 Oct, 2016 2 commits
  9. 05 Jul, 2016 1 commit
  11. 28 Dec, 2015 1 commit
    • Mike Gabriel's avatar
      Clear header file namespace separation (<X11/...> vs. <nx-X11/...>). · 433d8186
      Mike Gabriel authored 
       In the process of building nxagent against more and more system-wide installed
 X.org libraries, we come to the limit of including structs from this (bundled
 nx-X11) and that (system-wide X.Org) library.

 This commit introduces a clear namespace separation of headers provided by
 nx-X11 and headers provided by X.Org. This approach is only temporary as we
 want to drop all nx-X11 bundled libraries from nx-libs.

 However, for a while we need to make this separation clear and also ship
 some reduced fake X.Org headers that avoid pulling in libX* and libNX_X*
 symbols at the same time.

 This patch has been tested on Debian jessie and unstable and requires no
 overall testing on various distros and distro versions, as we finally will
 drop all libNX_X* libraries and build against X.org's client libs.

 For now, this hack eases our development / cleanup process.
      433d8186
  13. 10 Oct, 2011 2 commits