Do not use map before calling parse_keystroke_file() since it will malloc map.

Correctly use constant for unused structs instead of implicitly
setting it through calloc().

Unclear why they have been merged at all.

Code could not distinguish between ctrl-alt-shift and ctrl-alt.

Fixes ArcticaProject/nx-libs#395

Both use the same keystroke 'f' (with different modifiers) for a very
similar function.

We have defined them, so use them!

for better readability

code cleanup

Attributes GH PR #378: https://github.com/ArcticaProject/nx-libs/pull/378

xf86bigfont.c: In function ‘ProcXF86BigfontQueryFont’:
xf86bigfont.c:724:9: warning: ‘pDesc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (!pDesc) free(pCI);

cursor.c: In function ‘TestForCursorName’:
cursor.c:649:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return (pCursor->name == (Atom) closure);
                              ^
cursor.c: In function ‘ProcXFixesChangeCursorByName’:
cursor.c:665:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  ReplaceCursor (pSource, TestForCursorName, (void *) name);
                                             ^

Backport of

   commit 019ad5acd20e34dc2aa3b89cc426138db5164c48
   Author: Eamon Walsh <ewalsh@tycho.nsa.gov>
   Date:   Tue Feb 5 15:44:41 2008 -0500

       XFixes: squash a pointer/integer size mismatch warning.

cursor.c: In function ‘ProcXFixesGetCursorName’:
cursor.c:399:6: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
  str = NameForAtom (pCursor->name);
      ^
cursor.c: In function ‘ProcXFixesGetCursorImageAndName’:
cursor.c:453:10: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
     name = pCursor->name ? NameForAtom (pCursor->name) : "";
          ^

Fixes

filter.c: In function ‘SetPicturePictFilter’:
filter.c:363:5: warning: ‘return’ with no value, in function returning non-void [enabled by default]
     return ;
     ^

record.c: In function ‘RecordAReply’:
record.c:714:7: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
       pri->replyData, pri->dataLenBytes, /* continuation */ -1);
       ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^
record.c:724:10: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
          pri->replyData, pri->dataLenBytes, pri->bytesRemaining);
          ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^
record.c:746:5: warning: passing argument 4 of ‘RecordAProtocolElement’ discards ‘const’ qualifier from pointer target type [enabled by default]
     pri->dataLenBytes, pri->bytesRemaining);
     ^
record.c:286:1: note: expected ‘void *’ but argument is of type ‘const void *’
 RecordAProtocolElement(RecordContextPtr pContext, ClientPtr pClient,
 ^

fbtrap.c: In function ‘fbRasterizeTrapezoid’:
fbtrap.c:113:12: warning: variable ‘x_off_fixed’ set but not used [-Wunused-but-set-variable]
     xFixed x_off_fixed;

devices.c: In function ‘_AddInputDevice’:
devices.c:120:22: warning: assignment from incompatible pointer type [enabled by default]
     dev->devPrivates = dev->unwrapProc = NULL;