BugMail.pm 29.5 KB
Newer Older
1
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
2
#
3 4 5 6 7 8 9 10 11 12
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
13
# The Original Code is the Bugzilla Bug Tracking System.
14
#
terry%netscape.com's avatar
terry%netscape.com committed
15
# The Initial Developer of the Original Code is Netscape Communications
16 17 18 19
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
20
# Contributor(s): Terry Weissman <terry@mozilla.org>,
21 22
#                 Bryce Nesbitt <bryce-mozilla@nextbus.com>
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Alan Raetz <al_raetz@yahoo.com>
24
#                 Jacob Steenhagen <jake@actex.net>
25
#                 Matthew Tuck <matty@chariot.net.au>
26 27
#                 Bradley Baetz <bbaetz@student.usyd.edu.au>
#                 J. Paul Reed <preed@sigkill.com>
28

29
use strict;
terry%netscape.com's avatar
terry%netscape.com committed
30

31
package Bugzilla::BugMail;
terry%netscape.com's avatar
terry%netscape.com committed
32

33
use Bugzilla::RelationSet;
34

35
use Bugzilla::Config qw(:DEFAULT $datadir);
36
use Bugzilla::Util;
37

38 39 40 41
# This code is really ugly. It was a commandline interface, then it was moved
# There are package-global variables which we rely on ProcessOneBug to clean
# up each time, and other sorts of fun.
# This really needs to be cleaned at some point.
42

43
my $nametoexclude = "";
44
my %nomail;
45
my $last_changed;
46

47 48 49 50 51
my @excludedAddresses = ();

# disable email flag for offline debugging work
my $enableSendMail = 1;

52
my %force;
terry%netscape.com's avatar
terry%netscape.com committed
53

54
my %seen;
55 56
my @sentlist;

57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
# I got sick of adding &:: to everything.
# However, 'Yuck!'
# I can't require, cause that pulls it in only once, so it won't then be
# in the global package, and these aren't modules, so I can't use globals.pl
# Remove this evilness once our stuff uses real packages.
sub AUTOLOAD {
    no strict 'refs';
    use vars qw($AUTOLOAD);
    my $subName = $AUTOLOAD;
    $subName =~ s/.*::/::/; # remove package name
    *$AUTOLOAD = \&$subName;
    goto &$AUTOLOAD;
}

# This is run when we load the package
72
if (open(NOMAIL, '<', "$datadir/nomail")) {
73 74 75 76 77 78 79
    while (<NOMAIL>) {
        $nomail{trim($_)} = 1;
    }
    close(NOMAIL);
}


80 81 82 83
sub FormatTriple {
    my ($a, $b, $c) = (@_);
    $^A = "";
    my $temp = formline << 'END', $a, $b, $c;
84
^>>>>>>>>>>>>>>>>>>|^<<<<<<<<<<<<<<<<<<<<<<<<<<<|^<<<<<<<<<<<<<<<<<<<<<<<<<<<~~
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100
END
    ; # This semicolon appeases my emacs editor macros. :-)
    return $^A;
}
    
sub FormatDouble {
    my ($a, $b) = (@_);
    $a .= ":";
    $^A = "";
    my $temp = formline << 'END', $a, $b;
^>>>>>>>>>>>>>>>>>> ^<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<~~
END
    ; # This semicolon appeases my emacs editor macros. :-)
    return $^A;
}

101 102 103 104 105 106 107 108 109 110 111 112
# This is a bit of a hack, basically keeping the old system()
# cmd line interface. Should clean this up at some point.
#
# args: bug_id, and an optional hash ref which may have keys for:
# changer, owner, qa, reporter, cc
# Optional hash contains values of people which will be forced to those
# roles when the email is sent.
# All the names are email addresses, not userids
# values are scalars, except for cc, which is a list
sub Send($;$) {
    my ($id, $recipients) = (@_);

113
    # This only works in a sub. Probably something to do with the
114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
    # require abuse we do.
    GetVersionTable();

    # Make sure to clean up _all_ package vars here. Yuck...
    $nametoexclude = $recipients->{'changer'} || "";
    @{$force{'CClist'}} = (exists $recipients->{'cc'} && 
     scalar($recipients->{'cc'}) > 0) ? map(trim($_), 
     @{$recipients->{'cc'}}) : ();
    @{$force{'Owner'}} = $recipients->{'owner'} ? 
     (trim($recipients->{'owner'})) : ();
    @{$force{'QAcontact'}} = $recipients->{'qacontact'} ? 
     (trim($recipients->{'qacontact'})) : ();
    @{$force{'Reporter'}} = $recipients->{'reporter'} ? 
     (trim($recipients->{'reporter'})) : ();
    @{$force{'Voter'}} = ();

    %seen = ();
    @excludedAddresses = ();
    @sentlist = ();

    return ProcessOneBug($id);
}

sub ProcessOneBug($) {
138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
    my ($id) = (@_);

    my @headerlist;
    my %values;
    my %defmailhead;
    my %fielddescription;

    my $msg = "";

    SendSQL("SELECT name, description, mailhead FROM fielddefs " .
            "ORDER BY sortkey");
    while (MoreSQLData()) {
        my ($field, $description, $mailhead) = (FetchSQLData());
        push(@headerlist, $field);
        $defmailhead{$field} = $mailhead;
        $fielddescription{$field} = $description;
    }
    SendSQL("SELECT " . join(',', @::log_columns) . ", lastdiffed, now() " .
            "FROM bugs WHERE bug_id = $id");
    my @row = FetchSQLData();
    foreach my $i (@::log_columns) {
        $values{$i} = shift(@row);
    }
161 162 163
    $values{product} = get_product_name($values{product_id});
    $values{component} = get_component_name($values{component_id});

164
    my ($start, $end) = (@row);
165
    # $start and $end are considered safe because users can't touch them
166 167
    trick_taint($start);
    trick_taint($end);
168

169
    my $ccSet = new Bugzilla::RelationSet();
170 171
    $ccSet->mergeFromDB("SELECT who FROM cc WHERE bug_id = $id");
    $values{'cc'} = $ccSet->toString();
172
    
173
    my @voterList;
174 175 176
    SendSQL("SELECT profiles.login_name FROM votes, profiles " .
            "WHERE votes.bug_id = $id AND profiles.userid = votes.who");
    while (MoreSQLData()) {
177
        push(@voterList, FetchOneColumn());
178
    }
179 180 181 182 183 184

    $values{'assigned_to'} = DBID_to_name($values{'assigned_to'});
    $values{'reporter'} = DBID_to_name($values{'reporter'});
    if ($values{'qa_contact'}) {
        $values{'qa_contact'} = DBID_to_name($values{'qa_contact'});
    }
185
    $values{'estimated_time'} = FormatTimeUnit($values{'estimated_time'});
186

187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202
    my @dependslist;
    SendSQL("SELECT dependson FROM dependencies WHERE 
             blocked = $id ORDER BY dependson");
    while (MoreSQLData()) {
        push(@dependslist, FetchOneColumn());
    }
    $values{'dependson'} = join(",", @dependslist);

    my @blockedlist;
    SendSQL("SELECT blocked FROM dependencies WHERE 
             dependson = $id ORDER BY blocked");
    while (MoreSQLData()) {
        push(@blockedlist, FetchOneColumn());
    }
    $values{'blocked'} = join(",", @blockedlist);

203 204 205 206
    my @diffs;


    SendSQL("SELECT profiles.login_name, fielddefs.description, " .
207
            "       bug_when, removed, added, attach_id, fielddefs.name " .
208 209 210 211 212 213 214 215 216 217 218 219 220 221 222
            "FROM bugs_activity, fielddefs, profiles " .
            "WHERE bug_id = $id " .
            "  AND fielddefs.fieldid = bugs_activity.fieldid " .
            "  AND profiles.userid = who " .
            "  AND bug_when > '$start' " .
            "  AND bug_when <= '$end' " .
            "ORDER BY bug_when"
            );

    while (MoreSQLData()) {
        my @row = FetchSQLData();
        push(@diffs, \@row);
    }

    my $difftext = "";
223 224
    my $diffheader = "";
    my @diffparts;
225 226
    my $lastwho = "";
    foreach my $ref (@diffs) {
227
        my ($who, $what, $when, $old, $new, $attachid, $fieldname) = (@$ref);
228
        my $diffpart = {};
229 230
        if ($who ne $lastwho) {
            $lastwho = $who;
231 232 233
            $diffheader = "\n$who" . Param('emailsuffix') . " changed:\n\n";
            $diffheader .= FormatTriple("What    ", "Removed", "Added");
            $diffheader .= ('-' x 76) . "\n";
234
        }
235
        $what =~ s/^(Attachment )?/Attachment #$attachid / if $attachid;
236 237 238 239 240 241 242 243 244 245
        if( $fieldname eq 'estimated_time' ||
            $fieldname eq 'remaining_time' ) {
            $old = FormatTimeUnit($old);
            $new = FormatTimeUnit($new);
        }
        $difftext = FormatTriple($what, $old, $new);
        $diffpart->{'header'} = $diffheader;
        $diffpart->{'fieldname'} = $fieldname;
        $diffpart->{'text'} = $difftext;
        push(@diffparts, $diffpart);
246 247 248
    }


249 250
    my $deptext = "";

251
    SendSQL("SELECT bugs_activity.bug_id, bugs.short_desc, fielddefs.name, " .
252
            "       removed, added " .
253
            "FROM bugs_activity, bugs, dependencies, fielddefs ".
254
            "WHERE bugs_activity.bug_id = dependencies.dependson " .
255
            "  AND bugs.bug_id = bugs_activity.bug_id ".
256 257 258 259 260 261 262 263 264 265 266
            "  AND dependencies.blocked = $id " .
            "  AND fielddefs.fieldid = bugs_activity.fieldid" .
            "  AND (fielddefs.name = 'bug_status' " .
            "    OR fielddefs.name = 'resolution') " .
            "  AND bug_when > '$start' " .
            "  AND bug_when <= '$end' " .
            "ORDER BY bug_when, bug_id");
    
    my $thisdiff = "";
    my $lastbug = "";
    my $interestingchange = 0;
267 268
    my $depbug = 0;
    my @depbugs;
269
    while (MoreSQLData()) {
270 271 272
        my ($summary, $what, $old, $new);
        ($depbug, $summary, $what, $old, $new) = (FetchSQLData());
        if ($depbug ne $lastbug) {
273 274 275
            if ($interestingchange) {
                $deptext .= $thisdiff;
            }
276
            $lastbug = $depbug;
277
            my $urlbase = Param("urlbase");
278
            $thisdiff =
279 280 281
              "\nBug $id depends on bug $depbug, which changed state.\n\n" . 
              "Bug $depbug Summary: $summary\n" . 
              "${urlbase}show_bug.cgi?id=$depbug\n\n"; 
282 283 284 285 286 287 288 289
            $thisdiff .= FormatTriple("What    ", "Old Value", "New Value");
            $thisdiff .= ('-' x 76) . "\n";
            $interestingchange = 0;
        }
        $thisdiff .= FormatTriple($fielddescription{$what}, $old, $new);
        if ($what eq 'bug_status' && IsOpenedState($old) ne IsOpenedState($new)) {
            $interestingchange = 1;
        }
290 291
        
        push(@depbugs, $depbug);
292
    }
293
    
294 295 296 297 298 299 300
    if ($interestingchange) {
        $deptext .= $thisdiff;
    }

    $deptext = trim($deptext);

    if ($deptext) {
301 302
        my $diffpart = {};
        $diffpart->{'text'} = "\n" . trim("\n\n" . $deptext);
303
        push(@diffparts, $diffpart);
304 305 306
    }


307
    my ($newcomments, $anyprivate) = GetLongDescriptionAsText($id, $start, $end);
308

309 310 311 312
    #
    # Start of email filtering code
    #
    my $count = 0;
313

314 315 316 317
    # Get a list of the reasons a user might receive email about the bug.
    my @currentEmailAttributes = 
      getEmailAttributes(\%values, \@diffs, $newcomments);
    
318
    my (@assigned_toList,@reporterList,@qa_contactList,@ccList) = ();
319

320 321 322
    #open(LOG, ">>/tmp/maillog");
    #print LOG "\nBug ID: $id   CurrentEmailAttributes:";
    #print LOG join(',', @currentEmailAttributes) . "\n";
323

324
    @excludedAddresses = (); # zero out global list 
325

326 327 328 329 330 331 332 333 334 335 336 337 338
    @assigned_toList = filterEmailGroup('Owner',
                                        \@currentEmailAttributes,
                                        $values{'assigned_to'});
    @reporterList = filterEmailGroup('Reporter', 
                                     \@currentEmailAttributes,
                                     $values{'reporter'});
    if (Param('useqacontact') && $values{'qa_contact'}) {
        @qa_contactList = filterEmailGroup('QAcontact',
                                           \@currentEmailAttributes,
                                           $values{'qa_contact'});
    } else { 
        @qa_contactList = (); 
    }
339

340 341
    @ccList = filterEmailGroup('CClist', \@currentEmailAttributes,
                               $values{'cc'});
342

343 344
    @voterList = filterEmailGroup('Voter', \@currentEmailAttributes,
                                  join(',',@voterList));
345

346
    my @emailList = (@assigned_toList, @reporterList, 
347
                     @qa_contactList, @ccList, @voterList);
348

349 350 351
    # only need one entry per person
    my @allEmail = ();
    my %AlreadySeen = ();
352
    my $checkperson = "";
353
    foreach my $person (@emailList) {
354 355 356 357
        # don't modify the original so it sends out with the right case
        # based on who came first.
        $checkperson = lc($person);
        if ( !($AlreadySeen{$checkperson}) ) {
358
            push(@allEmail,$person);
359
            $AlreadySeen{$checkperson}++;
360
        }
361
    }
362

363 364 365 366
    #print LOG "\nbug $id email sent: " . join(',', @allEmail) . "\n";
        
    @excludedAddresses = filterExcludeList(\@excludedAddresses,
                                           \@allEmail);
367

368 369 370
    # print LOG "excluded: " . join(',',@excludedAddresses) . "\n\n";

    foreach my $person ( @allEmail ) {
371 372
        my @reasons;

373
        $count++;
374 375 376

        push(@reasons, 'AssignedTo') if lsearch(\@assigned_toList, $person) != -1;
        push(@reasons, 'Reporter') if lsearch(\@reporterList, $person) != -1;
377
        push(@reasons, 'QAcontact') if lsearch(\@qa_contactList, $person) != -1;
378 379 380
        push(@reasons, 'CC') if lsearch(\@ccList, $person) != -1;
        push(@reasons, 'Voter') if lsearch(\@voterList, $person) != -1;

381
        if ( !defined(NewProcessOnePerson($person, $count, \@headerlist,
382 383
                                          \@reasons, \%values,
                                          \%defmailhead, 
384 385 386
                                          \%fielddescription, \@diffparts,
                                          $newcomments, 
                                          $anyprivate, $start, $id, 
387 388
                                          \@depbugs))) 
        {
389 390 391 392 393 394

            # if a value is not returned, this means that the person
            # was not sent mail.  add them to the excludedAddresses list.
            # it will be filtered later for dups.
            #
            push @excludedAddresses, $person;
395 396

        }
397
    }
398

399

400 401
    SendSQL("UPDATE bugs SET lastdiffed = '$end', delta_ts = delta_ts " .
            "WHERE bug_id = $id");
402 403 404 405 406

    # Filter the exclude list for dupes one last time
    @excludedAddresses = filterExcludeList(\@excludedAddresses,
                                           \@sentlist);

407
    return { sent => \@sentlist, excluded => \@excludedAddresses };
408
}
409

410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
# When one person is in different fields on one bug, they may be
# excluded from email because of one relationship to the bug (eg
# they're the QA contact) but included because of another (eg they
# also reported the bug).  Inclusion takes precedence, so this
# function looks for and removes any users from the exclude list who
# are also on the include list.  Additionally, it removes duplicate
# entries from the exclude list.  
#
# Arguments are the exclude list and the include list; the cleaned up
# exclude list is returned.
#
sub filterExcludeList ($$) {

    if ($#_ != 1) {
        die ("filterExcludeList called with wrong number of args");
    }

    my ($refExcluded, $refAll) = @_;

    my @excludedAddrs = @$refExcluded;
    my @allEmail = @$refAll;
    my @tmpList = @excludedAddrs;
    my (@result,@uniqueResult) = ();
    my %alreadySeen;

    foreach my $excluded (@tmpList) {

        push (@result,$excluded);
        foreach my $included (@allEmail) {

            # match found, so we remove the entry
441
            if (lc($included) eq lc($excluded)) {
442
                pop(@result);
443
                last;
444 445 446 447 448
            }
        }
    }

    # only need one entry per person
449 450
    my $checkperson = "";

451
    foreach my $person (@result) {
452 453
        $checkperson = lc($person);
        if ( !($alreadySeen{$checkperson}) ) {
454
            push(@uniqueResult,$person);
455
            $alreadySeen{$checkperson}++;
456 457 458 459 460 461 462 463 464
        }
    }

    return @uniqueResult;
}

# if the Status was changed to Resolved or Verified
#       set the Resolved flag
#
465
# else if Severity, Status, Target Milestone OR Priority fields have any change
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482
#       set the Status flag
#
# else if Keywords has changed
#       set the Keywords flag
#
# else if CC has changed
#       set the CC flag
#
# if the Comments field shows an attachment
#       set the Attachment flag
#
# else if Comments exist
#       set the Comments flag
#
# if no flags are set and there was some other field change
#       set the Status flag
#
483
sub getEmailAttributes (\%\@$) {
484
    
485
    my ($bug, $fieldDiffs, $commentField) = @_;
486 487
    my (@flags,@uniqueFlags,%alreadySeen) = ();
    
488 489 490 491 492 493
    # Add a flag if the status of the bug is "unconfirmed".
    if ($bug->{'bug_status'} eq $::unconfirmedstate) {
        push (@flags, 'Unconfirmed')
    };
    
    foreach my $ref (@$fieldDiffs) {
494 495 496 497
        my ($who, $fieldName, $when, $old, $new) = (@$ref);
        
        #print qq{field: $fieldName $new<br>};
        
498
        # the STATUS will be flagged for Severity, Status, Target Milestone and 
499 500
        # Priority changes
        #
501 502
        if ( $fieldName eq 'Status' && ($new eq 'RESOLVED' || $new eq 'VERIFIED')) {
            push (@flags, 'Resolved');
503 504
        }
        elsif ( $fieldName eq 'Severity' || $fieldName eq 'Status' ||
505
                $fieldName eq 'Priority' || $fieldName eq 'Target Milestone') {
506 507 508 509 510 511
            push (@flags, 'Status');
        } elsif ( $fieldName eq 'Keywords') {
            push (@flags, 'Keywords');
        } elsif ( $fieldName eq 'CC') {
            push (@flags, 'CC');
        }
512

513 514 515 516
        # These next few lines find out who has been added
        # to the Owner, QA, CC, etc. fields.  They do not affect
        # the @flags array at all, but are run here because they
        # affect filtering later and we're already in the loop.
517
        if ($fieldName eq 'AssignedTo') {
518
            push (@{$force{'Owner'}}, $new);
519
        } elsif ($fieldName eq 'QAcontact') {
520
           push (@{$force{'QAcontact'}}, $new);
521
        } elsif ($fieldName eq 'CC') {
522
            my @added = split (/[ ,]/, $new);
523 524
            push (@{$force{'CClist'}}, @added);
        }
525 526 527 528 529
    }
    
    if ( $commentField =~ /Created an attachment \(/ ) {
        push (@flags, 'Attachments');
    }
530
    elsif ( ($commentField ne '') && !(scalar(@flags) == 1 && $flags[0] eq 'Resolved')) {
531 532 533 534
        push (@flags, 'Comments');
    }
    
    # default fallthrough for any unflagged change is 'Other'
535
    if ( @flags == 0 && @$fieldDiffs != 0 ) {
536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556
        push (@flags, 'Other');
    }
    
    # only need one flag per attribute type
    foreach my $flag (@flags) {
        if ( !($alreadySeen{$flag}) ) {
            push(@uniqueFlags,$flag);
            $alreadySeen{$flag}++;
        }
    }
    #print "\nEmail Attributes: ", join(' ,',@uniqueFlags), "<br>\n";
    
    # catch-all default, just in case the above logic is faulty
    if ( @uniqueFlags == 0) {
        push (@uniqueFlags, 'Comments');
    }
    
    return @uniqueFlags;
}

sub filterEmailGroup ($$$) {
557
    # This function figures out who should receive email about the bug
558
    # based on the user's role with respect to the bug (assignee, reporter, 
559
    # etc.), the changes that occurred (new comments, attachment added, 
560
    # status changed, etc.) and the user's email preferences.
561
    
562 563 564
    # Returns a filtered list of those users who would receive email
    # about these changes, and adds the names of those users who would
    # not receive email about them to the global @excludedAddresses list.
565
    
566 567 568 569 570 571
    my ($role, $reasons, $users) = @_;
    
    # Make a list of users to filter.
    my @users = split( /,/ , $users );
    
    # Treat users who are in the process of being removed from this role
572
    # as if they still have it.
573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
    push @users, @{$force{$role}};

    # If this installation supports user watching, add to the list those
    # users who are watching other users already on the list.  By doing
    # this here, we allow watchers to inherit the roles of the people 
    # they are watching while at the same time filtering email for watchers
    # based on their own preferences.
    if (Param("supportwatchers") && scalar(@users)) {
        # Convert the unfiltered list of users into an SQL-quoted, 
        # comma-separated string suitable for use in an SQL query.
        my $watched = join(",", map(SqlQuote($_), @users));
        SendSQL("SELECT watchers.login_name 
                   FROM watch, profiles AS watchers, profiles AS watched
                  WHERE watched.login_name IN ($watched)
                    AND watched.userid = watch.watched
                    AND watch.watcher = watchers.userid");
        push (@users, FetchOneColumn()) while MoreSQLData();
590 591
    }

592 593
    # Initialize the list of recipients.
    my @recipients = ();
594

595 596
    USER: foreach my $user (@users) {
        next unless $user;
597
        
598 599 600 601
        # Get the user's unique ID, and if the user is not registered
        # (no idea why unregistered users should even be on this list,
        # but the code that was here before I re-wrote it allows this),
        # then we do not have any preferences for them, so assume the
602
        # default preference is to receive all mail.
603 604 605
        my $userid = DBname_to_id($user);
        if (!$userid) {
            push(@recipients, $user);
606 607 608
            next;
        }
        
609 610 611
        # Get the user's email preferences from the database.
        SendSQL("SELECT emailflags FROM profiles WHERE userid = $userid");
        my $prefs = FetchOneColumn();
612
        
613 614 615 616
        # If the user's preferences are empty, it means the user has not set
        # their mail preferences after the installation upgraded from a
        # version of Bugzilla without email preferences to one with them. In
        # this case, assume they want to receive all mail.
617 618 619 620
        if (!defined($prefs) || $prefs !~ /email/) {
            push(@recipients, $user);
            next;
        }
621
        
622 623 624 625 626 627 628 629 630 631
        # Write the user's preferences into a Perl record indexed by 
        # preference name.  We pass the value "255" to the split function 
        # because otherwise split will trim trailing null fields, causing 
        # Perl to generate lots of warnings.  Any suitably large number 
        # would do.
        my %prefs = split(/~/, $prefs, 255);
        
        # If this user is the one who made the change in the first place,
        # and they prefer not to receive mail about their own changes,
        # filter them from the list.
632
        if (lc($user) eq lc($nametoexclude) && $prefs{'ExcludeSelf'} eq 'on') {
633 634
            push(@excludedAddresses, $user);
            next;
635 636
        }
        
637 638 639 640 641 642 643 644 645 646 647 648
        # If the user doesn't want to receive email about unconfirmed
        # bugs, that setting overrides their other preferences, including
        # the preference to receive email when they are added to or removed
        # from a role, so remove them from the list before checking their
        # other preferences.
        if (grep(/Unconfirmed/, @$reasons)
            && exists($prefs{"email${role}Unconfirmed"})
            && $prefs{"email${role}Unconfirmed"} eq '')
        {
            push(@excludedAddresses, $user);
            next;
        }
649
        
650 651 652 653 654 655 656 657 658 659
        # If the user was added to or removed from this role, and they
        # prefer to receive email when that happens, send them mail.
        # Note: This was originally written to send email when users
        # were removed from roles and was later enhanced for additions,
        # but for simplicity's sake the name "Removeme" was retained.
        if (grep($_ eq $user, @{$force{$role}})
            && $prefs{"email${role}Removeme"} eq 'on')
        {
            push (@recipients, $user);
            next;
660
        }
661 662 663 664 665 666 667 668 669 670 671
        
        # If the user prefers to be included in mail about this change,
        # or they haven't specified a preference for it (because they
        # haven't visited the email preferences page since the preference
        # was added, in which case we include them by default), add them
        # to the list of recipients.
        foreach my $reason (@$reasons) {
            my $pref = "email$role$reason";
            if (!exists($prefs{$pref}) || $prefs{$pref} eq 'on') {
                push(@recipients, $user);
                next USER;
672
            }
673 674 675 676 677 678 679
        }
    
        # At this point there's no way the user wants to receive email
        # about this change, so exclude them from the list of recipients.
        push(@excludedAddresses, $user);
    
    } # for each user on the unfiltered list
680

681
    return @recipients;
682 683
}

684
sub NewProcessOnePerson ($$$$$$$$$$$$$) {
685 686 687
    my ($person, $count, $hlRef, $reasonsRef, $valueRef, $dmhRef, $fdRef,  
        $diffRef, $newcomments, $anyprivate, $start, 
        $id, $depbugsRef) = @_;
688

689 690
    my %values = %$valueRef;
    my @headerlist = @$hlRef;
691
    my @reasons = @$reasonsRef;
692 693
    my %defmailhead = %$dmhRef;
    my %fielddescription = %$fdRef;
694
    my @diffparts = @$diffRef;
695 696
    my @depbugs = @$depbugsRef;
    
697 698 699
    if ($seen{$person}) {
      return;
    }
700 701 702 703

    if ($nomail{$person}) {
      return;
    }
704

705 706 707
    # This routine should really get passed a userid
    # This rederives groups as a side effect
    my $user = Bugzilla::User->new_from_login($person);
708 709 710
    if (!$user) { # person doesn't exist, probably changed email
      return;
    }
711
    my $userid = $user->id;
712

713
    $seen{$person} = 1;
714

715 716 717
    # if this person doesn't have permission to see info on this bug, 
    # return.
    #
718
    # XXX - This currently means that if a bug is suddenly given
719 720 721 722
    # more restrictive permissions, people without those permissions won't
    # see the action of restricting the bug itself; the bug will just 
    # quietly disappear from their radar.
    #
723
    return unless $user->can_see_bug($id);
724 725

    #  Drop any non-insiders if the comment is private
726
    return if (Param("insidergroup") && 
727
               ($anyprivate != 0) && 
728
               (!$user->groups->{Param("insidergroup")}));
729

730
    # We shouldn't send changedmail if this is a dependency mail, and any of 
731
    # the depending bugs are not visible to the user.
732 733 734 735
    foreach my $dep_id (@depbugs) {
        my $save_id = $dep_id;
        detaint_natural($dep_id) || warn("Unexpected Error: \@depbugs contains a non-numeric value: '$save_id'")
                                 && return;
736
        return unless $user->can_see_bug($dep_id);
737 738
    }

739 740 741 742 743 744 745
    my %mailhead = %defmailhead;
    
    my $head = "";
    
    foreach my $f (@headerlist) {
      if ($mailhead{$f}) {
        my $value = $values{$f};
746 747
        # If there isn't anything to show, don't include this header
        if (! $value) {
748 749
          next;
        }
750
        # Only send estimated_time if it is enabled and the user is in the group
751
        if ($f ne 'estimated_time' ||
752 753
            $user->groups->{Param('timetrackinggroup')}) {

754 755 756
            my $desc = $fielddescription{$f};
            $head .= FormatDouble($desc, $value);
        }
757 758
      }
    }
759 760 761 762 763

    # Build difftext (the actions) by verifying the user should see them
    my $difftext = "";
    my $diffheader = "";
    my $add_diff;
764

765 766 767
    foreach my $diff (@diffparts) {
        $add_diff = 0;
        
768 769 770 771
        if (exists($diff->{'fieldname'}) && 
         ($diff->{'fieldname'} eq 'estimated_time' ||
         $diff->{'fieldname'} eq 'remaining_time' ||
         $diff->{'fieldname'} eq 'work_time')) {
772
            if ($user->groups->{Param("timetrackinggroup")}) {
773 774 775 776 777
                $add_diff = 1;
            }
        } else {
            $add_diff = 1;
        }
778

779
        if ($add_diff) {
780 781
            if (exists($diff->{'header'}) && 
             ($diffheader ne $diff->{'header'})) {
782 783 784 785 786 787
                $diffheader = $diff->{'header'};
                $difftext .= $diffheader;
            }
            $difftext .= $diff->{'text'};
        }
    }
788
 
789 790 791 792 793
    if ($difftext eq "" && $newcomments eq "") {
      # Whoops, no differences!
      return;
    }
    
794
    my $reasonsbody = "------- You are receiving this mail because: -------\n";
795 796 797 798 799 800 801 802 803

    if (scalar(@reasons) == 0) {
        $reasonsbody .= "Whoops!  I have no idea!\n";
    } else {
        foreach my $reason (@reasons) {
            if ($reason eq 'AssignedTo') {
                $reasonsbody .= "You are the assignee for the bug, or are watching the assignee.\n";
            } elsif ($reason eq 'Reporter') {
                $reasonsbody .= "You reported the bug, or are watching the reporter.\n";
804
            } elsif ($reason eq 'QAcontact') {
805 806 807 808 809 810 811 812 813 814 815
                $reasonsbody .= "You are the QA contact for the bug, or are watching the QA contact.\n";
            } elsif ($reason eq 'CC') {
                $reasonsbody .= "You are on the CC list for the bug, or are watching someone who is.\n";
            } elsif ($reason eq 'Voter') {
                $reasonsbody .= "You are a voter for the bug, or are watching someone who is.\n";
            } else {
                $reasonsbody .= "Whoops!  There is an unknown reason!\n";
            }
        }
    }

816 817 818
    my $isnew = ($start !~ m/[1-9]/);
    
    my %substs;
819

820 821 822 823 824 825
    # If an attachment was created, then add an URL. (Note: the 'g'lobal
    # replace should work with comments with multiple attachments.)

    if ( $newcomments =~ /Created an attachment \(/ ) {

        my $showattachurlbase =
826
            Param('urlbase') . "attachment.cgi?id=";
827

828
        $newcomments =~ s/(Created an attachment \(id=([0-9]+)\))/$1\n --> \(${showattachurlbase}$2&action=view\)/g;
829 830
    }

831
    $person .= Param('emailsuffix');
832 833 834 835 836
# 09/13/2000 cyeh@bluemartini.com
# If a bug is changed, don't put the word "Changed" in the subject mail
# since if the bug didn't change, you wouldn't be getting mail
# in the first place! see http://bugzilla.mozilla.org/show_bug.cgi?id=29820 
# for details.
837
    $substs{"neworchanged"} = $isnew ? ' New: ' : '';
838 839 840 841 842 843 844 845 846
    $substs{"to"} = $person;
    $substs{"cc"} = '';
    $substs{"bugid"} = $id;
    if ($isnew) {
      $substs{"diffs"} = $head . "\n\n" . $newcomments;
    } else {
      $substs{"diffs"} = $difftext . "\n\n" . $newcomments;
    }
    $substs{"summary"} = $values{'short_desc'};
847 848
    $substs{"reasonsheader"} = join(" ", @reasons);
    $substs{"reasonsbody"} = $reasonsbody;
849
    $substs{"space"} = " ";
850 851 852 853
    
    my $template = Param("newchangedmail");
    
    my $msg = PerformSubsts($template, \%substs);
854 855 856

    my $sendmailparam = "-ODeliveryMode=deferred";
    if (Param("sendmailnow")) {
857
       $sendmailparam = "";
858
    }
859 860

    if ($enableSendMail == 1) {
861 862
        open(SENDMAIL, "|/usr/lib/sendmail $sendmailparam -t -i") ||
          die "Can't open sendmail";
863
    
864 865
        print SENDMAIL trim($msg) . "\n";
        close SENDMAIL;
866
    }
867
    push(@sentlist, $person);
868
    return 1;
869 870
}

871
1;