002goodperl.t 4.64 KB
Newer Older
1 2 3 4 5 6
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
7

8 9 10 11 12

#################
#Bugzilla Test 2#
####GoodPerl#####

13
use 5.10.1;
14
use strict;
15
use warnings;
16

17 18 19 20
use lib 't';

use Support::Files;

21 22 23
use Test::More tests =>
  (scalar(@Support::Files::testitems) + scalar(@Support::Files::test_files))
  * 6;
24

25
my @testitems     = (@Support::Files::test_files, @Support::Files::testitems);
26
my @require_taint = qw(email_in.pl importxml.pl mod_perl.pl whine.pl);
27 28

foreach my $file (@testitems) {
29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
  $file =~ s/\s.*$//;    # nuke everything after the first space (#comment)
  next if (!$file);      # skip null entries
  if (!open(FILE, $file)) {
    ok(0, "could not open $file --WARNING");
  }
  my $file_line1 = <FILE>;
  close(FILE);

  $file =~ m/.*\.(.*)/;
  my $ext = $1;

  if ($file_line1 !~ m/^#\!/) {
    ok(1, "$file does not have a shebang");
  }
  else {
    my $flags;
    if (!defined $ext || $ext eq "pl") {

      # standalone programs aren't taint checked yet
      if (grep { $file eq $_ } @require_taint) {
        $flags = 'T';
      }
      else {
        $flags = '';
      }
54
    }
55 56 57
    elsif ($ext eq "pm") {
      ok(0, "$file is a module, but has a shebang");
      next;
58
    }
59
    elsif ($ext eq "cgi") {
60

61 62
      # cgi files must be taint checked
      $flags = 'T';
63
    }
64 65 66
    else {
      ok(0, "$file has shebang but unknown extension");
      next;
67 68
    }

69 70 71 72 73 74 75 76 77 78 79 80
    if ($file_line1 =~ m#^\#\!/usr/bin/perl(?:\s-(\w+))?$#) {
      my $file_flags = $1 || '';
      if ($flags eq $file_flags) {
        ok(1,
          "$file uses standard perl location" . ($flags ? " and -$flags flag" : ""));
      }
      elsif ($flags) {
        ok(0, "$file is MISSING -$flags flag --WARNING");
      }
      else {
        ok(0, "$file has unexpected -$file_flags flag --WARNING");
      }
81
    }
82 83
    else {
      ok(0, "$file uses non-standard perl location");
84
    }
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
  }
}

foreach my $file (@testitems) {
  my $found_use_perl     = 0;
  my $found_use_strict   = 0;
  my $found_use_warnings = 0;

  $file =~ s/\s.*$//;    # nuke everything after the first space (#comment)
  next if (!$file);      # skip null entries
  if (!open(FILE, $file)) {
    ok(0, "could not open $file --WARNING");
    next;
  }
  while (my $file_line = <FILE>) {
    $found_use_perl     = 1 if $file_line =~ m/^\s*use 5.10.1/;
    $found_use_strict   = 1 if $file_line =~ m/^\s*use strict/;
    $found_use_warnings = 1 if $file_line =~ m/^\s*use warnings/;
    last if ($found_use_perl && $found_use_strict && $found_use_warnings);
  }
  close(FILE);
  if ($found_use_perl) {
    ok(1, "$file requires Perl 5.10.1");
  }
  else {
    ok(0, "$file DOES NOT require Perl 5.10.1 --WARNING");
  }

  if ($found_use_strict) {
    ok(1, "$file uses strict");
  }
  else {
    ok(0, "$file DOES NOT use strict --WARNING");
  }

  if ($found_use_warnings) {
    ok(1, "$file uses warnings");
  }
  else {
    ok(0, "$file DOES NOT use warnings --WARNING");
  }
126 127
}

128 129
# Check to see that all error messages use tags (for l10n reasons.)
foreach my $file (@testitems) {
130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
  $file =~ s/\s.*$//;    # nuke everything after the first space (#comment)
  next if (!$file);      # skip null entries
  if (!open(FILE, $file)) {
    ok(0, "could not open $file --WARNING");
    next;
  }
  my $lineno = 0;
  my $error  = 0;

  while (!$error && (my $file_line = <FILE>)) {
    $lineno++;
    if ($file_line =~ /Throw.*Error\("(.*?)"/) {
      if ($1 =~ /\s/) {
        ok(
          0, "$file has a Throw*Error call on line $lineno 
                      which doesn't use a tag --ERROR"
        );
        $error = 1;
      }
149
    }
150 151 152 153 154
  }

  ok(1, "$file uses Throw*Error calls correctly") if !$error;

  close(FILE);
155
}
156 157 158

# Forbird the { foo => $cgi->param() } syntax, for security reasons.
foreach my $file (@testitems) {
159 160 161 162 163 164 165 166 167 168 169 170 171 172
  $file =~ s/\s.*$//;    # nuke everything after the first space (#comment)
  next unless $file;     # skip null entries
  if (!open(FILE, $file)) {
    ok(0, "could not open $file --WARNING");
    next;
  }
  my $lineno = 0;
  my @unsafe_args;

  while (my $file_line = <FILE>) {
    $lineno++;
    $file_line =~ s/^\s*(.+)\s*$/$1/;    # Remove leading and trailing whitespaces.
    if ($file_line =~ /^[^#]+=> \$cgi\->param/) {
      push(@unsafe_args, "$file_line on line $lineno");
173
    }
174 175 176 177 178 179 180 181 182 183 184 185
  }

  if (@unsafe_args) {
    ok(0,
      "$file incorrectly passes a CGI argument to a hash --ERROR\n"
        . join("\n", @unsafe_args));
  }
  else {
    ok(1, "$file has no vulnerable hash syntax");
  }

  close(FILE);
186 187
}

188
exit 0;