Commit 0066e681 authored by bugreport%peshkin.net's avatar bugreport%peshkin.net

Bug 233486: Only process groups user is supposed to be able to bless in editgroups.cgi

r=justdave a=justdave
parent dbce51e8
......@@ -155,7 +155,7 @@ sub EmitFormElements ($$$$)
print "<TD COLSPAN=2 ALIGN=LEFT><B>User is a member of these groups</B></TD>\n";
while (MoreSQLData()) {
my ($groupid, $name, $description, $checked, $isderived, $isregexp) = FetchSQLData();
next if (!$editall && !UserCanBlessGroup($name));
next unless ($editall || UserCanBlessGroup($name));
PushGlobalSQLState();
SendSQL("SELECT user_id " .
"FROM user_group_map " .
......@@ -762,6 +762,7 @@ if ($action eq 'update') {
my $chggrp = 0;
SendSQL("SELECT id, name FROM groups");
while (my ($groupid, $name) = FetchSQLData()) {
next unless ($editall || UserCanBlessGroup($name));
if ($::FORM{"oldgroup_$groupid"} != ($::FORM{"group_$groupid"} ? 1 : 0)) {
# group membership changed
PushGlobalSQLState();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment