Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
1f700c4d
Commit
1f700c4d
authored
Jan 12, 2000
by
terry%mozilla.org
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Was making changes to bugs before validating the entries in the CC
field. This caused mid-air collisions and other weirdnesses.
parent
09035a15
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
19 additions
and
9 deletions
+19
-9
process_bug.cgi
process_bug.cgi
+19
-9
No files found.
process_bug.cgi
View file @
1f700c4d
...
...
@@ -248,6 +248,24 @@ if (defined $::FORM{'qa_contact'}) {
ConnectToDatabase
();
my
%
ccids
;
my
$origcclist
=
""
;
# We make sure to check out the CC list before we actually start touching any
# bugs.
if
(
defined
$::FORM
{
'cc'
}
&&
defined
$::FORM
{
'id'
})
{
$origcclist
=
ShowCcList
(
$::FORM
{
'id'
});
if
(
$origcclist
ne
$::FORM
{
'cc'
})
{
foreach
my
$person
(
split
(
/[ ,]/
,
$::FORM
{
'cc'
}))
{
if
(
$person
ne
""
)
{
my
$cid
=
DBNameToIdAndCheck
(
$person
);
$ccids
{
$cid
}
=
1
;
}
}
}
}
if
(
Param
(
'strictvaluechecks'
)
)
{
CheckFormFieldDefined
(
\%::
FORM
,
'knob'
);
}
...
...
@@ -573,15 +591,7 @@ The changes made were:
AppendComment
(
$id
,
$::FORM
{
'who'
},
$::FORM
{
'comment'
});
}
if
(
defined
$::FORM
{
'cc'
}
&&
ShowCcList
(
$id
)
ne
$::FORM
{
'cc'
})
{
my
%
ccids
;
foreach
my
$person
(
split
(
/[ ,]/
,
$::FORM
{
'cc'
}))
{
if
(
$person
ne
""
)
{
my
$cid
=
DBNameToIdAndCheck
(
$person
);
$ccids
{
$cid
}
=
1
;
}
}
if
(
defined
$::FORM
{
'cc'
}
&&
$origcclist
ne
$::FORM
{
'cc'
})
{
SendSQL
(
"delete from cc where bug_id = $id"
);
foreach
my
$ccid
(
keys
%
ccids
)
{
SendSQL
(
"insert into cc (bug_id, who) values ($id, $ccid)"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment