Skip to content

bugzilla
bugzilla
Commit 26b0e4cf authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org
Browse files
Options

Bug 529416: (CVE-2009-3386) [SECURITY] Dependency lists display bug aliases even…

Bug 529416: (CVE-2009-3386) [SECURITY] Dependency lists display bug aliases even for bugs the user cannot access Patch by Dave Miller <justdave@bugzilla.org> r=LpSolit, r=mkanat, a=mkanat
parent c0c052e3
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
Bugzilla/Template.pm
View file @ 26b0e4cf
......@@ -348,10 +348,6 @@ sub get_bug_link {
$bug = blessed($bug) ? $bug : new Bugzilla::Bug($bug);
return $link_text if $bug->{error};
if ($options->{use_alias} && $link_text =~ /^\d+$/ && $bug->alias) {
$link_text = $bug->alias;
}
# Initialize these variables to be "" so that we don't get warnings
# if we don't change them below (which is highly likely).
my ($pre, $title, $post) = ("", "", "");
......@@ -369,6 +365,9 @@ sub get_bug_link {
}
if (Bugzilla->user->can_see_bug($bug)) {
$title .= " - " . $bug->short_desc;
if ($options->{use_alias} && $link_text =~ /^\d+$/ && $bug->alias) {
$link_text = $bug->alias;
}
}
# Prevent code injection in the title.
$title = html_quote(clean_text($title));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment