Commit 2c01ae87 authored by Frédéric Buclin's avatar Frédéric Buclin

Bug 650624: Changing the requestee of a flag should not change the requester

a=LpSolit
parent 973bdab8
...@@ -602,8 +602,6 @@ sub force_retarget { ...@@ -602,8 +602,6 @@ sub force_retarget {
sub _set_requestee { sub _set_requestee {
my ($self, $requestee, $attachment, $skip_requestee_on_error) = @_; my ($self, $requestee, $attachment, $skip_requestee_on_error) = @_;
# Used internally to check if the requestee is retargetting the request.
$self->{_old_requestee_id} = $self->requestee ? $self->requestee->id : 0;
$self->{requestee} = $self->{requestee} =
$self->_check_requestee($requestee, $attachment, $skip_requestee_on_error); $self->_check_requestee($requestee, $attachment, $skip_requestee_on_error);
...@@ -725,9 +723,9 @@ sub _check_setter { ...@@ -725,9 +723,9 @@ sub _check_setter {
old_status => $self->{_old_status} }); old_status => $self->{_old_status} });
} }
# If the requester is retargetting the request, we don't # If the request is being retargetted, we don't update
# update the setter, so that the setter gets the notification. # the setter, so that the setter gets the notification.
if ($status eq '?' && $self->{_old_requestee_id} == $setter->id) { if ($status eq '?' && $self->{_old_status} eq '?') {
return $self->setter; return $self->setter;
} }
return $setter; return $setter;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment