Skip to content

bugzilla
bugzilla
Commit 38fac175 authored by myk%mozilla.org's avatar myk%mozilla.org
Browse files
Options

Fix for bug 155700: detaints bug ID in ValidateBugID so it doesn't fail taint checks.

2rx=bbaetz
parent ef7c3883
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 2 deletions
CGI.pl
View file @ 38fac175
...@@ -276,8 +276,9 @@ sub ValidateBugID { ...@@ -276,8 +276,9 @@ sub ValidateBugID {
$id = trim($id); $id = trim($id);
# If the ID isn't a number, it might be an alias, so try to convert it. # If the ID isn't a number, it might be an alias, so try to convert it.
if ($id !~ /^[1-9][0-9]*$/) { my $alias = $id;
$id = BugAliasToID($id); if (!detaint_natural($id)) {
$id = BugAliasToID($alias);
if (!$id) { if (!$id) {
my $html_id = html_quote($_[0]); my $html_id = html_quote($_[0]);
my $alias_specific_message = Param("usebugaliases") ? my $alias_specific_message = Param("usebugaliases") ?
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment