Commit 4a2ceff5 authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 473052: Modify WebService::Bug.add_comment to return the new comment ID

Patch By Kip Hampton <khampton@totalcinema.com> r=mkanat, a=mkanat
parent 2e920979
...@@ -337,11 +337,23 @@ sub add_comment { ...@@ -337,11 +337,23 @@ sub add_comment {
# Append comment # Append comment
$bug->add_comment($comment, { isprivate => $params->{private}, $bug->add_comment($comment, { isprivate => $params->{private},
work_time => $params->{work_time} }); work_time => $params->{work_time} });
# Capture the call to bug->update (which creates the new comment) in
# a transaction so we're sure to get the correct comment_id.
my $dbh = Bugzilla->dbh;
$dbh->bz_start_transaction();
$bug->update(); $bug->update();
my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id');
$dbh->bz_commit_transaction();
# Send mail. # Send mail.
Bugzilla::BugMail::Send($bug->bug_id, { changer => Bugzilla->user->login }); Bugzilla::BugMail::Send($bug->bug_id, { changer => Bugzilla->user->login });
return undef;
return { id => $self->type('int', $new_comment_id) };
} }
1; 1;
...@@ -977,6 +989,10 @@ be ignored. ...@@ -977,6 +989,10 @@ be ignored.
=back =back
=item B<Returns>
A hash with one element, C<id> whose value is the id of the newly-created comment.
=item B<Errors> =item B<Errors>
=over =over
...@@ -1002,6 +1018,8 @@ You did not have the necessary rights to edit the bug. ...@@ -1002,6 +1018,8 @@ You did not have the necessary rights to edit the bug.
=item Added in Bugzilla B<3.2>. =item Added in Bugzilla B<3.2>.
=item Modified to return the new comment's id in Bugzilla B<3.4>
=back =back
=back =back
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment