Commit 5f030a6f authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 389916: The "remaining_time_zeroed" message is displayed even if none of the…

Bug 389916: The "remaining_time_zeroed" message is displayed even if none of the bugs being changed has its remaining time > 0 - Patch by Fré©ric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
parent 737535fc
...@@ -2003,8 +2003,13 @@ sub check_status_change_triggers { ...@@ -2003,8 +2003,13 @@ sub check_status_change_triggers {
$vars->{DuplicateUserConfirm} = 1; $vars->{DuplicateUserConfirm} = 1;
# DUPLICATE bugs should have no time remaining. # DUPLICATE bugs should have no time remaining.
$_->_zero_remaining_time() foreach @$bugs; foreach my $bug (@$bugs) {
$vars->{'message'} = "remaining_time_zeroed"; # Note that 0.00 is *true* for Perl!
next unless ($bug->remaining_time > 0);
$bug->_zero_remaining_time;
$vars->{'message'} = "remaining_time_zeroed"
if Bugzilla->user->in_group(Bugzilla->params->{'timetrackinggroup'});
}
} }
elsif ($action eq 'change_resolution' || !is_open_state($action)) { elsif ($action eq 'change_resolution' || !is_open_state($action)) {
# don't resolve as fixed while still unresolved blocking bugs # don't resolve as fixed while still unresolved blocking bugs
...@@ -2038,8 +2043,11 @@ sub check_status_change_triggers { ...@@ -2038,8 +2043,11 @@ sub check_status_change_triggers {
if ($action ne 'change_resolution') { if ($action ne 'change_resolution') {
foreach my $b (@$bugs) { foreach my $b (@$bugs) {
if ($b->bug_status ne $action) { if ($b->bug_status ne $action) {
# Note that 0.00 is *true* for Perl!
next unless ($b->remaining_time > 0);
$b->_zero_remaining_time; $b->_zero_remaining_time;
$vars->{'message'} = "remaining_time_zeroed"; $vars->{'message'} = "remaining_time_zeroed"
if Bugzilla->user->in_group(Bugzilla->params->{'timetrackinggroup'});
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment