Bug 172959 - Remove old reporting (most doomed etc.). Patch by gerv; r=bbaetz.

CGI.pl

@@ -337,56 +337,6 @@ sub ValidateComment {
     }
 }
 
-$::CheckOptionValues = 1;
-
-# This sub is still used in reports.cgi.
-sub make_options {
-    my ($src,$default,$isregexp) = (@_);
-    my $last = "";
-    my $popup = "";
-    my $found = 0;
-    $default = "" if !defined $default;
-
-    if ($src) {
-        foreach my $item (@$src) {
-            if ($item eq "-blank-" || $item ne $last) {
-                if ($item eq "-blank-") {
-                    $item = "";
-                }
-                $last = $item;
-                if ($isregexp ? $item =~ $default : $default eq $item) {
-                    $popup .= "<OPTION SELECTED VALUE=\"$item\">$item\n";
-                    $found = 1;
-                } else {
-                    $popup .= "<OPTION VALUE=\"$item\">$item\n";
-                }
-            }
-        }
-    }
-    if (!$found && $default ne "") {
-      if ( $::CheckOptionValues &&
-           ($default ne $::dontchange) && ($default ne "-All-") &&
-           ($default ne "DUPLICATE") ) {
-        print "Possible bug database corruption has been detected.  " .
-              "Please send mail to " . Param("maintainer") . " with " .
-              "details of what you were doing when this message " . 
-              "appeared.  Thank you.\n";
-        if (!$src) {
-            $src = ["???null???"];
-        }
-        print "<pre>src = " . value_quote(join(' ', @$src)) . "\n";
-        print "default = " . value_quote($default) . "</pre>";
-        PutFooter();
-#        confess "Gulp.";
-        exit 0;
-              
-      } else {
-        $popup .= "<OPTION SELECTED>$default\n";
-      }
-    }
-    return $popup;
-}
-
 sub PasswordForLogin {
     my ($login) = (@_);
     SendSQL("select cryptpassword from profiles where login_name = " .
@@ -812,6 +762,7 @@ sub PutHeader {
      
     $::template->process("global/header.html.tmpl", $::vars)
       || ThrowTemplateError($::template->error());
+    $vars->{'header_done'} = 1;
 }
 
 sub PutFooter {

template/en/default/global/code-error.html.tmpl

@@ -48,10 +48,31 @@
     Attachment #[% attachid FILTER html %] ([% description FILTER html %]) 
     is already obsolete.
     
+  [% ELSIF error == "chart_data_not_generated" %]
+    The tool which gathers bug counts has not been run yet.
+        
+  [% ELSIF error == "chart_datafile_corrupt" %]
+    The chart data file [% file FILTER html %] is corrupt.
+        
+  [% ELSIF error == "chart_dir_nonexistent" %]
+    One of the directories <tt>[% dir FILTER html %]</tt> and 
+    <tt>[% graphdir FILTER html %]</tt> does not exist.
+  
+  [% ELSIF error == "chart_file_open_fail" %]
+    Unable to open the chart datafile <tt>[% filename FILTER html %]</tt>.
+  
+  [% ELSIF error == "chart_lines_not_installed" %]
+    Charts will not work without the Chart::Lines Perl module being installed.
+    Run checksetup.pl for installation instructions.
+
   [% ELSIF error == "field_type_mismatch" %]
     Cannot seem to handle <code>[% field %]</code>
     and <code>[% type %]</code> together.
  
+  [% ELSIF error == "gd_not_installed" %]
+    Charts will not work without the GD Perl module being installed.
+    Run checksetup.pl for installation instructions.
+
   [% ELSIF error == "group_bit_invalid" %]
     One of the group bits submitted was invalid.
 

template/en/default/global/user-error.html.tmpl

@@ -234,6 +234,9 @@
     The name of your query cannot contain any of the following characters: 
     <, >, &.
 
+  [% ELSIF error == "insufficient_data_points" %]
+    We don't have enough data points to make a graph (yet).
+        
   [% ELSIF error == "insufficient_privs_for_multi" %]
     [% title = "Insufficient Privileges" %]
     Sorry, you do not have sufficient privileges to edit multiple bugs.
@@ -318,6 +321,10 @@
     the results of your last search. I'm afraid you will have to start
     again on the <a href="query.cgi">search page</a>.
           
+  [% ELSIF error == "missing_datasets" %]
+    [% title = "No Datasets Selected" %]
+    You must specify one or more datasets to plot.
+    
   [% ELSIF error == "missing_email_type" %]
     [% title = "Your Query Makes No Sense" %]
     You must specify one or more fields in which to search for