Commit 8b725463 authored by terry%mozilla.org's avatar terry%mozilla.org

Add an optional ability to stagger the headers in the bug list, which

is uglier, but often squeezes things better horizontally.
parent f3e3cab0
...@@ -943,26 +943,52 @@ if ($dotweak) { ...@@ -943,26 +943,52 @@ if ($dotweak) {
pnl "<FORM NAME=changeform METHOD=POST ACTION=\"process_bug.cgi\">"; pnl "<FORM NAME=changeform METHOD=POST ACTION=\"process_bug.cgi\">";
} }
my $tablestart = "<TABLE CELLSPACING=0 CELLPADDING=4 WIDTH=100%>
<TR ALIGN=LEFT><TH>
<A HREF=\"buglist.cgi?$fields&order=bugs.bug_id\">ID</A>";
my @th;
foreach my $c (@collist) { foreach my $c (@collist) {
if (exists $::needquote{$c}) { if (exists $::needquote{$c}) {
my $h = "";
if ($::needquote{$c}) { if ($::needquote{$c}) {
$tablestart .= "<TH WIDTH=100% valign=left>"; $h .= "<TH WIDTH=100%>";
} else { } else {
$tablestart .= "<TH valign=left>"; $h .= "<TH>";
} }
if (defined $::sortkey{$c}) { if (defined $::sortkey{$c}) {
$tablestart .= "<A HREF=\"buglist.cgi?$fields&order=" . url_quote($::sortkey{$c}) . "$oldorder\">$::title{$c}</A>"; $h .= "<A HREF=\"buglist.cgi?$fields&order=" . url_quote($::sortkey{$c}) . "$oldorder\">$::title{$c}</A>";
} else { } else {
$tablestart .= $::title{$c}; $h .= $::title{$c};
} }
$h .= "</TH>";
push(@th, $h);
} }
} }
my $tablestart = "<TABLE CELLSPACING=0 CELLPADDING=4 WIDTH=100%>
<TR ALIGN=LEFT><TH>
<A HREF=\"buglist.cgi?$fields&order=bugs.bug_id\">ID</A>";
my $splitheader = 0;
if ($::COOKIE{'SPLITHEADER'}) {
$splitheader = 1;
}
if ($splitheader) {
$tablestart =~ s/<TH/<TH COLSPAN="2"/;
for (my $pass=0 ; $pass<2 ; $pass++) {
if ($pass == 1) {
$tablestart .= "</TR>\n<TR><TD></TD>";
}
for (my $i=1-$pass ; $i<@th ; $i += 2) {
my $h = @th[$i];
$h =~ s/TH/TH COLSPAN="2" ALIGN="left"/;
$tablestart .= $h;
}
}
} else {
$tablestart .= join("", @th);
}
$tablestart .= "\n"; $tablestart .= "\n";
......
...@@ -56,6 +56,7 @@ push(@masterlist, ("summary", "summaryfull")); ...@@ -56,6 +56,7 @@ push(@masterlist, ("summary", "summaryfull"));
my @collist; my @collist;
if (defined $::FORM{'rememberedquery'}) { if (defined $::FORM{'rememberedquery'}) {
my $splitheader = 0;
if (defined $::FORM{'resetit'}) { if (defined $::FORM{'resetit'}) {
@collist = @::default_column_list; @collist = @::default_column_list;
} else { } else {
...@@ -64,9 +65,13 @@ if (defined $::FORM{'rememberedquery'}) { ...@@ -64,9 +65,13 @@ if (defined $::FORM{'rememberedquery'}) {
push @collist, $i; push @collist, $i;
} }
} }
if (exists $::FORM{'splitheader'}) {
$splitheader = $::FORM{'splitheader'};
}
} }
my $list = join(" ", @collist); my $list = join(" ", @collist);
print "Set-Cookie: COLUMNLIST=$list ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; print "Set-Cookie: COLUMNLIST=$list ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
print "Set-Cookie: SPLITHEADER=$::FORM{'splitheader'} ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n"; print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n";
print "\n"; print "\n";
print "<TITLE>What a hack.</TITLE>\n"; print "<TITLE>What a hack.</TITLE>\n";
...@@ -81,6 +86,11 @@ if (defined $::COOKIE{'COLUMNLIST'}) { ...@@ -81,6 +86,11 @@ if (defined $::COOKIE{'COLUMNLIST'}) {
@collist = @::default_column_list; @collist = @::default_column_list;
} }
my $splitheader = 0;
if ($::COOKIE{'SPLITHEADER'}) {
$splitheader = 1;
}
my %desc; my %desc;
foreach my $i (@masterlist) { foreach my $i (@masterlist) {
...@@ -109,6 +119,12 @@ foreach my $i (@masterlist) { ...@@ -109,6 +119,12 @@ foreach my $i (@masterlist) {
print "<INPUT TYPE=checkbox NAME=column_$i $c>$desc{$i}<br>\n"; print "<INPUT TYPE=checkbox NAME=column_$i $c>$desc{$i}<br>\n";
} }
print "<P>\n"; print "<P>\n";
print BuildPulldown("splitheader",
[["0", "Normal headers (prettier)"],
["1", "Stagger headers (often makes list more compact)"]],
$splitheader);
print "<P>\n";
print "<INPUT TYPE=\"submit\" VALUE=\"Submit\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Submit\">\n";
print "</FORM>\n"; print "</FORM>\n";
print "<FORM ACTION=colchange.cgi>\n"; print "<FORM ACTION=colchange.cgi>\n";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment