Bug 286003: Direct access to summarize-time.cgi when time tracking is off…

Bug 286003: Direct access to summarize-time.cgi when time tracking is off generates an error - Patch by Shane H. W. Travis <shane.h.w.travis@gmail.com> r=jouni a=justdave

Bug 286003: Direct access to summarize-time.cgi when time tracking is off…
9797547f · lpsolit%gmail.com · 49951829 · 9797547f · 9797547f
Commit 9797547f authored Mar 30, 2005 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

summarize_time.cgi summarize_time.cgi +4 -2

user-error.html.tmpl template/en/default/global/user-error.html.tmpl +2 -0

No files found.
--- a/summarize_time.cgi
+++ b/summarize_time.cgi
@@ -360,8 +360,10 @@ my $cgi = Bugzilla->cgi;
 Bugzilla->switch_to_shadow_db();
-ThrowUserError("timetracking_access_denied") unless 
+UserInGroup(Param("timetrackinggroup"))
-    UserInGroup(Param("timetrackinggroup"));
+    || ThrowUserError("auth_failure", {group  => "time-tracking",
+                                       action => "access",
+                                       object => "timetracking_summaries"});
 my @ids = split(",", $cgi->param('id'));
 map { ValidateBugID($_) } @ids;

--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -160,6 +160,8 @@
      whine reports
    [% ELSIF object == "sanity_check" %]
      a sanity check
+    [% ELSIF object == "timetracking_summaries" %]
+      time-tracking summary reports
    [% ELSIF object == "user" %]
      the user you specified
    [% ELSIF object == "users" %]