Skip to content

bugzilla
bugzilla
Commit 99f91c79 authored by zach%zachlipton.com's avatar zach%zachlipton.com
Browse files
Options

Fix for bug 87398: checksetup.pl should warn if not run as root. Patch

adds a warning if the user has webservergroup set but does not run checksetup.pl as root. r1=kiko, r2=justdave
parent 788e94b4
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
checksetup.pl
View file @ 99f91c79
...@@ -771,6 +771,20 @@ sub fixPerms { ...@@ -771,6 +771,20 @@ sub fixPerms {
} }
if ($my_webservergroup) { if ($my_webservergroup) {
unless ($< == 0) { # zach: if not root, yell at them, bug 87398
print <<EOF;
Warning: you have entered a value for the "webservergroup" parameter
in localconfig, but you are not running this script as root.
This can cause permissions problems and decreased security. If you
experience problems running Bugzilla scripts, log in as root and re-run
this script, or remove the value of the "webservergroup" parameter.
Note that any warnings about "uninitialized values" that you may
see below are caused by this.
EOF
}
# Funny! getgrname returns the GID if fed with NAME ... # Funny! getgrname returns the GID if fed with NAME ...
my $webservergid = getgrnam($my_webservergroup); my $webservergid = getgrnam($my_webservergroup);
# chown needs to be called with a valid uid, not 0. $< returns the # chown needs to be called with a valid uid, not 0. $< returns the
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment