Commit c1cec451 authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 371016: Versions are no longer sorted by version-sort

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
parent e0318906
...@@ -21,6 +21,7 @@ package Bugzilla::Version; ...@@ -21,6 +21,7 @@ package Bugzilla::Version;
use base qw(Bugzilla::Object); use base qw(Bugzilla::Object);
use Bugzilla::Install::Requirements qw(vers_cmp);
use Bugzilla::Util; use Bugzilla::Util;
use Bugzilla::Error; use Bugzilla::Error;
...@@ -39,7 +40,9 @@ use constant DB_COLUMNS => qw( ...@@ -39,7 +40,9 @@ use constant DB_COLUMNS => qw(
); );
use constant NAME_FIELD => 'value'; use constant NAME_FIELD => 'value';
use constant LIST_ORDER => NAME_FIELD; # This is "id" because it has to be filled in and id is probably the fastest.
# We do a custom sort in new_from_list below.
use constant LIST_ORDER => 'id';
sub new { sub new {
my $class = shift; my $class = shift;
...@@ -70,6 +73,12 @@ sub new { ...@@ -70,6 +73,12 @@ sub new {
return $class->SUPER::new(@_); return $class->SUPER::new(@_);
} }
sub new_from_list {
my $self = shift;
my $list = $self->SUPER::new_from_list(@_);
return [sort { vers_cmp(lc($a->name), lc($b->name)) } @$list];
}
sub bug_count { sub bug_count {
my $self = shift; my $self = shift;
my $dbh = Bugzilla->dbh; my $dbh = Bugzilla->dbh;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment