Commit f1912867 authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 345389: Template-Toolkit 2.15 moved Template::Plugin::GD into a separate package

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk
parent 01939a3d
...@@ -98,6 +98,12 @@ use constant OPTIONAL_MODULES => [ ...@@ -98,6 +98,12 @@ use constant OPTIONAL_MODULES => [
version => '1.20' version => '1.20'
}, },
{ {
# This module tells us whether or not Template-GD is installed
# on Template-Toolkits after 2.14, and still works with 2.14 and lower.
name => 'Template::Plugin::GD::Image',
version => 0
},
{
name => 'Chart::Base', name => 'Chart::Base',
version => '1.0' version => '1.0'
}, },
...@@ -162,10 +168,13 @@ use constant WIN32_MODULE_NAMES => { ...@@ -162,10 +168,13 @@ use constant WIN32_MODULE_NAMES => {
'GD::Graph' => 'GDGraph', 'GD::Graph' => 'GDGraph',
'GD::Text::Align' => 'GDTextUtil', 'GD::Text::Align' => 'GDTextUtil',
'Mail::Mailer' => 'MailTools', 'Mail::Mailer' => 'MailTools',
# We provide Template 2.14 or lower for Win32, so it still includes
# the GD plugin.
'Template::Plugin::GD' => 'Template',
}; };
# This was originally clipped from the libnet Makefile.PL, adapted here to # This was originally clipped from the libnet Makefile.PL, adapted here to
# use the above vers_cmp routine for accurate version checking. # use the below vers_cmp routine for accurate version checking.
sub have_vers { sub have_vers {
my ($pkg, $wanted, $silent) = @_; my ($pkg, $wanted, $silent) = @_;
my ($msg, $vnum, $vstr); my ($msg, $vnum, $vstr);
......
...@@ -296,7 +296,9 @@ if (!$have_mod{'Image::Magick'} && !$silent) { ...@@ -296,7 +296,9 @@ if (!$have_mod{'Image::Magick'} && !$silent) {
} }
if ( (!$have_mod{'GD'} || !$have_mod{'GD::Graph'} if ( (!$have_mod{'GD'} || !$have_mod{'GD::Graph'}
|| !$have_mod{'GD::Text::Align'}) && !$silent) || !$have_mod{'GD::Text::Align'}
|| !$have_mod{'Template::Plugin::GD::Image'})
&& !$silent)
{ {
print "If you want to see graphical bug reports (bar, pie and line "; print "If you want to see graphical bug reports (bar, pie and line ";
print "charts of \ncurrent data), you should install libgd and the "; print "charts of \ncurrent data), you should install libgd and the ";
...@@ -306,6 +308,8 @@ if ( (!$have_mod{'GD'} || !$have_mod{'GD::Graph'} ...@@ -306,6 +308,8 @@ if ( (!$have_mod{'GD'} || !$have_mod{'GD::Graph'}
if !$have_mod{'GD::Graph'}; if !$have_mod{'GD::Graph'};
print "GD::Text::Align: " . install_command("GD::Text::Align") . "\n" print "GD::Text::Align: " . install_command("GD::Text::Align") . "\n"
if !$have_mod{'GD::Text::Align'}; if !$have_mod{'GD::Text::Align'};
print "Template::Plugin::GD: " . install_command('Template::Plugin::GD')
. "\n" if !$have_mod{'Template::Plugin::GD::Image'};
print "\n"; print "\n";
} }
if (!$have_mod{'PatchReader'} && !$silent) { if (!$have_mod{'PatchReader'} && !$silent) {
......
...@@ -149,6 +149,16 @@ ...@@ -149,6 +149,16 @@
</para> </para>
<para> <para>
Template::Plugin::GD:
<literallayout>
CPAN Download Page: <ulink url="http://search.cpan.org/dist/Template-GD/" />
PPM Download Link: (Just install Template-Toolkit using the instructions below)
Documentation: <ulink url="http://www.template-toolkit.org/docs/aqua/Modules/index.html" />
</literallayout>
</para>
<para>
MIME::Base64: MIME::Base64:
<literallayout> <literallayout>
CPAN Download Page: <ulink url="http://search.cpan.org/dist/MIME-Base64/"/> CPAN Download Page: <ulink url="http://search.cpan.org/dist/MIME-Base64/"/>
......
...@@ -203,6 +203,14 @@ if ($@ eq '') { ...@@ -203,6 +203,14 @@ if ($@ eq '') {
print "TEST-FAILED Chart returned: $@\n"; print "TEST-FAILED Chart returned: $@\n";
} }
} }
eval 'use Template::Plugin::GD::Image';
if ($@) {
print "TEST-FAILED Template::Plugin::GD is not installed.\n";
}
else {
print "TEST-OK Template::Plugin::GD is installed.\n";
}
} }
sub fetch { sub fetch {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment