Commit f47c0339 authored by terry%mozilla.org's avatar terry%mozilla.org

Patched minor security hole; don't show summary of bugs that the user

doesn't have permission to see.
parent 9b1a4477
...@@ -47,6 +47,8 @@ PutHeader("Dependency graph", "Dependency graph", $id); ...@@ -47,6 +47,8 @@ PutHeader("Dependency graph", "Dependency graph", $id);
if (defined $id) { if (defined $id) {
ConnectToDatabase(); ConnectToDatabase();
quietly_check_login();
$::usergroupset = $::usergroupset; # More warning suppression silliness.
mkdir("data/webdot", 0777); mkdir("data/webdot", 0777);
...@@ -99,8 +101,10 @@ node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey] ...@@ -99,8 +101,10 @@ node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey]
my $summary = ""; my $summary = "";
my $stat; my $stat;
if ($::FORM{'showsummary'}) { if ($::FORM{'showsummary'}) {
SendSQL("select bug_status, short_desc from bugs where bug_id = $k"); SendSQL("select bug_status, short_desc from bugs where bug_id = $k and bugs.groupset & $::usergroupset = bugs.groupset");
($stat, $summary) = (FetchSQLData()); ($stat, $summary) = (FetchSQLData());
$stat = "NEW" if !defined $stat;
$summary = "" if !defined $summary;
} else { } else {
SendSQL("select bug_status from bugs where bug_id = $k"); SendSQL("select bug_status from bugs where bug_id = $k");
$stat = FetchOneColumn(); $stat = FetchOneColumn();
......
...@@ -37,6 +37,10 @@ PutHeader("Dependency tree", "Dependency tree", "Bug $linkedid"); ...@@ -37,6 +37,10 @@ PutHeader("Dependency tree", "Dependency tree", "Bug $linkedid");
ConnectToDatabase(); ConnectToDatabase();
quietly_check_login();
$::usergroupset = $::usergroupset; # More warning suppression silliness.
my %seen; my %seen;
sub DumpKids { sub DumpKids {
...@@ -53,8 +57,10 @@ sub DumpKids { ...@@ -53,8 +57,10 @@ sub DumpKids {
if (@list) { if (@list) {
print "<ul>\n"; print "<ul>\n";
foreach my $kid (@list) { foreach my $kid (@list) {
SendSQL("select bug_status, short_desc from bugs where bug_id = $kid"); SendSQL("select bug_status, short_desc from bugs where bug_id = $kid and bugs.groupset & $::usergroupset = bugs.groupset");
my ($stat, $short_desc) = (FetchSQLData()); my ($stat, $short_desc) = (FetchSQLData());
$stat = "NEW" if !defined $stat;
$short_desc = "" if !defined $short_desc;
my $opened = ($stat eq "NEW" || $stat eq "ASSIGNED" || my $opened = ($stat eq "NEW" || $stat eq "ASSIGNED" ||
$stat eq "REOPENED"); $stat eq "REOPENED");
print "<li>"; print "<li>";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment