attachment.cgi 29.1 KB
Newer Older
1
#!/usr/bin/perl -T
2 3 4
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
5
#
6 7
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
8

9
use 5.10.1;
10
use strict;
11 12
use warnings;

13
use lib qw(. lib);
14

15
use Bugzilla;
16
use Bugzilla::BugMail;
17
use Bugzilla::Constants;
18
use Bugzilla::Error;
19 20
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
21
use Bugzilla::User;
22
use Bugzilla::Util;
23
use Bugzilla::Bug;
24
use Bugzilla::Attachment;
25
use Bugzilla::Attachment::PatchReader;
26
use Bugzilla::Token;
27

28
use Encode qw(encode find_encoding);
29
use Encode::MIME::Header; # Required to alter Encode::Encoding{'MIME-Q'}.
30

31 32 33 34 35 36 37
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
# make them globals.
local our $cgi = Bugzilla->cgi;
local our $template = Bugzilla->template;
local our $vars = {};
38
local $Bugzilla::CGI::ALLOW_UNSAFE_RESPONSE = 1;
39

40 41 42 43
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
44 45

# Determine whether to use the action specified by the user or the default.
46
my $action = $cgi->param('action') || 'view';
47
my $format = $cgi->param('format') || '';
48

49
# You must use the appropriate urlbase/sslbase param when doing anything
50 51 52 53
# but viewing an attachment, or a raw diff.
if ($action ne 'view'
    && (($action !~ /^(?:interdiff|diff)$/) || $format ne 'raw'))
{
54 55
    do_ssl_redirect_if_required();
    if ($cgi->url_is_attachment_base) {
56 57 58 59 60 61 62 63
        $cgi->redirect_to_urlbase;
    }
    Bugzilla->login();
}

# When viewing an attachment, do not request credentials if we are on
# the alternate host. Let view() decide when to call Bugzilla->login.
if ($action eq "view")
64
{
65
    view();
66
}
67 68
elsif ($action eq "interdiff")
{
69
    interdiff();
70 71 72
}
elsif ($action eq "diff")
{
73
    diff();
74
}
75 76
elsif ($action eq "viewall") 
{ 
77
    viewall(); 
78
}
79 80
elsif ($action eq "enter") 
{ 
81 82
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
83 84 85
}
elsif ($action eq "insert")
{
86 87
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
88
}
89 90
elsif ($action eq "edit") 
{ 
91
    edit(); 
92 93 94
}
elsif ($action eq "update") 
{ 
95 96
    Bugzilla->login(LOGIN_REQUIRED);
    update();
97
}
98 99 100
elsif ($action eq "delete") {
    delete_attachment();
}
101 102
else 
{ 
103
  ThrowUserError('unknown_action', {action => $action});
104 105 106 107 108 109 110 111
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

112 113 114
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
115 116
# If the second parameter is true, the attachment ID will be validated,
# however the current user's access to the attachment will not be checked.
117 118 119 120
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
121 122 123
# Returns an attachment object.

sub validateID {
124 125
    my($param, $dont_validate_access) = @_;
    $param ||= 'id';
126

127 128 129
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
130
    if ($param eq 'id' && !$cgi->param('id')) {
131
        print $cgi->header();
132 133 134 135
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
136
    
137 138 139 140 141 142
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
143 144
        || ThrowUserError("invalid_attach_id",
                          { attach_id => scalar $cgi->param($param) });
145
  
146
    # Make sure the attachment exists in the database.
147
    my $attachment = new Bugzilla::Attachment({ id => $attach_id, cache => 1 })
148
        || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
149

150 151 152 153 154 155 156 157
    return $attachment if ($dont_validate_access || check_can_access($attachment));
}

# Make sure the current user has access to the specified attachment.
sub check_can_access {
    my $attachment = shift;
    my $user = Bugzilla->user;

158
    # Make sure the user is authorized to access this attachment's bug.
159
    Bugzilla::Bug->check({ id => $attachment->bug_id, cache => 1 });
160 161 162
    if ($attachment->isprivate && $user->id != $attachment->attacher->id 
        && !$user->is_insider) 
    {
163
        ThrowUserError('auth_failure', {action => 'access',
164 165
                                        object => 'attachment',
                                        attach_id => $attachment->id});
166
    }
167 168 169 170 171 172 173 174 175 176 177 178 179
    return 1;
}

# Determines if the attachment is public -- that is, if users who are
# not logged in have access to the attachment
sub attachmentIsPublic {
    my $attachment = shift;

    return 0 if Bugzilla->params->{'requirelogin'};
    return 0 if $attachment->isprivate;

    my $anon_user = new Bugzilla::User;
    return $anon_user->can_see_bug($attachment->bug_id);
180 181
}

182 183 184
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
185
sub validateFormat {
186 187
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
188
  if (not grep($_ eq $format, @_)) {
189
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
190
  }
191

192
  return $format;
193 194
}

195 196 197 198
# Gets the attachment object(s) generated by validateID, while ensuring
# attachbase and token authentication is used when required.
sub get_attachment {
    my @field_names = @_ ? @_ : qw(id);
199

200
    my %attachments;
201 202

    if (use_attachbase()) {
203 204 205 206 207 208 209 210 211 212
        # Load each attachment, and ensure they are all from the same bug
        my $bug_id = 0;
        foreach my $field_name (@field_names) {
            my $attachment = validateID($field_name, 1);
            if (!$bug_id) {
                $bug_id = $attachment->bug_id;
            } elsif ($attachment->bug_id != $bug_id) {
                ThrowUserError('attachment_bug_id_mismatch');
            }
            $attachments{$field_name} = $attachment;
213
        }
214 215 216 217 218
        my @args = map { $_ . '=' . $attachments{$_}->id } @field_names;
        my $cgi_params = $cgi->canonicalise_query(@field_names, 't',
            'Bugzilla_login', 'Bugzilla_password');
        push(@args, $cgi_params) if $cgi_params;
        my $path = 'attachment.cgi?' . join('&', @args);
219 220

        # Make sure the attachment is served from the correct server.
221 222 223
        if ($cgi->url_is_attachment_base($bug_id)) {
            # No need to validate the token for public attachments. We cannot request
            # credentials as we are on the alternate host.
224
            if (!all_attachments_are_public(\%attachments)) {
225
                my $token = $cgi->param('t');
226 227 228 229 230 231 232 233 234 235 236 237 238 239
                my ($userid, undef, $token_data) = Bugzilla::Token::GetTokenData($token);
                my %token_data = unpack_token_data($token_data);
                my $valid_token = 1;
                foreach my $field_name (@field_names) {
                    my $token_id = $token_data{$field_name};
                    if (!$token_id
                        || !detaint_natural($token_id)
                        || $attachments{$field_name}->id != $token_id)
                    {
                        $valid_token = 0;
                        last;
                    }
                }
                unless ($userid && $valid_token) {
240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
                    # Not a valid token.
                    print $cgi->redirect('-location' => correct_urlbase() . $path);
                    exit;
                }
                # Change current user without creating cookies.
                Bugzilla->set_user(new Bugzilla::User($userid));
                # Tokens are single use only, delete it.
                delete_token($token);
            }
        }
        elsif ($cgi->url_is_attachment_base) {
            # If we come here, this means that each bug has its own host
            # for attachments, and that we are trying to view one attachment
            # using another bug's host. That's not desired.
            $cgi->redirect_to_urlbase;
        }
        else {
            # We couldn't call Bugzilla->login earlier as we first had to
258 259
            # make sure we were not going to request credentials on the
            # alternate host.
260
            Bugzilla->login();
261 262 263 264
            my $attachbase = Bugzilla->params->{'attachment_base'};
            # Replace %bugid% by the ID of the bug the attachment 
            # belongs to, if present.
            $attachbase =~ s/\%bugid\%/$bug_id/;
265
            if (all_attachments_are_public(\%attachments)) {
266 267 268 269 270
                # No need for a token; redirect to attachment base.
                print $cgi->redirect(-location => $attachbase . $path);
                exit;
            } else {
                # Make sure the user can view the attachment.
271 272 273
                foreach my $field_name (@field_names) {
                    check_can_access($attachments{$field_name});
                }
274
                # Create a token and redirect.
275
                my $token = url_quote(issue_session_token(pack_token_data(\%attachments)));
276 277 278 279 280
                print $cgi->redirect(-location => $attachbase . "$path&t=$token");
                exit;
            }
        }
    } else {
281
        do_ssl_redirect_if_required();
282 283
        # No alternate host is used. Request credentials if required.
        Bugzilla->login();
284 285 286
        foreach my $field_name (@field_names) {
            $attachments{$field_name} = validateID($field_name);
        }
287 288
    }

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
    return wantarray
        ? map { $attachments{$_} } @field_names
        : $attachments{$field_names[0]};
}

sub all_attachments_are_public {
    my $attachments = shift;
    foreach my $field_name (keys %$attachments) {
        if (!attachmentIsPublic($attachments->{$field_name})) {
            return 0;
        }
    }
    return 1;
}

sub pack_token_data {
    my $attachments = shift;
    return join(' ', map { $_ . '=' . $attachments->{$_}->id } keys %$attachments);
}

sub unpack_token_data {
    my @token_data = split(/ /, shift || '');
    my %data;
    foreach my $token (@token_data) {
        my ($field_name, $attach_id) = split('=', $token);
        $data{$field_name} = $attach_id;
    }
    return %data;
}

################################################################################
# Functions
################################################################################

# Display an attachment.
sub view {
    my $attachment = get_attachment();

327
    # At this point, Bugzilla->login has been called if it had to.
328 329 330
    my $contenttype = $attachment->contenttype;
    my $filename = $attachment->filename;

331 332
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
333 334
    if (defined $cgi->param('content_type')) {
        $contenttype = $attachment->_check_content_type($cgi->param('content_type'));
335
    }
336

337
    # Return the appropriate HTTP response headers.
338
    $attachment->datasize || ThrowUserError("attachment_removed");
339

340
    $filename =~ s/^.*[\/\\]//;
341 342 343 344
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

345 346 347 348 349
    # Avoid line wrapping done by Encode, which we don't need for HTTP
    # headers. See discussion in bug 328628 for details.
    local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
    $filename = encode('MIME-Q', $filename);

350 351
    my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';

352 353 354 355 356 357 358
    # Don't send a charset header with attachments--they might not be UTF-8.
    # However, we do allow people to explicitly specify a charset if they
    # want.
    if ($contenttype !~ /\bcharset=/i) {
        # In order to prevent Apache from adding a charset, we have to send a
        # charset that's a single space.
        $cgi->charset(' ');
359 360 361 362 363 364
        if (Bugzilla->feature('detect_charset') && $contenttype =~ /^text\//) {
            my $encoding = detect_encoding($attachment->data);
            if ($encoding) {
                $cgi->charset(find_encoding($encoding)->mime_name);
            }
        }
365
    }
366
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
367
                       -content_disposition=> "$disposition; filename=\"$filename\"",
368
                       -content_length => $attachment->datasize);
369
    disable_utf8();
370
    print $attachment->data;
371 372
}

373 374 375
sub interdiff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
376 377 378 379 380 381 382
    my($old_attachment, $new_attachment);
    if ($format eq 'raw') {
        ($old_attachment, $new_attachment) = get_attachment('oldid', 'newid');
    } else {
        $old_attachment = validateID('oldid');
        $new_attachment = validateID('newid');
    }
383 384

    Bugzilla::Attachment::PatchReader::process_interdiff(
385
        $old_attachment, $new_attachment, $format);
386 387
}

388 389 390
sub diff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
391
    my $attachment = $format eq 'raw' ? get_attachment() : validateID();
392

393 394 395 396
    # If it is not a patch, view normally.
    if (!$attachment->ispatch) {
        view();
        return;
397 398
    }

399
    Bugzilla::Attachment::PatchReader::process_diff($attachment, $format);
400
}
401

402 403
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
404
sub viewall {
405
    # Retrieve and validate parameters
406
    my $bug = Bugzilla::Bug->check({ id => scalar $cgi->param('bugid'), cache => 1 });
407

408
    my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug);
409 410
    # Ignore deleted attachments.
    @$attachments = grep { $_->datasize } @$attachments;
411

412 413 414 415 416
    if ($cgi->param('hide_obsolete')) {
        @$attachments = grep { !$_->isobsolete } @$attachments;
        $vars->{'hide_obsolete'} = 1;
    }

417 418 419
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = $attachments;
420

421
    print $cgi->header();
422

423 424 425
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/show-multiple.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
426 427
}

428
# Display a form for entering a new attachment.
429
sub enter {
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
    # Retrieve and validate parameters
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
    Bugzilla::Attachment->_check_bug($bug);
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;

    # Retrieve the attachments the user can edit from the database and write
    # them into an array of hashes where each hash represents one attachment.
  
    my ($can_edit, $not_private) = ('', '');
    if (!$user->in_group('editbugs', $bug->product_id)) {
        $can_edit = "AND submitter_id = " . $user->id;
    }
    if (!$user->is_insider) {
        $not_private = "AND isprivate = 0";
    }
    my $attach_ids = $dbh->selectcol_arrayref(
        "SELECT attach_id
           FROM attachments
          WHERE bug_id = ?
                AND isobsolete = 0
                $can_edit $not_private
       ORDER BY attach_id",
         undef, $bugid);

    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = Bugzilla::Attachment->new_from_list($attach_ids);

    my $flag_types = Bugzilla::FlagType::match({
        'target_type'  => 'attachment',
        'product_id'   => $bug->product_id,
        'component_id' => $bug->component_id
    });
    $vars->{'flag_types'} = $flag_types;
    $vars->{'any_flags_requesteeble'} =
        grep { $_->is_requestable && $_->is_requesteeble } @$flag_types;
468
    $vars->{'token'} = issue_session_token('create_attachment');
469 470 471 472 473 474

    print $cgi->header();

    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/create.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
475 476
}

477
# Insert a new attachment into the database.
478
sub insert {
479 480
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;
481

482 483
    $dbh->bz_start_transaction;

484
    # Retrieve and validate parameters
485 486
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
487
    my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
488

489 490
    # Detect if the user already used the same form to submit an attachment
    my $token = trim($cgi->param('token'));
491
    check_token_data($token, 'create_attachment', 'index.cgi');
492

493 494 495 496 497 498 499 500 501 502
    # Check attachments the user tries to mark as obsolete.
    my @obsolete_attachments;
    if ($cgi->param('obsolete')) {
        my @obsolete = $cgi->param('obsolete');
        @obsolete_attachments = Bugzilla::Attachment->validate_obsolete($bug, \@obsolete);
    }

    # Must be called before create() as it may alter $cgi->param('ispatch').
    my $content_type = Bugzilla::Attachment::get_content_type();

503 504
    # Get the filehandle of the attachment.
    my $data_fh = $cgi->upload('data');
505
    my $attach_text = $cgi->param('attach_text');
506

507 508 509
    my $attachment = Bugzilla::Attachment->create(
        {bug           => $bug,
         creation_ts   => $timestamp,
510
         data          => $attach_text || $data_fh,
511
         description   => scalar $cgi->param('description'),
512
         filename      => $attach_text ? "file_$bugid.txt" : $data_fh,
513 514 515 516 517
         ispatch       => scalar $cgi->param('ispatch'),
         isprivate     => scalar $cgi->param('isprivate'),
         mimetype      => $content_type,
         });

518 519 520
    # Delete the token used to create this attachment.
    delete_token($token);

521
    foreach my $obsolete_attachment (@obsolete_attachments) {
522 523
        $obsolete_attachment->set_is_obsolete(1);
        $obsolete_attachment->update($timestamp);
524
    }
525

526 527 528 529
    my ($flags, $new_flags) = Bugzilla::Flag->extract_flags_from_cgi(
                                  $bug, $attachment, $vars, SKIP_REQUESTEE_ON_ERROR);
    $attachment->set_flags($flags, $new_flags);

530
    # Insert a comment about the new attachment into the database.
531
    my $comment = $cgi->param('comment');
532
    $comment = '' unless defined $comment;
533 534 535
    $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                  type => CMT_ATTACHMENT_CREATED,
                                  extra_data => $attachment->id });
536

537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558
    # Assign the bug to the user, if they are allowed to take it
    my $owner = "";
    if ($cgi->param('takebug') && $user->in_group('editbugs', $bug->product_id)) {
        # When taking a bug, we have to follow the workflow.
        my $bug_status = $cgi->param('bug_status') || '';
        ($bug_status) = grep { $_->name eq $bug_status }
                        @{ $bug->status->can_change_to };

        if ($bug_status && $bug_status->is_open
            && ($bug_status->name ne 'UNCONFIRMED'
                || $bug->product_obj->allows_unconfirmed))
        {
            $bug->set_bug_status($bug_status->name);
            $bug->clear_resolution();
        }
        # Make sure the person we are taking the bug from gets mail.
        $owner = $bug->assigned_to->login;
        $bug->set_assigned_to($user);
    }

    $bug->add_cc($user) if $cgi->param('addselfcc');
    $bug->update($timestamp);
559

560 561 562
    # We have to update the attachment after updating the bug, to ensure new
    # comments are available.
    $attachment->update($timestamp);
563

564
    $dbh->bz_commit_transaction;
565

566 567 568 569 570 571 572
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    # We cannot reuse the $bug object as delta_ts has eventually been updated
    # since the object was created.
    $vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
    $vars->{'header_done'} = 1;
    $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
573

574 575
    my $recipients = { 'changer' => $user, 'owner' => $owner };
    $vars->{'sent_bugmail'} = Bugzilla::BugMail::Send($bugid, $recipients);
576

577 578 579 580
    print $cgi->header();
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/created.html.tmpl", $vars)
        || ThrowTemplateError($template->error());
581 582
}

583 584 585 586
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
587
sub edit {
588
    my $attachment = validateID();
589

590 591
    my $bugattachments =
        Bugzilla::Attachment->get_attachments_by_bug($attachment->bug);
592

593 594 595 596 597 598 599 600
    my $any_flags_requesteeble = grep { $_->is_requestable && $_->is_requesteeble }
                                 @{ $attachment->flag_types };
    # Useful in case a flagtype is no longer requestable but a requestee
    # has been set before we turned off that bit.
    $any_flags_requesteeble ||= grep { $_->requestee_id } @{ $attachment->flags };
    $vars->{'any_flags_requesteeble'} = $any_flags_requesteeble;
    $vars->{'attachment'} = $attachment;
    $vars->{'attachments'} = $bugattachments;
601

602
    print $cgi->header();
603

604 605 606
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/edit.html.tmpl", $vars)
        || ThrowTemplateError($template->error());
607 608
}

609 610
# Updates an attachment record. Only users with "editbugs" privileges,
# (or the original attachment's submitter) can edit the attachment.
611
# Users cannot edit the content of the attachment itself.
612
sub update {
613 614
    my $user = Bugzilla->user;
    my $dbh = Bugzilla->dbh;
615

616 617 618
    # Start a transaction in preparation for updating the attachment.
    $dbh->bz_start_transaction();

619
    # Retrieve and validate parameters
620
    my $attachment = validateID();
621 622
    my $bug = $attachment->bug;
    $attachment->_check_bug;
623
    my $can_edit = $attachment->validate_can_edit;
624 625 626 627 628 629 630 631 632 633

    if ($can_edit) {
        $attachment->set_description(scalar $cgi->param('description'));
        $attachment->set_is_patch(scalar $cgi->param('ispatch'));
        $attachment->set_content_type(scalar $cgi->param('contenttypeentry'));
        $attachment->set_is_obsolete(scalar $cgi->param('isobsolete'));
        $attachment->set_is_private(scalar $cgi->param('isprivate'));
        $attachment->set_filename(scalar $cgi->param('filename'));

        # Now make sure the attachment has not been edited since we loaded the page.
634 635
        my $delta_ts = $cgi->param('delta_ts');
        my $modification_time = $attachment->modification_time;
636

637 638 639 640
        if ($delta_ts && $delta_ts ne $modification_time) {
            datetime_from($delta_ts)
              or ThrowCodeError('invalid_timestamp', { timestamp => $delta_ts });
            ($vars->{'operations'}) = $bug->get_activity($attachment->id, $delta_ts);
641 642 643 644 645

            # If the modification date changed but there is no entry in
            # the activity table, this means someone commented only.
            # In this case, there is no reason to midair.
            if (scalar(@{$vars->{'operations'}})) {
646 647 648 649
                $cgi->param('delta_ts', $modification_time);
                # The token contains the old modification_time. We need a new one.
                $cgi->param('token', issue_hash_token([$attachment->id, $modification_time]));

650 651 652 653 654 655 656 657
                $vars->{'attachment'} = $attachment;

                print $cgi->header();
                # Warn the user about the mid-air collision and ask them what to do.
                $template->process("attachment/midair.html.tmpl", $vars)
                  || ThrowTemplateError($template->error());
                exit;
            }
658 659
        }
    }
660 661 662 663 664 665

    # We couldn't do this check earlier as we first had to validate attachment ID
    # and display the mid-air collision page if modification_time changed.
    my $token = $cgi->param('token');
    check_hash_token($token, [$attachment->id, $attachment->modification_time]);

666 667
    # If the user submitted a comment while editing the attachment,
    # add the comment to the bug. Do this after having validated isprivate!
668
    my $comment = $cgi->param('comment');
669
    if (defined $comment && trim($comment) ne '') {
670 671 672
        $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                      type => CMT_ATTACHMENT_UPDATED,
                                      extra_data => $attachment->id });
673 674
    }

675 676
    $bug->add_cc($user) if $cgi->param('addselfcc');

677 678 679
    my ($flags, $new_flags) =
      Bugzilla::Flag->extract_flags_from_cgi($bug, $attachment, $vars);

680 681 682
    if ($can_edit) {
        $attachment->set_flags($flags, $new_flags);
    }
683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703
    # Requestees can set flags targetted to them, even if they cannot
    # edit the attachment. Flag setters can edit their own flags too.
    elsif (scalar @$flags) {
        my %flag_list = map { $_->{id} => $_ } @$flags;
        my $flag_objs = Bugzilla::Flag->new_from_list([keys %flag_list]);

        my @editable_flags;
        foreach my $flag_obj (@$flag_objs) {
            if ($flag_obj->setter_id == $user->id
                || ($flag_obj->requestee_id && $flag_obj->requestee_id == $user->id))
            {
                push(@editable_flags, $flag_list{$flag_obj->id});
            }
        }

        if (scalar @editable_flags) {
            $attachment->set_flags(\@editable_flags, []);
            # Flag changes must be committed.
            $can_edit = 1;
        }
    }
704

705
    # Figure out when the changes were made.
706
    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
707

708 709 710 711 712
    # Commit the comment, if any.
    # This has to happen before updating the attachment, to ensure new comments
    # are available to $attachment->update.
    $bug->update($timestamp);

713 714 715 716 717 718 719
    if ($can_edit) {
        my $changes = $attachment->update($timestamp);
        # If there are changes, we updated delta_ts in the DB. We have to
        # reflect this change in the bug object.
        $bug->{delta_ts} = $timestamp if scalar(keys %$changes);
    }

720 721
    # Commit the transaction now that we are finished updating the database.
    $dbh->bz_commit_transaction();
722

723 724 725 726
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    $vars->{'bugs'} = [$bug];
    $vars->{'header_done'} = 1;
727
    $vars->{'sent_bugmail'} = 
728
        Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
729

730
    print $cgi->header();
731

732 733 734
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/updated.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
735
}
736 737 738 739 740 741 742 743 744 745 746 747 748

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

749
    Bugzilla->params->{'allow_attachment_deletion'}
750 751 752
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
753
    my $attachment = validateID();
754
    Bugzilla::Attachment->_check_bug($attachment->bug);
755 756 757 758 759 760 761 762 763

    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
764
                  && ($event eq 'delete_attachment' . $attachment->id))
765 766
        {
            # The token is invalid.
767
            ThrowUserError('token_does_not_exist');
768 769
        }

770 771
        my $bug = new Bugzilla::Bug($attachment->bug_id);

772 773
        # The token is valid. Delete the content of the attachment.
        my $msg;
774
        $vars->{'attachment'} = $attachment;
775 776 777 778 779
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

780 781 782
        # Paste the reason provided by the admin into a comment.
        $bug->add_comment($msg);

783
        $attachment->remove_from_db();
784 785

        # Now delete the token.
786
        delete_token($token);
787

788 789
        # Insert the comment.
        $bug->update();
790

791
        # Required to display the bug the deleted attachment belongs to.
792
        $vars->{'bugs'} = [$bug];
793 794
        $vars->{'header_done'} = 1;

795
        $vars->{'sent_bugmail'} =
796
            Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
797

798 799 800 801 802
        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
803
        $token = issue_session_token('delete_attachment' . $attachment->id);
804 805 806 807 808 809 810 811

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}