attachment.cgi 41.7 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla Bug Tracking System.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
#                 Myk Melez <myk@mozilla.org>
23 24
#                 Daniel Raichle <draichle@gmx.net>
#                 Dave Miller <justdave@syndicomm.com>
25
#                 Alexander J. Vincent <ajvincent@juno.com>
26 27 28 29 30 31 32 33

################################################################################
# Script Initialization
################################################################################

# Make it harder for us to do dangerous things in Perl.
use strict;

34 35
use lib qw(.);

36 37 38 39 40
use vars qw(
  $template
  $vars
);

41 42 43
# Include the Bugzilla CGI and general utility library.
require "CGI.pl";

44
# Use these modules to handle flags.
45
use Bugzilla::Constants;
46 47
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
48
use Bugzilla::User;
49
use Bugzilla::Util;
50

51
# Check whether or not the user is logged in and, if so, set the $::userid 
52
Bugzilla->login();
53

54 55 56 57 58 59 60 61 62 63 64
# The ID of the bug to which the attachment is attached.  Gets set
# by validateID() (which validates the attachment ID, not the bug ID, but has
# to check if the user is authorized to access this attachment) and is used 
# by Flag:: and FlagType::validate() to ensure the requestee (if any) for a 
# requested flag is authorized to see the bug in question.  Note: This should 
# really be defined just above validateID() itself, but it's used in the main 
# body of the script before that function is defined, so we define it up here 
# instead.  We should move the validation into each function and then move this
# to just above validateID().
my $bugid;

65 66
my $cgi = Bugzilla->cgi;

67 68 69 70
################################################################################
# Main Body Execution
################################################################################

71 72 73 74
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
75 76 77 78 79

# Determine whether to use the action specified by the user or the default.
my $action = $::FORM{'action'} || 'view';

if ($action eq "view")  
80
{
81
  validateID();
82
  view();
83
}
84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
elsif ($action eq "interdiff")
{
  validateID('oldid');
  validateID('newid');
  validateFormat("html", "raw");
  validateContext();
  interdiff();
}
elsif ($action eq "diff")
{
  validateID();
  validateFormat("html", "raw");
  validateContext();
  diff();
}
99 100 101 102 103
elsif ($action eq "viewall") 
{ 
  ValidateBugID($::FORM{'bugid'});
  viewall(); 
}
104 105
elsif ($action eq "enter") 
{ 
106
  Bugzilla->login(LOGIN_REQUIRED);
107
  ValidateBugID($::FORM{'bugid'});
108
  validateCanChangeBug($::FORM{'bugid'});
109 110 111 112
  enter(); 
}
elsif ($action eq "insert")
{
113
  Bugzilla->login(LOGIN_REQUIRED);
114
  ValidateBugID($::FORM{'bugid'});
115
  validateCanChangeBug($::FORM{'bugid'});
116
  ValidateComment($::FORM{'comment'});
117 118
  validateFilename();
  validateIsPatch();
119 120
  my $data = validateData();
  validateDescription();
121 122
  validateContentType() unless $::FORM{'ispatch'};
  validateObsolete() if $::FORM{'obsolete'};
123 124 125 126 127 128 129 130 131

  # The order of these function calls is important, as both Flag::validate
  # and FlagType::validate assume User::match_field has ensured that the values
  # in the requestee fields are legitimate user email addresses.
  Bugzilla::User::match_field({ '^requestee(_type)?-(\d+)$' => 
                                    { 'type' => 'single' } });
  Bugzilla::Flag::validate(\%::FORM, $bugid);
  Bugzilla::FlagType::validate(\%::FORM, $bugid, $::FORM{'id'});
  
132
  insert($data);
133
}
134 135 136
elsif ($action eq "edit") 
{ 
  validateID();
137
  validateCanEdit($::FORM{'id'});
138 139 140 141
  edit(); 
}
elsif ($action eq "update") 
{ 
142
  Bugzilla->login(LOGIN_REQUIRED);
143
  ValidateComment($::FORM{'comment'});
144
  validateID();
145
  validateCanEdit($::FORM{'id'});
146
  validateCanChangeAttachment($::FORM{'id'});
147 148
  validateDescription();
  validateIsPatch();
149
  validateContentType() unless $::FORM{'ispatch'};
150
  validateIsObsolete();
151
  validatePrivate();
152 153 154 155
  
  # The order of these function calls is important, as both Flag::validate
  # and FlagType::validate assume User::match_field has ensured that the values
  # in the requestee fields are legitimate user email addresses.
156 157
  Bugzilla::User::match_field({ '^requestee(_type)?-(\d+)$' => 
                                    { 'type' => 'single' } });
158 159 160
  Bugzilla::Flag::validate(\%::FORM, $bugid);
  Bugzilla::FlagType::validate(\%::FORM, $bugid, $::FORM{'id'});
  
161 162 163 164
  update();
}
else 
{ 
165
  ThrowCodeError("unknown_action", { action => $action });
166 167 168 169 170 171 172 173 174 175
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

sub validateID
{
176 177
    my $param = @_ ? $_[0] : 'id';

178 179 180
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
181 182 183 184 185 186 187
    if ($param eq 'id' && !$cgi->param('id')) {

        print Bugzilla->cgi->header();
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
188
    
189 190 191 192 193 194 195
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
     || ThrowUserError("invalid_attach_id", { attach_id => $cgi->param($param) });
196
  
197
    # Make sure the attachment exists in the database.
198
    SendSQL("SELECT bug_id, isprivate FROM attachments WHERE attach_id = $attach_id");
199
    MoreSQLData()
200
      || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
201

202
    # Make sure the user is authorized to access this attachment's bug.
203
    ($bugid, my $isprivate) = FetchSQLData();
204
    ValidateBugID($bugid);
205 206
    if (($isprivate > 0 ) && Param("insidergroup") && 
        !(UserInGroup(Param("insidergroup")))) {
207
        ThrowUserError("attachment_access_denied");
208
    }
209 210 211

    # XXX shim code, kill $::FORM
    $::FORM{$param} = $attach_id;
212 213
}

214 215
sub validateFormat
{
216 217 218
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
  if ( lsearch(\@_, $format) == -1)
219
  {
220
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
221
  }
222 223 224

  # XXX shim code, kill $::FORM
  $::FORM{'format'} = $format;
225 226 227 228
}

sub validateContext
{
229 230 231 232
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
233
  }
234 235
  # XXX shim code, kill $::FORM
  $::FORM{'context'} = $context;
236 237
}

238 239 240 241 242
sub validateCanEdit
{
    my ($attach_id) = (@_);

    # If the user is not logged in, claim that they can edit. This allows
243
    # the edit screen to be displayed to people who aren't logged in.
244
    # People not logged in can't actually commit changes, because that code
245 246
    # calls Bugzilla->login with LOGIN_REQUIRED, not with LOGIN_NORMAL,
    # before calling this sub
247 248 249 250 251 252 253 254 255 256
    return if $::userid == 0;

    # People in editbugs can edit all attachments
    return if UserInGroup("editbugs");

    # Bug 97729 - the submitter can edit their attachments
    SendSQL("SELECT attach_id FROM attachments WHERE " .
            "attach_id = $attach_id AND submitter_id = $::userid");

    FetchSQLData()
257 258
      || ThrowUserError("illegal_attachment_edit",
                        { attach_id => $attach_id });
259 260
}

261 262 263 264 265 266 267 268 269
sub validateCanChangeAttachment 
{
    my ($attachid) = @_;
    SendSQL("SELECT product_id
             FROM attachments, bugs 
             WHERE attach_id = $attachid
             AND bugs.bug_id = attachments.bug_id");
    my $productid = FetchOneColumn();
    CanEditProductId($productid)
270 271
      || ThrowUserError("illegal_attachment_edit",
                        { attach_id => $attachid });
272 273 274 275 276 277 278 279 280 281
}

sub validateCanChangeBug
{
    my ($bugid) = @_;
    SendSQL("SELECT product_id
             FROM bugs 
             WHERE bug_id = $bugid");
    my $productid = FetchOneColumn();
    CanEditProductId($productid)
282 283
      || ThrowUserError("illegal_attachment_edit_bug",
                        { bug_id => $bugid });
284 285
}

286 287 288
sub validateDescription
{
  $::FORM{'description'}
289
    || ThrowUserError("missing_attachment_description");
290 291 292 293 294 295 296 297
}

sub validateIsPatch
{
  # Set the ispatch flag to zero if it is undefined, since the UI uses
  # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
  # do not get sent in HTML requests.
  $::FORM{'ispatch'} = $::FORM{'ispatch'} ? 1 : 0;
298 299 300 301 302 303 304 305 306

  # Set the content type to text/plain if the attachment is a patch.
  $::FORM{'contenttype'} = "text/plain" if $::FORM{'ispatch'};
}

sub validateContentType
{
  if (!$::FORM{'contenttypemethod'})
  {
307
    ThrowUserError("missing_content_type_method");
308 309 310
  }
  elsif ($::FORM{'contenttypemethod'} eq 'autodetect')
  {
311
    my $contenttype = $cgi->uploadInfo($cgi->param('data'))->{'Content-Type'};
312 313
    # The user asked us to auto-detect the content type, so use the type
    # specified in the HTTP request headers.
314
    if ( !$contenttype )
315
    {
316
      ThrowUserError("missing_content_type");
317
    }
318
    $::FORM{'contenttype'} = $contenttype;
319 320 321 322 323 324 325 326 327 328 329 330 331
  }
  elsif ($::FORM{'contenttypemethod'} eq 'list')
  {
    # The user selected a content type from the list, so use their selection.
    $::FORM{'contenttype'} = $::FORM{'contenttypeselection'};
  }
  elsif ($::FORM{'contenttypemethod'} eq 'manual')
  {
    # The user entered a content type manually, so use their entry.
    $::FORM{'contenttype'} = $::FORM{'contenttypeentry'};
  }
  else
  {
332 333
    ThrowCodeError("illegal_content_type_method",
                   { contenttypemethod => $::FORM{'contenttypemethod'} });
334 335 336 337
  }

  if ( $::FORM{'contenttype'} !~ /^(application|audio|image|message|model|multipart|text|video)\/.+$/ )
  {
338 339
    ThrowUserError("invalid_content_type",
                   { contenttype => $::FORM{'contenttype'} });
340
  }
341 342 343 344 345 346 347 348 349 350
}

sub validateIsObsolete
{
  # Set the isobsolete flag to zero if it is undefined, since the UI uses
  # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
  # do not get sent in HTML requests.
  $::FORM{'isobsolete'} = $::FORM{'isobsolete'} ? 1 : 0;
}

351 352 353 354 355 356 357 358
sub validatePrivate
{
    # Set the isprivate flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
    $::FORM{'isprivate'} = $::FORM{'isprivate'} ? 1 : 0;
}

359 360
sub validateData
{
361 362
  my $maxsize = $::FORM{'ispatch'} ? Param('maxpatchsize') : Param('maxattachmentsize');
  $maxsize *= 1024; # Convert from K
363

364 365
  my $fh = $cgi->upload('data');
  my $data;
366

367 368
  # We could get away with reading only as much as required, except that then
  # we wouldn't have a size to print to the error handler below.
369
  {
370 371 372
      # enable 'slurp' mode
      local $/;
      $data = <$fh>;
373
  }
374 375 376 377 378 379 380

  $data
    || ThrowUserError("zero_length_file");

  # Make sure the attachment does not exceed the maximum permitted size
  my $len = length($data);
  if ($maxsize && $len > $maxsize) {
381
      my $vars = { filesize => sprintf("%.0f", $len/1024) };
382
      if ( $::FORM{'ispatch'} ) {
383
          ThrowUserError("patch_too_large", $vars);
384
      } else {
385
          ThrowUserError("file_too_large", $vars);
386 387 388 389
      }
  }

  return $data;
390 391
}

392
my $filename;
393 394
sub validateFilename
{
395
  defined $cgi->upload('data')
396
    || ThrowUserError("file_not_specified");
397 398 399 400 401 402 403 404 405 406 407 408 409

  $filename = $cgi->upload('data');
  
  # Remove path info (if any) from the file name.  The browser should do this
  # for us, but some are buggy.  This may not work on Mac file names and could
  # mess up file names with slashes in them, but them's the breaks.  We only
  # use this as a hint to users downloading attachments anyway, so it's not 
  # a big deal if it munges incorrectly occasionally.
  $filename =~ s/^.*[\/\\]//;

  # Truncate the filename to 100 characters, counting from the end of the string
  # to make sure we keep the filename extension.
  $filename = substr($filename, -100, 100);
410 411 412 413 414 415 416
}

sub validateObsolete
{
  # Make sure the attachment id is valid and the user has permissions to view
  # the bug to which it is attached.
  foreach my $attachid (@{$::MFORM{'obsolete'}}) {
417
    my $vars = {};
418 419
    $vars->{'attach_id'} = $attachid;
    
420
    detaint_natural($attachid)
421
      || ThrowCodeError("invalid_attach_id_to_obsolete", $vars);
422 423 424 425 426 427
  
    SendSQL("SELECT bug_id, isobsolete, description 
             FROM attachments WHERE attach_id = $attachid");

    # Make sure the attachment exists in the database.
    MoreSQLData()
428
      || ThrowUserError("invalid_attach_id", $vars);
429 430 431

    my ($bugid, $isobsolete, $description) = FetchSQLData();

432 433
    $vars->{'description'} = $description;
    
434 435
    if ($bugid != $::FORM{'bugid'})
    {
436 437
      $vars->{'my_bug_id'} = $::FORM{'bugid'};
      $vars->{'attach_bug_id'} = $bugid;
438
      ThrowCodeError("mismatched_bug_ids_on_obsolete", $vars);
439 440 441 442
    }

    if ( $isobsolete )
    {
443
      ThrowCodeError("attachment_already_obsolete", $vars);
444
    }
445 446 447

    # Check that the user can modify this attachment
    validateCanEdit($attachid);
448
  }
449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470
}

# Returns 1 if the parameter is a content-type viewable in this browser
# Note that we don't use $cgi->Accept()'s ability to check if a content-type
# matches, because this will return a value even if it's matched by the generic
# */* which most browsers add to the end of their Accept: headers.
sub isViewable
{
  my $contenttype = trim(shift);
    
  # We assume we can view all text and image types  
  if ($contenttype =~ /^(text|image)\//) {
    return 1;
  }
  
  # Mozilla can view XUL. Note the trailing slash on the Gecko detection to
  # avoid sending XUL to Safari.
  if (($contenttype =~ /^application\/vnd\.mozilla\./) &&
      ($cgi->user_agent() =~ /Gecko\//))
  {
    return 1;
  }
471

472 473 474 475 476 477 478 479 480
  # If it's not one of the above types, we check the Accept: header for any 
  # types mentioned explicitly.
  my $accept = join(",", $cgi->Accept());
  
  if ($accept =~ /^(.*,)?\Q$contenttype\E(,.*)?$/) {
    return 1;
  }
  
  return 0;
481 482
}

483 484 485 486 487 488
################################################################################
# Functions
################################################################################

sub view
{
489
    # Display an attachment.
490

491
    # Retrieve the attachment content and its content type from the database.
492 493
    SendSQL("SELECT mimetype, filename, thedata FROM attachments WHERE attach_id = $::FORM{'id'}");
    my ($contenttype, $filename, $thedata) = FetchSQLData();
494 495
   
    # Bug 111522: allow overriding content-type manually in the posted $::FORM.
496
    if ($::FORM{'content_type'})
497 498
    {
        $::FORM{'contenttypemethod'} = 'manual';
499
        $::FORM{'contenttypeentry'} = $::FORM{'content_type'};
500
        validateContentType();
501
        $contenttype = $::FORM{'content_type'};
502
    }
503

504
    # Return the appropriate HTTP response headers.
505 506
    $filename =~ s/^.*[\/\\]//;
    my $filesize = length($thedata);
507

508 509 510 511
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

512
    print Bugzilla->cgi->header(-type=>"$contenttype; name=\"$filename\"",
513
                                -content_disposition=> "inline; filename=\"$filename\"",
514 515 516
                                -content_length => $filesize);

    print $thedata;
517 518
}

519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538
sub interdiff
{
  # Get old patch data
  my ($old_bugid, $old_description, $old_filename, $old_file_list) =
      get_unified_diff($::FORM{'oldid'});

  # Get new patch data
  my ($new_bugid, $new_description, $new_filename, $new_file_list) =
      get_unified_diff($::FORM{'newid'});

  my $warning = warn_if_interdiff_might_fail($old_file_list, $new_file_list);

  #
  # send through interdiff, send output directly to template
  #
  # Must hack path so that interdiff will work.
  #
  $ENV{'PATH'} = $::diffpath;
  open my $interdiff_fh, "$::interdiffbin $old_filename $new_filename|";
  binmode $interdiff_fh;
539
  my ($reader, $last_reader) = setup_patch_readers("");
540 541
  if ($::FORM{'format'} eq "raw")
  {
542 543
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
544 545 546 547 548 549 550 551 552 553 554 555 556 557 558
    # Actually print out the patch
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
  }
  else
  {
    $vars->{warning} = $warning if $warning;
    $vars->{bugid} = $new_bugid;
    $vars->{oldid} = $::FORM{'oldid'};
    $vars->{old_desc} = $old_description;
    $vars->{newid} = $::FORM{'newid'};
    $vars->{new_desc} = $new_description;
    delete $vars->{attachid};
    delete $vars->{do_context};
    delete $vars->{context};
559
    setup_template_patch_reader($last_reader);
560
  }
561
  $reader->iterate_fh($interdiff_fh, "interdiff #$::FORM{'oldid'} #$::FORM{'newid'}");
562 563 564 565 566 567 568 569 570 571 572 573 574 575 576
  close $interdiff_fh;
  $ENV{'PATH'} = '';

  #
  # Delete temporary files
  #
  unlink($old_filename) or warn "Could not unlink $old_filename: $!";
  unlink($new_filename) or warn "Could not unlink $new_filename: $!";
}

sub get_unified_diff
{
  my ($id) = @_;

  # Bring in the modules we need
577 578 579 580
  require PatchReader::Raw;
  require PatchReader::FixPatchRoot;
  require PatchReader::DiffPrinter::raw;
  require PatchReader::PatchInfoGrabber;
581 582 583 584 585 586 587 588 589 590 591
  require File::Temp;

  # Get the patch
  SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments WHERE attach_id = $id");
  my ($bugid, $description, $ispatch, $thedata) = FetchSQLData();
  if (!$ispatch) {
    $vars->{'attach_id'} = $id;
    ThrowCodeError("must_be_patch");
  }

  # Reads in the patch, converting to unified diff in a temp file
592 593 594
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;

595
  # fixes patch root (makes canonical if possible)
596 597 598 599 600 601
  if (Param('cvsroot')) {
    my $fix_patch_root = new PatchReader::FixPatchRoot(Param('cvsroot'));
    $last_reader->sends_data_to($fix_patch_root);
    $last_reader = $fix_patch_root;
  }

602
  # Grabs the patch file info
603 604 605 606
  my $patch_info_grabber = new PatchReader::PatchInfoGrabber();
  $last_reader->sends_data_to($patch_info_grabber);
  $last_reader = $patch_info_grabber;

607 608
  # Prints out to temporary file
  my ($fh, $filename) = File::Temp::tempfile();
609 610 611 612
  my $raw_printer = new PatchReader::DiffPrinter::raw($fh);
  $last_reader->sends_data_to($raw_printer);
  $last_reader = $raw_printer;

613
  # Iterate!
614
  $reader->iterate_string($id, $thedata);
615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639

  return ($bugid, $description, $filename, $patch_info_grabber->patch_info()->{files});
}

sub warn_if_interdiff_might_fail {
  my ($old_file_list, $new_file_list) = @_;
  # Verify that the list of files diffed is the same
  my @old_files = sort keys %{$old_file_list};
  my @new_files = sort keys %{$new_file_list};
  if (@old_files != @new_files ||
      join(' ', @old_files) ne join(' ', @new_files)) {
    return "interdiff1";
  }

  # Verify that the revisions in the files are the same
  foreach my $file (keys %{$old_file_list}) {
    if ($old_file_list->{$file}{old_revision} ne
        $new_file_list->{$file}{old_revision}) {
      return "interdiff2";
    }
  }

  return undef;
}

640
sub setup_patch_readers {
641 642 643 644 645 646 647 648 649 650
  my ($diff_root) = @_;

  #
  # Parameters:
  # format=raw|html
  # context=patch|file|0-n
  # collapsed=0|1
  # headers=0|1
  #

651 652 653 654 655
  # Define the patch readers
  # The reader that reads the patch in (whatever its format)
  require PatchReader::Raw;
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;
656 657 658
  # Fix the patch root if we have a cvs root
  if (Param('cvsroot'))
  {
659 660 661 662
    require PatchReader::FixPatchRoot;
    $last_reader->sends_data_to(new PatchReader::FixPatchRoot(Param('cvsroot')));
    $last_reader->sends_data_to->diff_root($diff_root) if defined($diff_root);
    $last_reader = $last_reader->sends_data_to;
663 664 665 666
  }
  # Add in cvs context if we have the necessary info to do it
  if ($::FORM{'context'} ne "patch" && $::cvsbin && Param('cvsroot_get'))
  {
667 668 669
    require PatchReader::AddCVSContext;
    $last_reader->sends_data_to(
        new PatchReader::AddCVSContext($::FORM{'context'},
670
                                         Param('cvsroot_get')));
671
    $last_reader = $last_reader->sends_data_to;
672
  }
673
  return ($reader, $last_reader);
674 675
}

676
sub setup_template_patch_reader
677
{
678
  my ($last_reader) = @_;
679

680
  require PatchReader::DiffPrinter::template;
681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696

  my $format = $::FORM{'format'};

  # Define the vars for templates
  if (defined($::FORM{'headers'})) {
    $vars->{headers} = $::FORM{'headers'};
  } else {
    $vars->{headers} = 1 if !defined($::FORM{'headers'});
  }
  $vars->{collapsed} = $::FORM{'collapsed'};
  $vars->{context} = $::FORM{'context'};
  $vars->{do_context} = $::cvsbin && Param('cvsroot_get') && !$vars->{'newid'};

  # Print everything out
  print $cgi->header(-type => 'text/html',
                     -expires => '+3M');
697
  $last_reader->sends_data_to(new PatchReader::DiffPrinter::template($template,
698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720
                             "attachment/diff-header.$format.tmpl",
                             "attachment/diff-file.$format.tmpl",
                             "attachment/diff-footer.$format.tmpl",
                             { %{$vars},
                               bonsai_url => Param('bonsai_url'),
                               lxr_url => Param('lxr_url'),
                               lxr_root => Param('lxr_root'),
                             }));
}

sub diff
{
  # Get patch data
  SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments WHERE attach_id = $::FORM{'id'}");
  my ($bugid, $description, $ispatch, $thedata) = FetchSQLData();

  # If it is not a patch, view normally
  if (!$ispatch)
  {
    view();
    return;
  }

721
  my ($reader, $last_reader) = setup_patch_readers();
722 723 724

  if ($::FORM{'format'} eq "raw")
  {
725 726
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
727 728 729 730
    # Actually print out the patch
    use vars qw($cgi);
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
731
    $reader->iterate_string("Attachment " . $::FORM{'id'}, $thedata);
732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756
  }
  else
  {
    $vars->{other_patches} = [];
    if ($::interdiffbin && $::diffpath) {
      # Get list of attachments on this bug.
      # Ignore the current patch, but select the one right before it
      # chronologically.
      SendSQL("SELECT attach_id, description FROM attachments WHERE bug_id = $bugid AND ispatch = 1 ORDER BY creation_ts DESC");
      my $select_next_patch = 0;
      while (my ($other_id, $other_desc) = FetchSQLData()) {
        if ($other_id eq $::FORM{'id'}) {
          $select_next_patch = 1;
        } else {
          push @{$vars->{other_patches}}, { id => $other_id, desc => $other_desc, selected => $select_next_patch };
          if ($select_next_patch) {
            $select_next_patch = 0;
          }
        }
      }
    }

    $vars->{bugid} = $bugid;
    $vars->{attachid} = $::FORM{'id'};
    $vars->{description} = $description;
757
    setup_template_patch_reader($last_reader);
758
    # Actually print out the patch
759
    $reader->iterate_string("Attachment " . $::FORM{'id'}, $thedata);
760 761
  }
}
762 763 764 765 766 767 768

sub viewall
{
  # Display all attachments for a given bug in a series of IFRAMEs within one HTML page.

  # Retrieve the attachments from the database and write them into an array
  # of hashes where each hash represents one attachment.
769 770 771 772
    my $privacy = "";
    if (Param("insidergroup") && !(UserInGroup(Param("insidergroup")))) {
        $privacy = "AND isprivate < 1 ";
    }
773
    SendSQL("SELECT attach_id, DATE_FORMAT(creation_ts, '%Y.%m.%d %H:%i'),
774 775
            mimetype, description, ispatch, isobsolete, isprivate, 
            LENGTH(thedata)
776 777
            FROM attachments WHERE bug_id = $::FORM{'bugid'} $privacy 
            ORDER BY attach_id");
778
  my @attachments; # the attachments array
779 780
  while (MoreSQLData())
  {
781
    my %a; # the attachment hash
782
    ($a{'attachid'}, $a{'date'}, $a{'contenttype'}, 
783 784
     $a{'description'}, $a{'ispatch'}, $a{'isobsolete'}, $a{'isprivate'},
     $a{'datasize'}) = FetchSQLData();
785
    $a{'isviewable'} = isViewable($a{'contenttype'});
786 787
    $a{'flags'} = Bugzilla::Flag::match({ 'attach_id' => $a{'attachid'},
                                          'is_active' => 1 });
788 789 790 791 792

    # Add the hash representing the attachment to the array of attachments.
    push @attachments, \%a;
  }

793 794 795 796
  # Retrieve the bug summary (for displaying on screen) and assignee.
  SendSQL("SELECT short_desc, assigned_to FROM bugs " .
          "WHERE bug_id = $::FORM{'bugid'}");
  my ($bugsummary, $assignee_id) = FetchSQLData();
797 798 799 800

  # Define the variables and functions that will be passed to the UI template.
  $vars->{'bugid'} = $::FORM{'bugid'};
  $vars->{'attachments'} = \@attachments;
801 802
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
803
  $vars->{'GetBugLink'} = \&GetBugLink;
804

805
  print Bugzilla->cgi->header();
806 807

  # Generate and return the UI (HTML page) from the appropriate template.
808 809
  $template->process("attachment/show-multiple.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
810 811 812
}


813 814 815 816
sub enter
{
  # Display a form for entering a new attachment.

817 818 819 820 821 822
  # Retrieve the attachments the user can edit from the database and write
  # them into an array of hashes where each hash represents one attachment.
  my $canEdit = "";
  if (!UserInGroup("editbugs")) {
      $canEdit = "AND submitter_id = $::userid";
  }
823
  SendSQL("SELECT attach_id, description, isprivate
824 825
           FROM attachments
           WHERE bug_id = $::FORM{'bugid'}
826
           AND isobsolete = 0 $canEdit
827 828 829 830
           ORDER BY attach_id");
  my @attachments; # the attachments array
  while ( MoreSQLData() ) {
    my %a; # the attachment hash
831
    ($a{'id'}, $a{'description'}, $a{'isprivate'}) = FetchSQLData();
832 833 834 835 836

    # Add the hash representing the attachment to the array of attachments.
    push @attachments, \%a;
  }

837 838 839 840
  # Retrieve the bug summary (for displaying on screen) and assignee.
  SendSQL("SELECT short_desc, assigned_to FROM bugs 
           WHERE bug_id = $::FORM{'bugid'}");
  my ($bugsummary, $assignee_id) = FetchSQLData();
841 842 843 844

  # Define the variables and functions that will be passed to the UI template.
  $vars->{'bugid'} = $::FORM{'bugid'};
  $vars->{'attachments'} = \@attachments;
845 846
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
847
  $vars->{'GetBugLink'} = \&GetBugLink;
848

849 850 851 852 853 854 855 856 857 858
  SendSQL("SELECT product_id, component_id FROM bugs
           WHERE bug_id = $::FORM{'bugid'}");
  my ($product_id, $component_id) = FetchSQLData();
  my $flag_types = Bugzilla::FlagType::match({'target_type'  => 'attachment',
                                              'product_id'   => $product_id,
                                              'component_id' => $component_id});
  $vars->{'flag_types'} = $flag_types;
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'},
                                           @$flag_types);

859
  print Bugzilla->cgi->header();
860 861

  # Generate and return the UI (HTML page) from the appropriate template.
862 863
  $template->process("attachment/create.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
864 865 866 867 868
}


sub insert
{
869 870
  my ($data) = @_;

871 872 873
  # Insert a new attachment into the database.

  # Escape characters in strings that will be used in SQL statements.
874
  $filename = SqlQuote($filename);
875 876
  my $description = SqlQuote($::FORM{'description'});
  my $contenttype = SqlQuote($::FORM{'contenttype'});
877
  my $thedata = SqlQuote($data);
878
  my $isprivate = $::FORM{'isprivate'} ? 1 : 0;
879

880 881 882 883
  # Figure out when the changes were made.
  my ($timestamp) = Bugzilla->dbh->selectrow_array("SELECT NOW()"); 
  my $sql_timestamp = SqlQuote($timestamp); 

884
  # Insert the attachment into the database.
885
  SendSQL("INSERT INTO attachments (bug_id, creation_ts, filename, description, mimetype, ispatch, isprivate, submitter_id, thedata) 
886
           VALUES ($::FORM{'bugid'}, $sql_timestamp, $filename, $description, $contenttype, $::FORM{'ispatch'}, $isprivate, $::userid, $thedata)");
887 888 889 890 891 892

  # Retrieve the ID of the newly created attachment record.
  SendSQL("SELECT LAST_INSERT_ID()");
  my $attachid = FetchOneColumn();

  # Insert a comment about the new attachment into the database.
893
  my $comment = "Created an attachment (id=$attachid)\n$::FORM{'description'}\n";
894 895 896 897 898 899 900 901
  $comment .= ("\n" . $::FORM{'comment'}) if $::FORM{'comment'};

  use Text::Wrap;
  $Text::Wrap::columns = 80;
  $Text::Wrap::huge = 'overflow';
  $comment = Text::Wrap::wrap('', '', $comment);

  AppendComment($::FORM{'bugid'}, 
902
                Bugzilla->user->login,
903
                $comment,
904 905
                $isprivate,
                $timestamp);
906 907 908

  # Make existing attachments obsolete.
  my $fieldid = GetFieldID('attachments.isobsolete');
909 910
  foreach my $obsolete_id (@{$::MFORM{'obsolete'}}) {
      SendSQL("UPDATE attachments SET isobsolete = 1 WHERE attach_id = $obsolete_id");
911
      SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
912
               VALUES ($::FORM{'bugid'}, $obsolete_id, $::userid, $sql_timestamp, $fieldid, '0', '1')");
913
      # If the obsolete attachment has pending flags, migrate them to the new attachment.
914 915 916
      if (Bugzilla::Flag::count({ 'attach_id' => $obsolete_id , 
                                  'status' => 'pending',
                                  'is_active' => 1 })) {
917
        Bugzilla::Flag::migrate($obsolete_id, $attachid, $timestamp);
918
      }
919 920
  }

921
  # Assign the bug to the user, if they are allowed to take it
922
  my $owner = "";
923 924 925 926 927 928 929 930 931 932 933 934 935 936
  
  if ($::FORM{'takebug'} && UserInGroup("editbugs")) {
      
      my @fields = ("assigned_to", "bug_status", "resolution", "login_name");
      
      # Get the old values, for the bugs_activity table
      SendSQL("SELECT " . join(", ", @fields) . " FROM bugs, profiles " .
              "WHERE bugs.bug_id = $::FORM{'bugid'} " .
              "AND   profiles.userid = bugs.assigned_to");
      
      my @oldvalues = FetchSQLData();
      my @newvalues = ($::userid, "ASSIGNED", "", DBID_to_name($::userid));
      
      # Make sure the person we are taking the bug from gets mail.
937
      $owner = $oldvalues[3];  
938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957
                  
      @oldvalues = map(SqlQuote($_), @oldvalues);
      @newvalues = map(SqlQuote($_), @newvalues);
               
      # Update the bug record. Note that this doesn't involve login_name.
      SendSQL("UPDATE bugs SET " . 
              join(", ", map("$fields[$_] = $newvalues[$_]", (0..2))) . 
              " WHERE bug_id = $::FORM{'bugid'}");
      
      # We store email addresses in the bugs_activity table rather than IDs.
      $oldvalues[0] = $oldvalues[3];
      $newvalues[0] = $newvalues[3];
      
      # Add the changes to the bugs_activity table
      for (my $i = 0; $i < 3; $i++) {
          if ($oldvalues[$i] ne $newvalues[$i]) {
              my $fieldid = GetFieldID($fields[$i]);
              SendSQL("INSERT INTO bugs_activity " .
                      "(bug_id, who, bug_when, fieldid, removed, added) " .
                      " VALUES ($::FORM{'bugid'}, $::userid, " . 
958
                      "$sql_timestamp " . 
959 960 961 962 963
                      ", $fieldid, $oldvalues[$i], $newvalues[$i])");
          }
      }      
  }   
  
964 965 966 967
  # Create flags.
  my $target = Bugzilla::Flag::GetTarget(undef, $attachid);
  Bugzilla::Flag::process($target, $timestamp, \%::FORM);
   
968
  # Define the variables and functions that will be passed to the UI template.
969
  $vars->{'mailrecipients'} =  { 'changer' => Bugzilla->user->login,
970
                                 'owner'   => $owner };
971 972 973 974 975 976 977
  my $bugid = $::FORM{'bugid'};
  detaint_natural($bugid); # don't bother with error condition, we know it'll work
                           # because of ValidateBugID above.  This is only needed
                           # for Perl 5.6.0.  If we ever require Perl 5.6.1 or
                           # newer, or detaint something other than $::FORM{'bugid'}
                           # in ValidateBugID above, then this can go away.
  $vars->{'bugid'} = $bugid;
978 979 980 981 982
  $vars->{'attachid'} = $attachid;
  $vars->{'description'} = $description;
  $vars->{'contenttypemethod'} = $::FORM{'contenttypemethod'};
  $vars->{'contenttype'} = $::FORM{'contenttype'};

983
  print Bugzilla->cgi->header();
984 985

  # Generate and return the UI (HTML page) from the appropriate template.
986 987
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
988 989 990
}


991 992
sub edit
{
993 994 995 996
  # Edit an attachment record.  Users with "editbugs" privileges, (or the 
  # original attachment's submitter) can edit the attachment's description,
  # content type, ispatch and isobsolete flags, and statuses, and they can
  # also submit a comment that appears in the bug.
997 998 999
  # Users cannot edit the content of the attachment itself.

  # Retrieve the attachment from the database.
1000
  SendSQL("SELECT description, mimetype, filename, bug_id, ispatch, isobsolete, isprivate, LENGTH(thedata)
1001
           FROM attachments WHERE attach_id = $::FORM{'id'}");
1002
  my ($description, $contenttype, $filename, $bugid, $ispatch, $isobsolete, $isprivate, $datasize) = FetchSQLData();
1003

1004
  my $isviewable = isViewable($contenttype);
1005 1006 1007 1008 1009 1010 1011 1012

  # Retrieve a list of attachments for this bug as well as a summary of the bug
  # to use in a navigation bar across the top of the screen.
  SendSQL("SELECT attach_id FROM attachments WHERE bug_id = $bugid ORDER BY attach_id");
  my @bugattachments;
  push(@bugattachments, FetchSQLData()) while (MoreSQLData());
  SendSQL("SELECT short_desc FROM bugs WHERE bug_id = $bugid");
  my ($bugsummary) = FetchSQLData();
1013 1014 1015 1016 1017
  
  # Get a list of flag types that can be set for this attachment.
  SendSQL("SELECT product_id, component_id FROM bugs WHERE bug_id = $bugid");
  my ($product_id, $component_id) = FetchSQLData();
  my $flag_types = Bugzilla::FlagType::match({ 'target_type'  => 'attachment' , 
1018 1019
                                               'product_id'   => $product_id , 
                                               'component_id' => $component_id });
1020 1021
  foreach my $flag_type (@$flag_types) {
    $flag_type->{'flags'} = Bugzilla::Flag::match({ 'type_id'   => $flag_type->{'id'}, 
1022 1023
                                                    'attach_id' => $::FORM{'id'},
                                                    'is_active' => 1 });
1024 1025
  }
  $vars->{'flag_types'} = $flag_types;
1026
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'}, @$flag_types);
1027
  
1028 1029 1030
  # Define the variables and functions that will be passed to the UI template.
  $vars->{'attachid'} = $::FORM{'id'}; 
  $vars->{'description'} = $description; 
1031
  $vars->{'contenttype'} = $contenttype; 
1032
  $vars->{'filename'} = $filename;
1033 1034 1035 1036
  $vars->{'bugid'} = $bugid; 
  $vars->{'bugsummary'} = $bugsummary; 
  $vars->{'ispatch'} = $ispatch; 
  $vars->{'isobsolete'} = $isobsolete; 
1037
  $vars->{'isprivate'} = $isprivate; 
1038
  $vars->{'datasize'} = $datasize;
1039 1040
  $vars->{'isviewable'} = $isviewable; 
  $vars->{'attachments'} = \@bugattachments; 
1041
  $vars->{'GetBugLink'} = \&GetBugLink;
1042

1043 1044 1045 1046 1047
  # Determine if PatchReader is installed
  eval {
    require PatchReader;
    $vars->{'patchviewerinstalled'} = 1;
  };
1048
  print Bugzilla->cgi->header();
1049 1050

  # Generate and return the UI (HTML page) from the appropriate template.
1051 1052
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1053 1054 1055 1056 1057
}


sub update
{
1058
  # Updates an attachment record.
1059 1060 1061

  # Get the bug ID for the bug to which this attachment is attached.
  SendSQL("SELECT bug_id FROM attachments WHERE attach_id = $::FORM{'id'}");
1062 1063
  my $bugid = FetchSQLData();
  
1064
  # Lock database tables in preparation for updating the attachment.
1065 1066 1067
  SendSQL("LOCK TABLES attachments WRITE , flags WRITE , " . 
          "flagtypes READ , fielddefs READ , bugs_activity WRITE, " . 
          "flaginclusions AS i READ, flagexclusions AS e READ, " . 
1068 1069
          # cc, bug_group_map, user_group_map, and groups are in here so we
          # can check the permissions of flag requestees and email addresses
1070 1071 1072 1073 1074
          # on the flag type cc: lists via the CanSeeBug
          # function call in Flag::notify. group_group_map is in here in case
          # Bugzilla::User needs to rederive groups. profiles and 
          # user_group_map would be READ locks instead of WRITE locks if it
          # weren't for derive_groups, which needs to write to those tables.
1075 1076 1077
          "bugs READ, profiles WRITE, " . 
          "cc READ, bug_group_map READ, user_group_map WRITE, " . 
          "group_group_map READ, groups READ");
1078
  
1079 1080
  # Get a copy of the attachment record before we make changes
  # so we can record those changes in the activity table.
1081
  SendSQL("SELECT description, mimetype, filename, ispatch, isobsolete, isprivate
1082
           FROM attachments WHERE attach_id = $::FORM{'id'}");
1083 1084
  my ($olddescription, $oldcontenttype, $oldfilename, $oldispatch,
      $oldisobsolete, $oldisprivate) = FetchSQLData();
1085

1086
  # Quote the description and content type for use in the SQL UPDATE statement.
1087
  my $quoteddescription = SqlQuote($::FORM{'description'});
1088
  my $quotedcontenttype = SqlQuote($::FORM{'contenttype'});
1089
  my $quotedfilename = SqlQuote($::FORM{'filename'});
1090 1091 1092 1093 1094

  # Update the attachment record in the database.
  # Sets the creation timestamp to itself to avoid it being updated automatically.
  SendSQL("UPDATE  attachments 
           SET     description = $quoteddescription , 
1095
                   mimetype = $quotedcontenttype , 
1096
                   filename = $quotedfilename ,
1097
                   ispatch = $::FORM{'ispatch'} , 
1098 1099
                   isobsolete = $::FORM{'isobsolete'} ,
                   isprivate = $::FORM{'isprivate'} 
1100 1101 1102
           WHERE   attach_id = $::FORM{'id'}
         ");

1103 1104 1105 1106
  # Figure out when the changes were made.
  SendSQL("SELECT NOW()");
  my $timestamp = FetchOneColumn();
    
1107
  # Record changes in the activity table.
1108
  my $sql_timestamp = SqlQuote($timestamp);
1109 1110 1111 1112
  if ($olddescription ne $::FORM{'description'}) {
    my $quotedolddescription = SqlQuote($olddescription);
    my $fieldid = GetFieldID('attachments.description');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1113
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $quotedolddescription, $quoteddescription)");
1114
  }
1115 1116
  if ($oldcontenttype ne $::FORM{'contenttype'}) {
    my $quotedoldcontenttype = SqlQuote($oldcontenttype);
1117 1118
    my $fieldid = GetFieldID('attachments.mimetype');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1119
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $quotedoldcontenttype, $quotedcontenttype)");
1120
  }
1121 1122 1123 1124
  if ($oldfilename ne $::FORM{'filename'}) {
    my $quotedoldfilename = SqlQuote($oldfilename);
    my $fieldid = GetFieldID('attachments.filename');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1125
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $quotedoldfilename, $quotedfilename)");
1126
  }
1127 1128 1129
  if ($oldispatch ne $::FORM{'ispatch'}) {
    my $fieldid = GetFieldID('attachments.ispatch');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1130
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $oldispatch, $::FORM{'ispatch'})");
1131 1132 1133 1134
  }
  if ($oldisobsolete ne $::FORM{'isobsolete'}) {
    my $fieldid = GetFieldID('attachments.isobsolete');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1135
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $oldisobsolete, $::FORM{'isobsolete'})");
1136
  }
1137 1138 1139
  if ($oldisprivate ne $::FORM{'isprivate'}) {
    my $fieldid = GetFieldID('attachments.isprivate');
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, fieldid, removed, added) 
1140
             VALUES ($bugid, $::FORM{'id'}, $::userid, $sql_timestamp, $fieldid, $oldisprivate, $::FORM{'isprivate'})");
1141
  }
1142 1143 1144 1145 1146
  
  # Update flags.
  my $target = Bugzilla::Flag::GetTarget(undef, $::FORM{'id'});
  Bugzilla::Flag::process($target, $timestamp, \%::FORM);
  
1147 1148 1149 1150 1151 1152 1153
  # Unlock all database tables now that we are finished updating the database.
  SendSQL("UNLOCK TABLES");

  # If the user submitted a comment while editing the attachment, 
  # add the comment to the bug.
  if ( $::FORM{'comment'} )
  {
1154 1155 1156 1157
    use Text::Wrap;
    $Text::Wrap::columns = 80;
    $Text::Wrap::huge = 'wrap';

1158
    # Prepend a string to the comment to let users know that the comment came from
1159 1160 1161
    # the "edit attachment" screen.
    my $comment = qq|(From update of attachment $::FORM{'id'})\n| . $::FORM{'comment'};

1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
    my $wrappedcomment = "";
    foreach my $line (split(/\r\n|\r|\n/, $comment))
    {
      if ( $line =~ /^>/ )
      {
        $wrappedcomment .= $line . "\n";
      }
      else
      {
        $wrappedcomment .= wrap('', '', $line) . "\n";
      }
    }

1175 1176 1177 1178 1179 1180
    # Get the user's login name since the AppendComment function needs it.
    my $who = DBID_to_name($::userid);
    # Mention $::userid again so Perl doesn't give me a warning about it.
    my $neverused = $::userid;

    # Append the comment to the list of comments in the database.
1181
    AppendComment($bugid, $who, $wrappedcomment, $::FORM{'isprivate'}, $timestamp);
1182 1183

  }
1184
  
1185
  # Define the variables and functions that will be passed to the UI template.
1186
  $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login };
1187 1188 1189
  $vars->{'attachid'} = $::FORM{'id'}; 
  $vars->{'bugid'} = $bugid; 

1190
  print Bugzilla->cgi->header();
1191 1192

  # Generate and return the UI (HTML page) from the appropriate template.
1193 1194
  $template->process("attachment/updated.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1195
}