Bug 159593 - usedependencies parameter must die. Patch by gerv; r=bbaetz.

Bug.pm

@@ -217,16 +217,14 @@ sub initBug  {
   if (@longdescs) {
     $self->{'longdescs'} = \@longdescs;
   }
-
-  if (&::Param("usedependencies")) {
-    my @depends = EmitDependList("blocked", "dependson", $bug_id);
-    if ( @depends ) {
+  
+  my @depends = EmitDependList("blocked", "dependson", $bug_id);
+  if (@depends) {
       $self->{'dependson'} = \@depends;
-    }
-    my @blocks = EmitDependList("dependson", "blocked", $bug_id);
-    if ( @blocks ) {
-      $self->{'blocks'} = \@blocks;
-    }
+  }  
+  my @blocks = EmitDependList("dependson", "blocked", $bug_id);
+  if (@blocks) {
+    $self->{'blocks'} = \@blocks;
   }
 
   return $self;

Bugzilla/Bug.pm

@@ -217,16 +217,14 @@ sub initBug  {
   if (@longdescs) {
     $self->{'longdescs'} = \@longdescs;
   }
-
-  if (&::Param("usedependencies")) {
-    my @depends = EmitDependList("blocked", "dependson", $bug_id);
-    if ( @depends ) {
+  
+  my @depends = EmitDependList("blocked", "dependson", $bug_id);
+  if (@depends) {
       $self->{'dependson'} = \@depends;
-    }
-    my @blocks = EmitDependList("dependson", "blocked", $bug_id);
-    if ( @blocks ) {
-      $self->{'blocks'} = \@blocks;
-    }
+  }  
+  my @blocks = EmitDependList("dependson", "blocked", $bug_id);
+  if (@blocks) {
+    $self->{'blocks'} = \@blocks;
   }
 
   return $self;

defparams.pl

@@ -395,11 +395,6 @@ DefParam("usebrowserinfo",
          "b",
          1);
 
-DefParam("usedependencies",
-         "Do you wish to use dependencies (allowing you to mark which bugs depend on which other ones)?",
-         "b",
-         1);
-
 DefParam("usevotes",
          "Do you wish to allow users to vote for bugs? Note that in order for this to be effective, you will have to change the maximum votes allowed in a product to be non-zero in <a href=\"editproducts.cgi\">the product edit page</a>.",
          "b",

template/en/default/bug/edit.html.tmpl

@@ -265,7 +265,6 @@
 
 [%# *** Dependencies Votes *** %]
 
-  [% IF Param('usedependencies') %]
   <table>
     <tr>
     [% PROCESS dependencies accesskey = "d"
@@ -287,7 +286,6 @@
        dep = { title => "<u>b</u>locks", fieldname => "blocked" } %]
     </tr>
   </table>
-  [% END %]
 
   [% IF use_votes %]
   <table>